From: Danilo Krummrich <danilokrummrich@dk-develop.de>
To: krzysztof.kozlowski@canonical.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: linus.walleij@linaro.org,
Danilo Krummrich <danilokrummrich@dk-develop.de>
Subject: [RESEND PATCH v3 2/2] dt-bindings: ps2-gpio: document bus signals open drain
Date: Sun, 29 May 2022 15:26:38 +0200 [thread overview]
Message-ID: <20220529132638.13420-2-danilokrummrich@dk-develop.de> (raw)
In-Reply-To: <20220529132638.13420-1-danilokrummrich@dk-develop.de>
The PS/2 bus defines data and clock line to be open drain, this should
be reflected in the gpio flags set in the binding.
Especially, this is important since the clock line sometimes is driven
by the host while being used as interrupt source.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
---
.../devicetree/bindings/serio/ps2-gpio.yaml | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/serio/ps2-gpio.yaml b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml
index 304132fd30c5..a63d9172346f 100644
--- a/Documentation/devicetree/bindings/serio/ps2-gpio.yaml
+++ b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml
@@ -15,12 +15,18 @@ properties:
data-gpios:
description:
- the gpio used for the data signal
+ the gpio used for the data signal - this should be flagged as
+ active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)
+ from <dt-bindings/gpio/gpio.h> since the signal is open drain by
+ definition
maxItems: 1
clk-gpios:
description:
- the gpio used for the clock signal
+ the gpio used for the clock signal - this should be flagged as
+ active high using open drain with (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)
+ from <dt-bindings/gpio/gpio.h> since the signal is open drain by
+ definition
maxItems: 1
interrupts:
@@ -52,7 +58,7 @@ examples:
compatible = "ps2-gpio";
interrupt-parent = <&gpio>;
interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
- data-gpios = <&gpio 24 GPIO_ACTIVE_HIGH>;
- clk-gpios = <&gpio 23 GPIO_ACTIVE_HIGH>;
+ data-gpios = <&gpio 24 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
+ clk-gpios = <&gpio 23 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
write-enable;
};
--
2.36.1
next prev parent reply other threads:[~2022-05-29 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 13:26 [RESEND PATCH v3 1/2] dt-bindings: ps2-gpio: convert binding to json-schema Danilo Krummrich
2022-05-29 13:26 ` Danilo Krummrich [this message]
2022-05-30 9:50 ` [RESEND PATCH v3 2/2] dt-bindings: ps2-gpio: document bus signals open drain Linus Walleij
2022-06-05 14:09 ` Rob Herring
2022-05-30 9:51 ` [RESEND PATCH v3 1/2] dt-bindings: ps2-gpio: convert binding to json-schema Linus Walleij
2022-06-05 14:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220529132638.13420-2-danilokrummrich@dk-develop.de \
--to=danilokrummrich@dk-develop.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).