From: Qun-Wei Lin <qun-wei.lin@mediatek.com>
To: <robh+dt@kernel.org>, <frowand.list@gmail.com>, <matthias.bgg@gmail.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <casper.li@mediatek.com>,
<chinwen.chang@mediatek.com>, <kuan-ying.lee@mediatek.com>,
Qun-Wei Lin <qun-wei.lin@mediatek.com>
Subject: [PATCH] scripts: dtc: fix a false alarm for node_name_chars_strict
Date: Tue, 31 May 2022 13:33:58 +0800 [thread overview]
Message-ID: <20220531053358.19003-1-qun-wei.lin@mediatek.com> (raw)
The function check_node_name_chars_strict issues a false alarm when
compiling an overlay dts.
/fragment@0/__overlay__: Character '_' not recommended in node name
This workaround will fix it by skip checking for node named __overlay__.
Signed-off-by: Qun-Wei Lin <qun-wei.lin@mediatek.com>
---
scripts/dtc/checks.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
index 781ba1129a8e..6ef4f2cd67b9 100644
--- a/scripts/dtc/checks.c
+++ b/scripts/dtc/checks.c
@@ -325,6 +325,11 @@ static void check_node_name_chars_strict(struct check *c, struct dt_info *dti,
{
int n = strspn(node->name, c->data);
+ if (streq(node->name, "__overlay__")) {
+ /* HACK: Overlay fragments are a special case */
+ return;
+ }
+
if (n < node->basenamelen)
FAIL(c, dti, node, "Character '%c' not recommended in node name",
node->name[n]);
--
2.18.0
next reply other threads:[~2022-05-31 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 5:33 Qun-Wei Lin [this message]
2022-05-31 13:06 ` [PATCH] scripts: dtc: fix a false alarm for node_name_chars_strict Rob Herring
2022-05-31 20:43 ` Frank Rowand
2022-05-31 21:49 ` Rob Herring
2022-06-01 1:45 ` Frank Rowand
[not found] ` <b054866a5c043d3b6d5553057b5f5bf7b06681f0.camel@mediatek.com>
2022-06-02 3:07 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531053358.19003-1-qun-wei.lin@mediatek.com \
--to=qun-wei.lin@mediatek.com \
--cc=casper.li@mediatek.com \
--cc=chinwen.chang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kuan-ying.lee@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).