From: Samuel Holland <samuel@sholland.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Maxime Ripard <mripard@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH 0/3] pinctrl: sunxi: Remove non-existent reset line references
Date: Tue, 31 May 2022 00:36:20 -0500 [thread overview]
Message-ID: <20220531053623.43851-1-samuel@sholland.org> (raw)
I assume these properties came from a lack of documentation, and the
very reasonable assumption that where there's a clock gate bit in the
CCU, there's a reset bit. But the pin controllers are special and don't
have a module reset line. The only way to reset the pin controller is to
reset the whole VDD_SYS power domain.
This series is preparation for converting the PRCM MFD and legacy clock
drivers to a CCU clock/reset driver like all of the other Allwinner
SoCs. I don't plan to add reset lines that don't actually exist to the
new CCU driver. So we might as well get rid of the references now.
Technically this breaks devicetree compatibility, since the old drivers
expect the reset. But the CCU conversion will be a compatibility break
anyway, so it's a bit of a moot point.
Samuel Holland (3):
pinctrl: sunxi: Remove reset controller consumers
ARM: dts: sunxi: Drop resets from r_pio nodes
dt-bindings: pinctrl: sunxi: Disallow the resets property
.../pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 3 ---
arch/arm/boot/dts/sun6i-a31.dtsi | 1 -
arch/arm/boot/dts/sun8i-a23-a33.dtsi | 1 -
arch/arm/boot/dts/sun9i-a80.dtsi | 1 -
drivers/pinctrl/sunxi/Kconfig | 3 ---
drivers/pinctrl/sunxi/pinctrl-sun50i-a64-r.c | 1 -
drivers/pinctrl/sunxi/pinctrl-sun50i-h6-r.c | 1 -
drivers/pinctrl/sunxi/pinctrl-sun50i-h616-r.c | 1 -
drivers/pinctrl/sunxi/pinctrl-sun6i-a31-r.c | 22 +---------------
drivers/pinctrl/sunxi/pinctrl-sun8i-a23-r.c | 25 +------------------
drivers/pinctrl/sunxi/pinctrl-sun8i-a83t-r.c | 1 -
drivers/pinctrl/sunxi/pinctrl-sun9i-a80-r.c | 1 -
12 files changed, 2 insertions(+), 59 deletions(-)
--
2.35.1
next reply other threads:[~2022-05-31 5:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 5:36 Samuel Holland [this message]
2022-05-31 5:36 ` [PATCH 1/3] pinctrl: sunxi: Remove reset controller consumers Samuel Holland
2022-05-31 5:36 ` [PATCH 2/3] ARM: dts: sunxi: Drop resets from r_pio nodes Samuel Holland
2022-05-31 5:36 ` [PATCH 3/3] dt-bindings: pinctrl: sunxi: Disallow the resets property Samuel Holland
2022-06-05 21:25 ` Rob Herring
2022-05-31 15:22 ` [PATCH 0/3] pinctrl: sunxi: Remove non-existent reset line references Jernej Škrabec
2022-06-01 4:42 ` Samuel Holland
2022-06-01 15:24 ` Jernej Škrabec
2022-06-15 13:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531053623.43851-1-samuel@sholland.org \
--to=samuel@sholland.org \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox