[PATCH] dt-bindings: soc: qcom,smd: do not use pattern for simple rpm-requests string

[PATCH] dt-bindings: soc: qcom,smd: do not use pattern for simple rpm-requests string

[Krzysztof Kozlowski]

patternProperties should not be used for properties with a simple string
as name:

  Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml: patternProperties:^(.*-edge|rpm)$:patternProperties:
    '^rpm-requests$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#]+\\$$'}

Fixes: 375eed5f51a8 ("dt-bindings: soc: qcom,smd: convert to dtschema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
index e6f9ffa1c0ea..bca07bb13ebf 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml
@@ -66,9 +66,7 @@ patternProperties:
           The identifier for the remote processor as known by the rest of the
           system.
 
-    # Binding for edge subnodes is not complete
-    patternProperties:
-      "^rpm-requests$":
+      rpm-requests:
         type: object
         description:
           In turn, subnodes of the "edges" represent devices tied to SMD
-- 
2.34.1

Re: [PATCH] dt-bindings: soc: qcom,smd: do not use pattern for simple rpm-requests string

[Rob Herring]

On Tue, 24 May 2022 09:04:08 +0200, Krzysztof Kozlowski wrote:
> patternProperties should not be used for properties with a simple string
> as name:
> 
>   Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml: patternProperties:^(.*-edge|rpm)$:patternProperties:
>     '^rpm-requests$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#]+\\$$'}
> 
> Fixes: 375eed5f51a8 ("dt-bindings: soc: qcom,smd: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] dt-bindings: soc: qcom,smd: do not use pattern for simple rpm-requests string

[Rob Herring]

On Tue, 24 May 2022 09:04:08 +0200, Krzysztof Kozlowski wrote:
> patternProperties should not be used for properties with a simple string
> as name:
> 
>   Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml: patternProperties:^(.*-edge|rpm)$:patternProperties:
>     '^rpm-requests$' should not be valid under {'pattern': '^\\^[a-zA-Z0-9,\\-._#]+\\$$'}
> 
> Fixes: 375eed5f51a8 ("dt-bindings: soc: qcom,smd: convert to dtschema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Now failing in Linus' tree and linux-next and no response, so I've 
applied.

Rob