From: Rob Herring <robh@kernel.org>
To: Dipen Patel <dipenp@nvidia.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH] dt-bindings: timestamp: Correct id path
Date: Tue, 31 May 2022 16:42:09 -0500 [thread overview]
Message-ID: <20220531214209.GA2350029-robh@kernel.org> (raw)
In-Reply-To: <86b11457-2f1a-6b17-fab0-a13d932af993@nvidia.com>
On Tue, May 31, 2022 at 10:35:55AM -0700, Dipen Patel wrote:
> Hi Rob,
>
> What is the failing signature and command? I tried below commands on 31st May
Well, you fixed it in your patch. I'd hope you'd know.
>
> linux-next and I can not see any failure.
You confirm your fix is there?
>
> make O=./output/ DT_CHECKER_FLAGS=-m dt_binding_check
> DTC Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb
> DTC Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb
> DTC Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb
> CHECK Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb
> CHECK Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb
> CHECK Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb
Had you already run dt_binding_check?
>
> make O=./output/ dt_binding_check
> LINT Documentation/devicetree/bindings
> DTEX Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dts
> DTEX Documentation/devicetree/bindings/timestamp/hte-consumer.example.dts
> DTEX Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dts
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> DTC Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb
> DTC Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb
> CHECK Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb
> CHECK Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb
> DTC Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb
I don't see 'SCHEMA' target here. It should have run since LINT and
CHKDT did.
Do a 'rm output/Documentation/devicetree/bindings/processed-schema.json'
first.
Rob
>
>
> make O=./output dtbs_check
>
>
> Best Regards,
>
> Dipen Patel
>
> On 5/31/22 6:33 AM, Rob Herring wrote:
> > On Mon, May 23, 2022 at 12:25 PM Dipen Patel <dipenp@nvidia.com> wrote:
> >> During the repository renaming from hte to timestamp, $id path was not
> >> updated accordingly. This patch corrects $id path.
> >>
> >> Fixes: af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
> >> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
> >> ---
> >> .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +-
> >> Documentation/devicetree/bindings/timestamp/hte-consumer.yaml | 2 +-
> >> .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml | 2 +-
> >> 3 files changed, 3 insertions(+), 3 deletions(-)
> > Ping. Still failing in linux-next.
> >
> >> diff --git a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
> >> index 4c25ba248a72..fd6a7b51f571 100644
> >> --- a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
> >> +++ b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
> >> @@ -1,7 +1,7 @@
> >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> %YAML 1.2
> >> ---
> >> -$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
> >> +$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
> >> $schema: http://devicetree.org/meta-schemas/core.yaml#
> >>
> >> title: Hardware timestamp providers
> >> diff --git a/Documentation/devicetree/bindings/timestamp/hte-consumer.yaml b/Documentation/devicetree/bindings/timestamp/hte-consumer.yaml
> >> index 68d764ac040a..6456515c3d26 100644
> >> --- a/Documentation/devicetree/bindings/timestamp/hte-consumer.yaml
> >> +++ b/Documentation/devicetree/bindings/timestamp/hte-consumer.yaml
> >> @@ -1,7 +1,7 @@
> >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> %YAML 1.2
> >> ---
> >> -$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
> >> +$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
> >> $schema: http://devicetree.org/meta-schemas/core.yaml#
> >>
> >> title: HTE Consumer Device Tree Bindings
> >> diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> >> index 69e8402d95e5..c31e207d1652 100644
> >> --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> >> +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
> >> @@ -1,7 +1,7 @@
> >> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> %YAML 1.2
> >> ---
> >> -$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
> >> +$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
> >> $schema: http://devicetree.org/meta-schemas/core.yaml#
> >>
> >> title: Tegra194 on chip generic hardware timestamping engine (HTE)
> >>
> >> base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb
> >> --
> >> 2.17.1
> >>
next prev parent reply other threads:[~2022-05-31 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:25 [PATCH] dt-bindings: timestamp: Correct id path Dipen Patel
2022-05-24 2:09 ` Rob Herring
2022-05-31 13:33 ` Rob Herring
2022-05-31 17:35 ` Dipen Patel
2022-05-31 21:42 ` Rob Herring [this message]
2022-05-31 22:53 ` Dipen Patel
2022-06-02 15:57 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531214209.GA2350029-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).