From: Rob Herring <robh@kernel.org>
To: Frank Rowand <frowand.list@gmail.com>
Cc: Qun-Wei Lin <qun-wei.lin@mediatek.com>,
matthias.bgg@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, casper.li@mediatek.com,
chinwen.chang@mediatek.com, kuan-ying.lee@mediatek.com
Subject: Re: [PATCH] scripts: dtc: fix a false alarm for node_name_chars_strict
Date: Tue, 31 May 2022 16:49:14 -0500 [thread overview]
Message-ID: <20220531214914.GA2388344-robh@kernel.org> (raw)
In-Reply-To: <8d4b8cc3-8433-24f9-1fc5-12d71e640952@gmail.com>
On Tue, May 31, 2022 at 04:43:18PM -0400, Frank Rowand wrote:
> On 5/31/22 01:33, Qun-Wei Lin wrote:
> > The function check_node_name_chars_strict issues a false alarm when
> > compiling an overlay dts.
> >
> > /fragment@0/__overlay__: Character '_' not recommended in node name
> >
> > This workaround will fix it by skip checking for node named __overlay__.
>
> This is not a false alarm.
>
> Do not special case node name "__overlay__". This node name should never
> occur in a modern overlay source file.
A dtbo -> dts pass will give warnings, so handling these nodes is
worthwhile. Though thinking a bit more about it, I think this one is off
by default, but W=2 turns it on.
Rob
next prev parent reply other threads:[~2022-05-31 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 5:33 [PATCH] scripts: dtc: fix a false alarm for node_name_chars_strict Qun-Wei Lin
2022-05-31 13:06 ` Rob Herring
2022-05-31 20:43 ` Frank Rowand
2022-05-31 21:49 ` Rob Herring [this message]
2022-06-01 1:45 ` Frank Rowand
[not found] ` <b054866a5c043d3b6d5553057b5f5bf7b06681f0.camel@mediatek.com>
2022-06-02 3:07 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531214914.GA2388344-robh@kernel.org \
--to=robh@kernel.org \
--cc=casper.li@mediatek.com \
--cc=chinwen.chang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kuan-ying.lee@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qun-wei.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).