From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: ChiYuan Huang <u0084500@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
jingoohan1@gmail.com, Pavel Machek <pavel@ucw.cz>,
deller@gmx.de, cy_huang <cy_huang@richtek.com>,
lucas_tsai@richtek.com,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection
Date: Thu, 2 Jun 2022 08:56:04 -0500 [thread overview]
Message-ID: <20220602135604.GA2194286-robh@kernel.org> (raw)
In-Reply-To: <076d53d3-6062-686f-8e45-14c5f936bbf6@linaro.org>
On Thu, May 26, 2022 at 12:32:12PM +0200, Krzysztof Kozlowski wrote:
> On 26/05/2022 10:13, ChiYuan Huang wrote:
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年5月26日 週四 下午4:06寫道：
> >>
> >> On 26/05/2022 05:16, cy_huang wrote:
> >>> From: ChiYuan Huang <cy_huang@richtek.com>
> >>>
> >>> Add the new property for ocp level selection.
> >>>
> >>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> >>> ---
> >>> .../bindings/leds/backlight/richtek,rt4831-backlight.yaml | 8 ++++++++
> >>> include/dt-bindings/leds/rt4831-backlight.h | 5 +++++
> >>> 2 files changed, 13 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> >>> index e0ac686..c1c59de 100644
> >>> --- a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> >>> +++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
> >>> @@ -47,6 +47,14 @@ properties:
> >>> minimum: 0
> >>> maximum: 3
> >>>
> >>> + richtek,bled-ocp-sel:
> >>
> >> Skip "sel" as it is a shortcut of selection. Name instead:
> >> "richtek,backlight-ocp"
> >>
> > OK, if so, do I need to rename all properties from 'bled' to 'backlight' ?
> > If only this property is naming as 'backlight'. it may conflict with
> > the others like as "richtek,bled-ovp-sel".
>
> Ah, no, no need.
>
> >>
> >>> + description: |
> >>> + Backlight OCP level selection, currently support 0.9A/1.2A/1.5A/1.8A
> >>
> >> Could you explain here what is OCP (unfold the acronym)?
> > Yes. And the full name is 'over current protection'.
>
> Thanks and this leads to second thing - you encode register value
> instead of logical value. This must be a logical value in mA, so
> "richtek,bled-ocp-microamp".
We already have common properties for setting current of LEDs. We should
use that here I think.
Rob
next prev parent reply other threads:[~2022-06-02 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 3:16 [PATCH 0/2] Add the property to make ocp level selectable cy_huang
2022-05-26 3:16 ` [PATCH 1/2] dt-bindings: backlight: rt4831: Add the new property for ocp level selection cy_huang
2022-05-26 8:06 ` Krzysztof Kozlowski
2022-05-26 8:13 ` ChiYuan Huang
2022-05-26 10:32 ` Krzysztof Kozlowski
2022-06-02 13:56 ` Rob Herring [this message]
2022-06-02 13:58 ` Krzysztof Kozlowski
2022-06-02 15:31 ` ChiYuan Huang
2022-06-05 16:11 ` Krzysztof Kozlowski
2022-06-06 1:39 ` ChiYuan Huang
2022-06-06 6:20 ` Krzysztof Kozlowski
2022-05-26 3:16 ` [PATCH 2/2] backlight: rt4831: Add the property parsing " cy_huang
2022-05-26 10:05 ` Daniel Thompson
2022-05-27 2:24 ` ChiYuan Huang
2022-05-27 10:56 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602135604.GA2194286-robh@kernel.org \
--to=robh@kernel.org \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lucas_tsai@richtek.com \
--cc=pavel@ucw.cz \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).