From: Rob Herring <robh@kernel.org>
To: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
Cc: ulf.hansson@linaro.org, krzysztof.kozlowski+dt@linaro.org,
bhupesh.sharma@linaro.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rampraka@quicinc.com, quic_pragalla@quicinc.com,
quic_sartgarg@quicinc.com, quic_nitirawa@quicinc.com,
quic_sayalil@quicinc.com
Subject: Re: [PATCH V5] dt-bindings: mmc: sdhci-msm: Add gcc resets strings
Date: Thu, 2 Jun 2022 09:34:05 -0500 [thread overview]
Message-ID: <20220602143405.GA2261501-robh@kernel.org> (raw)
In-Reply-To: <1654170291-29910-1-git-send-email-quic_c_sbhanu@quicinc.com>
On Thu, Jun 02, 2022 at 05:14:51PM +0530, Shaik Sajida Bhanu wrote:
> Add gcc hardware reset supported strings for qcom-sdhci controller
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Changes since V4:
> - Updated Dt bindings changes YAML format as suggested by
> Ulf Hansson.
>
> Changes since V3:
> - Removed reset-names from DT bindings as suggested by
> Stephen Boyd.
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index e423633..5548c35 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -121,6 +121,9 @@ properties:
> description: A phandle to sdhci power domain node
> maxItems: 1
>
> + resets:
> + description: Phandle and reset specifier for the device's reset.
Don't need generic descriptions for common properties. What you do need
is how many entries and what each entry is if more than one.
Rob
next prev parent reply other threads:[~2022-06-02 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:44 [PATCH V5] dt-bindings: mmc: sdhci-msm: Add gcc resets strings Shaik Sajida Bhanu
2022-06-02 14:34 ` Rob Herring [this message]
2022-06-07 10:15 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602143405.GA2261501-robh@kernel.org \
--to=robh@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_c_sbhanu@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).