From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: robh+dt@kernel.org, swboyd@chromium.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 02/10] iio: sx9324: Fix register field spelling
Date: Sat, 4 Jun 2022 17:19:58 +0100 [thread overview]
Message-ID: <20220604171958.28bcd451@jic23-huawei> (raw)
In-Reply-To: <20220429220144.1476049-3-gwendal@chromium.org>
On Fri, 29 Apr 2022 15:01:36 -0700
Gwendal Grignou <gwendal@chromium.org> wrote:
> Field for PROX_CTRL4 should contain PROX_CTRL4.
>
> Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support")
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Applied
> ---
> No Changes in v5.
> Changes since v3:
> - Added Review tags.
>
> Changes since v2:
> - no changes
>
> Changes since v1:
> - Add Fixes keyword in commit message.
>
> drivers/iio/proximity/sx9324.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c
> index 378c2a17bae6e..a7d9a53692a6d 100644
> --- a/drivers/iio/proximity/sx9324.c
> +++ b/drivers/iio/proximity/sx9324.c
> @@ -90,7 +90,7 @@
> #define SX9324_REG_PROX_CTRL4_AVGNEGFILT_MASK GENMASK(5, 3)
> #define SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 0x08
> #define SX9324_REG_PROX_CTRL4_AVGPOSFILT_MASK GENMASK(2, 0)
> -#define SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 0x04
> +#define SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 0x04
> #define SX9324_REG_PROX_CTRL5 0x35
> #define SX9324_REG_PROX_CTRL5_HYST_MASK GENMASK(5, 4)
> #define SX9324_REG_PROX_CTRL5_CLOSE_DEBOUNCE_MASK GENMASK(3, 2)
> @@ -794,7 +794,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = {
> { SX9324_REG_PROX_CTRL3, SX9324_REG_PROX_CTRL3_AVGDEB_2SAMPLES |
> SX9324_REG_PROX_CTRL3_AVGPOS_THRESH_16K },
> { SX9324_REG_PROX_CTRL4, SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 |
> - SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 },
> + SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 },
> { SX9324_REG_PROX_CTRL5, 0x00 },
> { SX9324_REG_PROX_CTRL6, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 },
> { SX9324_REG_PROX_CTRL7, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 },
next prev parent reply other threads:[~2022-06-04 16:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 22:01 [PATCH v4 00/10] iio: sx9324/9360: Add settings for precharge, gain and internal resistor Gwendal Grignou
2022-04-29 22:01 ` [PATCH v5 01/10] iio: sx9324: Fix default precharge internal resistance register Gwendal Grignou
2022-04-29 22:01 ` [PATCH v5 02/10] iio: sx9324: Fix register field spelling Gwendal Grignou
2022-06-04 16:19 ` Jonathan Cameron [this message]
2022-04-29 22:01 ` [PATCH v5 03/10] dt-bindings: iio: sx9324: Add precharge resistor setting Gwendal Grignou
2022-06-04 16:20 ` Jonathan Cameron
2022-04-29 22:01 ` [PATCH v5 04/10] iio: sx9324: Add precharge internal resistance setting Gwendal Grignou
2022-06-04 16:21 ` Jonathan Cameron
2022-04-29 22:01 ` [PATCH v5 05/10] dt-bindings: iio: sx9324: Add internal compensation resistor setting Gwendal Grignou
2022-06-04 16:22 ` Jonathan Cameron
2022-04-29 22:01 ` [PATCH v5 06/10] iio: sx9324: Add Setting for internal compensation resistor Gwendal Grignou
2022-04-29 22:01 ` [PATCH v5 07/10] dt-bindings: iio: sx9324: Add input analog gain Gwendal Grignou
2022-05-01 17:17 ` Jonathan Cameron
2022-05-10 5:48 ` Gwendal Grignou
2022-06-04 16:23 ` Jonathan Cameron
2022-05-03 18:02 ` Rob Herring
2022-05-03 19:10 ` Stephen Boyd
2022-04-29 22:01 ` [PATCH v5 08/10] iio: sx9324: Add Setting for internal " Gwendal Grignou
2022-05-03 19:12 ` Stephen Boyd
2022-06-04 16:25 ` Jonathan Cameron
2022-04-29 22:01 ` [PATCH v5 09/10] dt-bindings: iio: sx9360: Add precharge resistor setting Gwendal Grignou
2022-05-03 18:03 ` Rob Herring
2022-06-04 16:25 ` Jonathan Cameron
2022-04-29 22:01 ` [PATCH v5 10/10] iio: sx9360: Add pre-charge " Gwendal Grignou
2022-06-04 16:26 ` Jonathan Cameron
2022-05-01 17:20 ` [PATCH v4 00/10] iio: sx9324/9360: Add settings for precharge, gain and internal resistor Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220604171958.28bcd451@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).