* [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
@ 2022-05-30 13:55 Fabien Parent
2022-06-05 15:10 ` Rob Herring
0 siblings, 1 reply; 7+ messages in thread
From: Fabien Parent @ 2022-05-30 13:55 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger
Cc: Fabien Parent, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
Add pwrap binding documentation for
Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
index 0581dbda4828..00b94601071e 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
+++ b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
@@ -29,6 +29,7 @@ Required properties in pwrap device node.
"mediatek,mt8183-pwrap" for MT8183 SoCs
"mediatek,mt8186-pwrap" for MT8186 SoCs
"mediatek,mt8195-pwrap" for MT8195 SoCs
+ "mediatek,mt8365-pwrap" for MT8365 SoCs
"mediatek,mt8516-pwrap" for MT8516 SoCs
- interrupts: IRQ for pwrap in SOC
- reg-names: "pwrap" is required; "pwrap-bridge" is optional.
@@ -38,6 +39,8 @@ Required properties in pwrap device node.
- clock-names: Must include the following entries:
"spi": SPI bus clock
"wrap": Main module clock
+ "sys": System module clock (for MT8365 SoC)
+ "tmr": Timer module clock (for MT8365 SoC)
- clocks: Must contain an entry for each entry in clock-names.
Optional properities:
--
2.36.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-05-30 13:55 [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings Fabien Parent
@ 2022-06-05 15:10 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-06-05 15:10 UTC (permalink / raw)
To: Fabien Parent
Cc: devicetree, Krzysztof Kozlowski, Rob Herring, Matthias Brugger,
linux-kernel, linux-mediatek, linux-arm-kernel
On Mon, 30 May 2022 15:55:20 +0200, Fabien Parent wrote:
> Add pwrap binding documentation for
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
> Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-10-20 13:07 [PATCH 0/3] mediatek: pwrap: Add mt8365 pwrap support fchiby
@ 2022-10-20 13:07 ` fchiby
0 siblings, 0 replies; 7+ messages in thread
From: fchiby @ 2022-10-20 13:07 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Johnson Wang, Zhiyong.Tao
Cc: Fabien Parent, Rob Herring, Tinghan Shen, Sen Chu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
From: Fabien Parent <fparent@baylibre.com>
Add pwrap binding documentation for
Signed-off-by: Fabien Parent <fparent@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
index d24e2bc444be..8424b93c432e 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
+++ b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
@@ -30,6 +30,7 @@ Required properties in pwrap device node.
"mediatek,mt8186-pwrap" for MT8186 SoCs
"mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap" for MT8188 SoCs
"mediatek,mt8195-pwrap" for MT8195 SoCs
+ "mediatek,mt8365-pwrap" for MT8365 SoCs
"mediatek,mt8516-pwrap" for MT8516 SoCs
- interrupts: IRQ for pwrap in SOC
- reg-names: "pwrap" is required; "pwrap-bridge" is optional.
@@ -39,6 +40,8 @@ Required properties in pwrap device node.
- clock-names: Must include the following entries:
"spi": SPI bus clock
"wrap": Main module clock
+ "sys": System module clock (for MT8365 SoC)
+ "tmr": Timer module clock (for MT8365 SoC)
- clocks: Must contain an entry for each entry in clock-names.
Optional properities:
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-10-20 13:09 [PATCH 0/3] mediatek: pwrap: Add mt8365 pwrap support fchiby
@ 2022-10-20 13:09 ` fchiby
2022-10-20 16:19 ` Krzysztof Kozlowski
2022-10-20 16:19 ` Krzysztof Kozlowski
0 siblings, 2 replies; 7+ messages in thread
From: fchiby @ 2022-10-20 13:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Johnson Wang, Zhiyong.Tao
Cc: Fabien Parent, Rob Herring, Tinghan Shen, Sen Chu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
From: Fabien Parent <fparent@baylibre.com>
Add pwrap binding documentation for
Signed-off-by: Fabien Parent <fparent@baylibre.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
index d24e2bc444be..8424b93c432e 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
+++ b/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt
@@ -30,6 +30,7 @@ Required properties in pwrap device node.
"mediatek,mt8186-pwrap" for MT8186 SoCs
"mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap" for MT8188 SoCs
"mediatek,mt8195-pwrap" for MT8195 SoCs
+ "mediatek,mt8365-pwrap" for MT8365 SoCs
"mediatek,mt8516-pwrap" for MT8516 SoCs
- interrupts: IRQ for pwrap in SOC
- reg-names: "pwrap" is required; "pwrap-bridge" is optional.
@@ -39,6 +40,8 @@ Required properties in pwrap device node.
- clock-names: Must include the following entries:
"spi": SPI bus clock
"wrap": Main module clock
+ "sys": System module clock (for MT8365 SoC)
+ "tmr": Timer module clock (for MT8365 SoC)
- clocks: Must contain an entry for each entry in clock-names.
Optional properities:
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-10-20 13:09 ` [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings fchiby
@ 2022-10-20 16:19 ` Krzysztof Kozlowski
2022-10-24 13:24 ` Fadwa Chiby
2022-10-20 16:19 ` Krzysztof Kozlowski
1 sibling, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-20 16:19 UTC (permalink / raw)
To: fchiby, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Johnson Wang, Zhiyong.Tao
Cc: Fabien Parent, Rob Herring, Tinghan Shen, Sen Chu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add pwrap binding documentation for
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>
This is not exactly v1 then. Please use patch versioning and add
changelog (to cover letter or to individual patches).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-10-20 13:09 ` [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings fchiby
2022-10-20 16:19 ` Krzysztof Kozlowski
@ 2022-10-20 16:19 ` Krzysztof Kozlowski
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-20 16:19 UTC (permalink / raw)
To: fchiby, Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Johnson Wang, Zhiyong.Tao
Cc: Fabien Parent, Rob Herring, Tinghan Shen, Sen Chu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> From: Fabien Parent <fparent@baylibre.com>
>
> Add pwrap binding documentation for
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Acked-by: Rob Herring <robh@kernel.org>
Ah, and one more issue - your SoB is missing in all patches.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings
2022-10-20 16:19 ` Krzysztof Kozlowski
@ 2022-10-24 13:24 ` Fadwa Chiby
0 siblings, 0 replies; 7+ messages in thread
From: Fadwa Chiby @ 2022-10-24 13:24 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Matthias Brugger,
AngeloGioacchino Del Regno, Johnson Wang, Zhiyong.Tao,
Fabien Parent, Rob Herring, Tinghan Shen, Sen Chu, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
Le jeu. 20 oct. 2022 à 18:19, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> a écrit :
>
> On 20/10/2022 09:09, fchiby@baylibre.com wrote:
> > From: Fabien Parent <fparent@baylibre.com>
> >
> > Add pwrap binding documentation for
> >
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > Acked-by: Rob Herring <robh@kernel.org>
>
> This is not exactly v1 then. Please use patch versioning and add
> changelog (to cover letter or to individual patches).
>
> Best regards,
> Krzysztof
>
Hello,
Thanks for your feedback. Everything is fixed in a new series.
Regards,
Fadwa CHIBY
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-24 16:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-30 13:55 [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings Fabien Parent
2022-06-05 15:10 ` Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2022-10-20 13:07 [PATCH 0/3] mediatek: pwrap: Add mt8365 pwrap support fchiby
2022-10-20 13:07 ` [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings fchiby
2022-10-20 13:09 [PATCH 0/3] mediatek: pwrap: Add mt8365 pwrap support fchiby
2022-10-20 13:09 ` [PATCH 1/3] dt-bindings: soc: mediatek: pwrap: add MT8365 SoC bindings fchiby
2022-10-20 16:19 ` Krzysztof Kozlowski
2022-10-24 13:24 ` Fadwa Chiby
2022-10-20 16:19 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).