From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4225C433EF for ; Mon, 6 Jun 2022 15:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241337AbiFFP4R (ORCPT ); Mon, 6 Jun 2022 11:56:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241329AbiFFP4R (ORCPT ); Mon, 6 Jun 2022 11:56:17 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 115E22390A8 for ; Mon, 6 Jun 2022 08:56:16 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id u2so13050650pfc.2 for ; Mon, 06 Jun 2022 08:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HqBVIaUxLFLt31mKtTfmzpaubYdTK4hqFLvxcHrajGI=; b=am390ormAxfQBcDhad1xqfGuaIZhU7gIyzfW/9uyFo3xvj2W19MLPe42Uxbqs6q937 WLzpSDXD9fxuZqRO2SmIDl3w0Cwe8amaEnwFcOEnLReu0b1+W18AgTvCA3yyiCdFMxk6 H5tx+lg9wX6uKyHJz1DtdAqa66eSr/6WvFO7lJqSxj//PJqxpBDwR+YevD8yqIlJK/Mx ZcqC+/cRvVqub4Ggt/l/3P3QWCr+b4CkTekrLG3K45HTTZrJZt5U6kt8kyraYtRvIsD7 PJDLyj70pL7QYVclaTA8PuCd/+cfqq/wzBL80/7UiaDyOElSklvX7PxNJIrVlxh41xi0 QGkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HqBVIaUxLFLt31mKtTfmzpaubYdTK4hqFLvxcHrajGI=; b=oDwtMfMvrLdfnWfUZogk0VsG6L3CUh/XW+Ufid930WRrzCZLOMyRrgF5+D5gE6RXSq dh9zdKcmkNk/h1ZGYPQhtT6uhaK921j6uKplg+U6mTLVHcTuPYUJM4FeQseMi7qyDD7n 1W0zDHKm7JQTuEopGrEDDqoE5TaKSh0+QPEG31gQzLY03rBGi1atElIeCRuCKz/dnWyf G/7z4imVQsLt1mkvDiEOx14lLX9Y+6boqMuUxTj3iRrrtYtz1OOh/7f5ftATOiT/q8k/ P+hEe4E6IVBudbCd5EHQqbPmHCmWIb3NnoJFNNv1qEPtf9H9fL1wIIgY5Qo4Pi70tRsS i7HA== X-Gm-Message-State: AOAM5305LThMPYzblUgf2ZaamGCNiQHlwYw2jVlFEPSZtm2yfvjY5qlK USXd9cQbYjcxHkNJvHfVWokfsg== X-Google-Smtp-Source: ABdhPJze2KfB5rZ725/eBE9Lz2Jfsvti1kHUrazKUB2pLSiIxcf6vV6SLvqVc/BjbYmcF7nR2jTnuA== X-Received: by 2002:a63:741:0:b0:3fc:6b3c:f9dd with SMTP id 62-20020a630741000000b003fc6b3cf9ddmr21224601pgh.351.1654530975570; Mon, 06 Jun 2022 08:56:15 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id i6-20020a17090ad34600b001cd4989ff41sm10370086pjx.8.2022.06.06.08.56.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 08:56:14 -0700 (PDT) Date: Mon, 6 Jun 2022 09:56:12 -0600 From: Mathieu Poirier To: Puranjay Mohan Cc: linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, krzysztof.kozlowski+dt@linaro.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, robh@kernel.org Subject: Re: [PATCH v4 0/6] Introduce PRU remoteproc consumer API Message-ID: <20220606155612.GA809345@p14s> References: <20220603121520.13730-1-p-mohan@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220603121520.13730-1-p-mohan@ti.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org I have started to review this set, comments will come over the next few days. I will clearly inform you when I am done reviewing. Thanks, Mathieu On Fri, Jun 03, 2022 at 05:45:14PM +0530, Puranjay Mohan wrote: > This is the v4 of the patch series [1]. The v3 had some comments > on the DT patch that have been addressed here. The 6th patch in this > series was missed in the previous versions, so, it has been added now. > > I have posted two more patch series that depend on this series, one to > the soc tree and another to the networking tree. I had sent all the 3 > series, including this one as RFC [2] to get comments and to explain the > dependencies. > > The Programmable Real-Time Unit and Industrial Communication Subsystem > (PRU-ICSS or simply PRUSS) on various TI SoCs consists of dual 32-bit > RISC cores (Programmable Real-Time Units, or PRUs) for program execution. > > There are 3 foundation components for PRUSS subsystem: the PRUSS platform > driver, the PRUSS INTC driver and the PRUSS remoteproc driver. All were > already merged and can be found under: > 1) drivers/soc/ti/pruss.c > Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml > 2) drivers/irqchip/irq-pruss-intc.c > Documentation/devicetree/bindings/interrupt-controller/ti,pruss-intc.yaml > 3) drivers/remoteproc/pru_rproc.c > Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml > > The programmable nature of the PRUs provide flexibility to implement custom > peripheral interfaces, fast real-time responses, or specialized data handling. > Example of a PRU consumer drivers will be: > - Software UART over PRUSS > - PRU-ICSS Ethernet EMAC > > In order to make usage of common PRU resources and allow the consumer drivers to > configure the PRU hardware for specific usage the PRU API is introduced. > > [1] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220418104118.12878-1-p-mohan@ti.com/ > [2] https://patchwork.kernel.org/project/linux-remoteproc/cover/20220406094358.7895-1-p-mohan@ti.com/ > > Thanks and Regards, > Puranjay Mohan > > Roger Quadros (1): > remoteproc: pru: Add pru_rproc_set_ctable() function > > Suman Anna (2): > dt-bindings: remoteproc: Add PRU consumer bindings > remoteproc: pru: Make sysfs entries read-only for PRU client driven > boots > > Tero Kristo (3): > remoteproc: pru: Add APIs to get and put the PRU cores > remoteproc: pru: Configure firmware based on client setup > remoteproc: pru: add support for configuring GPMUX based on client > setup > > .../bindings/remoteproc/ti,pru-consumer.yaml | 69 +++++ > drivers/remoteproc/pru_rproc.c | 254 +++++++++++++++++- > include/linux/pruss.h | 78 ++++++ > 3 files changed, 396 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > create mode 100644 include/linux/pruss.h > > -- > 2.17.1 >