From: Guenter Roeck <linux@roeck-us.net>
To: Rob Herring <robh@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Camel Guo <camel.guo@axis.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: ti,tmp401: Drop 'items' from 'ti,n-factor' property
Date: Tue, 7 Jun 2022 05:42:36 -0700 [thread overview]
Message-ID: <20220607124236.GA1786135@roeck-us.net> (raw)
In-Reply-To: <20220606212223.1360395-1-robh@kernel.org>
On Mon, Jun 06, 2022 at 04:22:22PM -0500, Rob Herring wrote:
> 'ti,n-factor' is a scalar type, so 'items' should not be used as that is
> for arrays/matrix.
>
> A pending meta-schema change will catch future cases.
>
> Fixes: bd90c5b93950 ("dt-bindings: hwmon: Add TMP401, TMP411 and TMP43x")
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied.
Thanks,
Guenter
> ---
> Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> index fe0ac08faa1a..0e8ddf0ad789 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp401.yaml
> @@ -40,9 +40,8 @@ properties:
> value to be used for converting remote channel measurements to
> temperature.
> $ref: /schemas/types.yaml#/definitions/int32
> - items:
> - minimum: -128
> - maximum: 127
> + minimum: -128
> + maximum: 127
>
> ti,beta-compensation:
> description:
prev parent reply other threads:[~2022-06-07 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 21:22 [PATCH] dt-bindings: hwmon: ti,tmp401: Drop 'items' from 'ti,n-factor' property Rob Herring
2022-06-07 11:04 ` Krzysztof Kozlowski
2022-06-07 12:42 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607124236.GA1786135@roeck-us.net \
--to=linux@roeck-us.net \
--cc=camel.guo@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).