From: Quentin Schulz <foss+kernel@0leil.net>
To: unlisted-recipients:; (no To-header on input)
Cc: shawnx.tu@intel.com, mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
foss+kernel@0leil.net,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v6 3/4] media: i2c: ov5675: parse and register V4L2 device tree properties
Date: Tue, 7 Jun 2022 17:33:34 +0200 [thread overview]
Message-ID: <20220607153335.875956-3-foss+kernel@0leil.net> (raw)
In-Reply-To: <20220607153335.875956-1-foss+kernel@0leil.net>
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Parse V4L2 device tree properties and register controls for them.
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---
v3:
- reverse-xmas-tree-ordered in ov5675_init_controls,
drivers/media/i2c/ov5675.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c
index e671fb24ebb4..80840ad7bbb0 100644
--- a/drivers/media/i2c/ov5675.c
+++ b/drivers/media/i2c/ov5675.c
@@ -779,12 +779,14 @@ static const struct v4l2_ctrl_ops ov5675_ctrl_ops = {
static int ov5675_init_controls(struct ov5675 *ov5675)
{
+ struct i2c_client *client = v4l2_get_subdevdata(&ov5675->sd);
+ struct v4l2_fwnode_device_properties props;
struct v4l2_ctrl_handler *ctrl_hdlr;
s64 exposure_max, h_blank;
int ret;
ctrl_hdlr = &ov5675->ctrl_handler;
- ret = v4l2_ctrl_handler_init(ctrl_hdlr, 8);
+ ret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);
if (ret)
return ret;
@@ -838,9 +840,23 @@ static int ov5675_init_controls(struct ov5675 *ov5675)
if (ctrl_hdlr->error)
return ctrl_hdlr->error;
+ ret = v4l2_fwnode_device_parse(&client->dev, &props);
+ if (ret)
+ goto error;
+
+ ret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &ov5675_ctrl_ops,
+ &props);
+ if (ret)
+ goto error;
+
ov5675->sd.ctrl_handler = ctrl_hdlr;
return 0;
+
+error:
+ v4l2_ctrl_handler_free(ctrl_hdlr);
+
+ return ret;
}
static void ov5675_update_pad_format(const struct ov5675_mode *mode,
--
2.36.1
next prev parent reply other threads:[~2022-06-07 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 15:33 [PATCH v6 1/4] media: dt-bindings: ov5675: document YAML binding Quentin Schulz
2022-06-07 15:33 ` [PATCH v6 2/4] media: ov5675: add device-tree support and support runtime PM Quentin Schulz
2022-06-07 15:33 ` Quentin Schulz [this message]
2022-06-07 15:33 ` [PATCH v6 4/4] media: i2c: ov5675: add .get_selection support Quentin Schulz
2022-06-07 16:51 ` Jacopo Mondi
2022-06-07 22:04 ` Tommaso Merciai
2022-06-08 6:42 ` Jacopo Mondi
2022-06-08 8:03 ` Tommaso Merciai
2022-06-08 13:05 ` Quentin Schulz
2022-06-09 9:17 ` [PATCH v6 4/4] media: i2c: ov5675: add .get_selection supporty Tommaso Merciai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220607153335.875956-3-foss+kernel@0leil.net \
--to=foss+kernel@0leil.net \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh+dt@kernel.org \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).