From: kernel test robot <lkp@intel.com>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz,
tiwai@suse.com, srinivas.kandagatla@linaro.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, vkoul@kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Subject: Re: [PATCH 2/2] ASoC: qcom: soundwire: Add software clock gating requirement check
Date: Wed, 8 Jun 2022 10:29:24 +0800 [thread overview]
Message-ID: <202206081054.vVkYPkJt-lkp@intel.com> (raw)
In-Reply-To: <1654605334-32030-3-git-send-email-quic_srivasam@quicinc.com>
Hi Srinivasa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next]
[cannot apply to linus/master v5.19-rc1 next-20220607]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Srinivasa-Rao-Mandadapu/Add-software-clock-gating-requirement-check/20220607-203739
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: i386-randconfig-a006 (https://download.01.org/0day-ci/archive/20220608/202206081054.vVkYPkJt-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/86aa15d36b06f7b73938f00f9ad99eff75a94a94
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Srinivasa-Rao-Mandadapu/Add-software-clock-gating-requirement-check/20220607-203739
git checkout 86aa15d36b06f7b73938f00f9ad99eff75a94a94
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/soundwire/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/soundwire/qcom.c:668:6: error: use of undeclared identifier 'data'
if (data->sw_clk_gate_required)
^
drivers/soundwire/qcom.c:1509:7: error: use of undeclared identifier 'data'
if (data->sw_clk_gate_required)
^
2 errors generated.
vim +/data +668 drivers/soundwire/qcom.c
659
660 static int qcom_swrm_init(struct qcom_swrm_ctrl *ctrl)
661 {
662 u32 val;
663
664 /* Clear Rows and Cols */
665 val = FIELD_PREP(SWRM_MCP_FRAME_CTRL_BANK_ROW_CTRL_BMSK, ctrl->rows_index);
666 val |= FIELD_PREP(SWRM_MCP_FRAME_CTRL_BANK_COL_CTRL_BMSK, ctrl->cols_index);
667
> 668 if (data->sw_clk_gate_required)
669 reset_control_reset(ctrl->audio_cgcr);
670
671 ctrl->reg_write(ctrl, SWRM_MCP_FRAME_CTRL_BANK_ADDR(0), val);
672
673 /* Enable Auto enumeration */
674 ctrl->reg_write(ctrl, SWRM_ENUMERATOR_CFG_ADDR, 1);
675
676 ctrl->intr_mask = SWRM_INTERRUPT_STATUS_RMSK;
677 /* Mask soundwire interrupts */
678 ctrl->reg_write(ctrl, SWRM_INTERRUPT_MASK_ADDR,
679 SWRM_INTERRUPT_STATUS_RMSK);
680
681 /* Configure No pings */
682 ctrl->reg_read(ctrl, SWRM_MCP_CFG_ADDR, &val);
683 u32p_replace_bits(&val, SWRM_DEF_CMD_NO_PINGS, SWRM_MCP_CFG_MAX_NUM_OF_CMD_NO_PINGS_BMSK);
684 ctrl->reg_write(ctrl, SWRM_MCP_CFG_ADDR, val);
685
686 ctrl->reg_write(ctrl, SWRM_MCP_BUS_CTRL, SWRM_MCP_BUS_CLK_START);
687 /* Configure number of retries of a read/write cmd */
688 if (ctrl->version > 0x01050001) {
689 /* Only for versions >= 1.5.1 */
690 ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
691 SWRM_RD_WR_CMD_RETRIES |
692 SWRM_CONTINUE_EXEC_ON_CMD_IGNORE);
693 } else {
694 ctrl->reg_write(ctrl, SWRM_CMD_FIFO_CFG_ADDR,
695 SWRM_RD_WR_CMD_RETRIES);
696 }
697
698 /* Set IRQ to PULSE */
699 ctrl->reg_write(ctrl, SWRM_COMP_CFG_ADDR,
700 SWRM_COMP_CFG_IRQ_LEVEL_OR_PULSE_MSK |
701 SWRM_COMP_CFG_ENABLE_MSK);
702
703 /* enable CPU IRQs */
704 if (ctrl->mmio) {
705 ctrl->reg_write(ctrl, SWRM_INTERRUPT_CPU_EN,
706 SWRM_INTERRUPT_STATUS_RMSK);
707 }
708 ctrl->slave_status = 0;
709 ctrl->reg_read(ctrl, SWRM_COMP_PARAMS, &val);
710 ctrl->rd_fifo_depth = FIELD_GET(SWRM_COMP_PARAMS_RD_FIFO_DEPTH, val);
711 ctrl->wr_fifo_depth = FIELD_GET(SWRM_COMP_PARAMS_WR_FIFO_DEPTH, val);
712
713 return 0;
714 }
715
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-06-08 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 12:35 [PATCH 0/2] Add software clock gating requirement check Srinivasa Rao Mandadapu
2022-06-07 12:35 ` [PATCH 1/2] soundwire: qcom: Add flag for software clock gating check Srinivasa Rao Mandadapu
2022-06-07 12:35 ` [PATCH 2/2] ASoC: qcom: soundwire: Add software clock gating requirement check Srinivasa Rao Mandadapu
2022-06-08 2:29 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206081054.vVkYPkJt-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).