From: kernel test robot <lkp@intel.com>
To: Shreeya Patel <shreeya.patel@collabora.com>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
Zhigang.Shi@liteon.com, krisman@collabora.com
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
alvaro.soliverez@collabora.com, andy.shevchenko@gmail.com,
digetx@gmail.com, Shreeya Patel <shreeya.patel@collabora.com>
Subject: Re: [PATCH v5 2/2] iio: light: Add support for ltrf216a sensor
Date: Thu, 9 Jun 2022 10:24:51 +0800 [thread overview]
Message-ID: <202206090943.Zvfv6OBd-lkp@intel.com> (raw)
In-Reply-To: <20220608113553.32083-3-shreeya.patel@collabora.com>
Hi Shreeya,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on v5.19-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Shreeya-Patel/Add-LTRF216A-Driver/20220608-194016
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220609/202206090943.Zvfv6OBd-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project b92436efcb7813fc481b30f2593a4907568d917a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4809a7f42af19c3da77457e1aaf37ddd171fa779
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Shreeya-Patel/Add-LTRF216A-Driver/20220608-194016
git checkout 4809a7f42af19c3da77457e1aaf37ddd171fa779
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iio/adc/ drivers/iio/light/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/iio/light/ltrf216a.c:193:5: warning: no previous prototype for function 'ltrf216a_check_for_data' [-Wmissing-prototypes]
int ltrf216a_check_for_data(struct i2c_client *client)
^
drivers/iio/light/ltrf216a.c:193:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int ltrf216a_check_for_data(struct i2c_client *client)
^
static
1 warning generated.
vim +/ltrf216a_check_for_data +193 drivers/iio/light/ltrf216a.c
192
> 193 int ltrf216a_check_for_data(struct i2c_client *client)
194 {
195 int ret;
196
197 ret = i2c_smbus_read_byte_data(client, LTRF216A_MAIN_STATUS);
198 if (ret < 0) {
199 dev_err(&client->dev, "Failed to read LTRF216A_MAIN_STATUS register: %d\n", ret);
200 return ret;
201 }
202
203 return ret;
204 }
205
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-06-09 2:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 11:35 [PATCH v5 0/2] Add LTRF216A Driver Shreeya Patel
2022-06-08 11:35 ` [PATCH v5 1/2] dt-bindings: Document ltrf216a light sensor bindings Shreeya Patel
2022-06-08 13:45 ` Rob Herring
2022-06-08 11:35 ` [PATCH v5 2/2] iio: light: Add support for ltrf216a sensor Shreeya Patel
2022-06-08 16:16 ` Andy Shevchenko
2022-06-13 12:52 ` Shreeya Patel
2022-06-09 2:24 ` kernel test robot [this message]
2022-06-09 2:24 ` kernel test robot
2022-06-14 11:51 ` [PATCH v5 0/2] Add LTRF216A Driver Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206090943.Zvfv6OBd-lkp@intel.com \
--to=lkp@intel.com \
--cc=Zhigang.Shi@liteon.com \
--cc=alvaro.soliverez@collabora.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jic23@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).