* [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node
@ 2022-05-10 5:46 Alexander Stein
2022-05-10 11:26 ` Fabio Estevam
2022-06-10 8:29 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2022-05-10 5:46 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, devicetree, linux-arm-kernel, Jun Li
Move the power domain to its actual user. This keeps the power domain
enabled even when the USB host is runtime suspended. This is necessary
to detect any downstream events, like device attach.
Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
Suggested-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This patch superseeds the initial patch from [1].
[1] https://lore.kernel.org/linux-arm-kernel/5566202.DvuYhMxLoT@steina-w/T/
Changes in v2:
* Added Fixes tag
arch/arm/boot/dts/imx7s.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 008e3da460f1..039eed79d2e7 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -120,6 +120,7 @@ usbphynop3: usbphynop3 {
compatible = "usb-nop-xceiv";
clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
clock-names = "main_clk";
+ power-domains = <&pgc_hsic_phy>;
#phy-cells = <0>;
};
@@ -1153,7 +1154,6 @@ usbh: usb@30b30000 {
compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
reg = <0x30b30000 0x200>;
interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
- power-domains = <&pgc_hsic_phy>;
clocks = <&clks IMX7D_USB_CTRL_CLK>;
fsl,usbphy = <&usbphynop3>;
fsl,usbmisc = <&usbmisc3 0>;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node
2022-05-10 5:46 [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node Alexander Stein
@ 2022-05-10 11:26 ` Fabio Estevam
2022-06-10 8:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2022-05-10 11:26 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Shawn Guo, Sascha Hauer,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, Jun Li
On Tue, May 10, 2022 at 2:46 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Move the power domain to its actual user. This keeps the power domain
> enabled even when the USB host is runtime suspended. This is necessary
> to detect any downstream events, like device attach.
>
> Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
> Suggested-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node
2022-05-10 5:46 [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node Alexander Stein
2022-05-10 11:26 ` Fabio Estevam
@ 2022-06-10 8:29 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2022-06-10 8:29 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Sascha Hauer, Fabio Estevam,
devicetree, linux-arm-kernel, Jun Li
On Tue, May 10, 2022 at 07:46:12AM +0200, Alexander Stein wrote:
> Move the power domain to its actual user. This keeps the power domain
> enabled even when the USB host is runtime suspended. This is necessary
> to detect any downstream events, like device attach.
>
> Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
> Suggested-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-10 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-10 5:46 [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node Alexander Stein
2022-05-10 11:26 ` Fabio Estevam
2022-06-10 8:29 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).