[PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node

[PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node

[Alexander Stein]

Move the power domain to its actual user. This keeps the power domain
enabled even when the USB host is runtime suspended. This is necessary
to detect any downstream events, like device attach.

Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
Suggested-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
This patch superseeds the initial patch from [1].

[1] https://lore.kernel.org/linux-arm-kernel/5566202.DvuYhMxLoT@steina-w/T/

Changes in v2:
* Added Fixes tag

 arch/arm/boot/dts/imx7s.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 008e3da460f1..039eed79d2e7 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -120,6 +120,7 @@ usbphynop3: usbphynop3 {
 		compatible = "usb-nop-xceiv";
 		clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
 		clock-names = "main_clk";
+		power-domains = <&pgc_hsic_phy>;
 		#phy-cells = <0>;
 	};
 
@@ -1153,7 +1154,6 @@ usbh: usb@30b30000 {
 				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
 				reg = <0x30b30000 0x200>;
 				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
-				power-domains = <&pgc_hsic_phy>;
 				clocks = <&clks IMX7D_USB_CTRL_CLK>;
 				fsl,usbphy = <&usbphynop3>;
 				fsl,usbmisc = <&usbmisc3 0>;
-- 
2.25.1

Re: [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node

[Fabio Estevam]

On Tue, May 10, 2022 at 2:46 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Move the power domain to its actual user. This keeps the power domain
> enabled even when the USB host is runtime suspended. This is necessary
> to detect any downstream events, like device attach.
>
> Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
> Suggested-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Re: [PATCH v2 1/1] ARM: dts: imx7: Move hsic_phy power domain to HSIC PHY node

[Shawn Guo]

On Tue, May 10, 2022 at 07:46:12AM +0200, Alexander Stein wrote:
> Move the power domain to its actual user. This keeps the power domain
> enabled even when the USB host is runtime suspended. This is necessary
> to detect any downstream events, like device attach.
> 
> Fixes: 02f8eb40ef7b ("ARM: dts: imx7s: Add power domain for imx7d HSIC")
> Suggested-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!