From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 407A7C43334 for ; Sat, 11 Jun 2022 19:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231453AbiFKT6L (ORCPT ); Sat, 11 Jun 2022 15:58:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231444AbiFKT6I (ORCPT ); Sat, 11 Jun 2022 15:58:08 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFAB6369C8 for ; Sat, 11 Jun 2022 12:58:01 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id b7so2399076ljr.6 for ; Sat, 11 Jun 2022 12:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oxQkwpPSC0y6PSBnoCHGL4044465zqiVx70IXoXpvOc=; b=BHkKobmasFZUBwncc9LygpAPBRmbKMJOq3yO/P8De5qhIRgAOZgUPRaJ+wFyzFAGaz NpSJYJLa/f5h4etHmJe5dy92Di1ZF1fWOdOrbckf67s7wpYN3gyQQThSEB2wMFfm4zX+ RP1z9RUvbI+CAcx2psfP5l0p4YU1p1NP4OkE4eswC9k3wz7wtA42nq4lbUk8NTVogHhl 3yYHIdzkHfRxZdt6mniJOHr3waqXHkZuMjGYiL3GAr9/uALlUqPQyTZDn4HTXwwd0Njd AlmxFA+Zw4BEM63KkHT2Tf/We3UUqYpNJnfx/rsrxq33Q2FR/gC8VtXl8lsRQZ8LfWx5 L2Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oxQkwpPSC0y6PSBnoCHGL4044465zqiVx70IXoXpvOc=; b=lRMZULCXQXxniAb4pdFpQ4Qw5c2JFoZ54nGOBiH9KcUJYkoVyO8Ps2khkDoQKnDawO HmEOzG1n2ejo6QABDtpznTjP/rONm6fc/RUwSBc4YvWsZVbvu50FMJSnw6CD34GLrYMC ILGnAPnCHdIM2yh/eGJL5Ofa5PsemJc0Zhr3lJ100dngBzfTxI6plHrEXAuE6eyf87pd 1LTbIX8I6ggdxzLIT0ieKk8gS7lYfg9o1sZj5oeG3JGT6BzPRZeZdl6aAohQcP36Ms7b 211dQ9hW2Rj95Wrz6aKxsld9cLEz1kae2PllZQm6nZ+d7xld9uYC09a4HelMPX1VUiZ6 nrLQ== X-Gm-Message-State: AOAM531G19Zt2a5JjPcAGwj6jfqPasLx7lnnTNAKXwYMEMLFVrcgYcov Be9gGUgisjEC3f3CaDGzjVINAg== X-Google-Smtp-Source: ABdhPJwcAibQ8M+9PY44AHNLQKkTKnNNepX/fDokdOIeO0ZAKvSmcH3oc9JG/OaBl8CiQrgcVHYE3Q== X-Received: by 2002:a2e:968a:0:b0:258:e311:ca01 with SMTP id q10-20020a2e968a000000b00258e311ca01mr6274999lji.337.1654977480161; Sat, 11 Jun 2022 12:58:00 -0700 (PDT) Received: from localhost.localdomain (78-107-206-185.broadband.corbina.ru. [78.107.206.185]) by smtp.googlemail.com with ESMTPSA id v30-20020a056512049e00b00479526185a0sm364948lfq.118.2022.06.11.12.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jun 2022 12:57:59 -0700 (PDT) From: Andrey Konovalov To: bjorn.andersson@linaro.org, agross@kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, vinod.koul@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH] arm64: dts: qcom: qcs404: fix default pinctrl settings for blsp1_spi1 Date: Sat, 11 Jun 2022 22:57:13 +0300 Message-Id: <20220611195713.131597-1-andrey.konovalov@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The current settings refer to "blsp_spi1" function which isn't defined. For this reason an attempt to enable blsp1_spi1 interface results in the probe failure below: [ 3.492900] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table [ 3.502460] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table [ 3.517725] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table [ 3.532998] qcs404-pinctrl 1000000.pinctrl: invalid function blsp_spi1 in map table [ 3.548277] spi_qup: probe of 78b6000.spi failed with error -22 Fix this by making the functions used in qcs404.dtsi to match the contents of drivers/pinctrl/qcom/pinctrl-qcs404.c. Signed-off-by: Andrey Konovalov --- arch/arm64/boot/dts/qcom/qcs404.dtsi | 21 +++++++++++++++++++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi index d912166b7552..0d9e1f19aa67 100644 --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi @@ -669,8 +669,25 @@ blsp1_spi0_default: blsp1-spi0-default { }; blsp1_spi1_default: blsp1-spi1-default { - pins = "gpio22", "gpio23", "gpio24", "gpio25"; - function = "blsp_spi1"; + mosi { + pins = "gpio22"; + function = "blsp_spi_mosi_a1"; + }; + + miso { + pins = "gpio23"; + function = "blsp_spi_miso_a1"; + }; + + cs_n { + pins = "gpio24"; + function = "blsp_spi_cs_n_a1"; + }; + + clk { + pins = "gpio25"; + function = "blsp_spi_clk_a1"; + }; }; blsp1_spi2_default: blsp1-spi2-default { -- 2.25.1