From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F245CCA473 for ; Sun, 12 Jun 2022 08:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbiFLIoi (ORCPT ); Sun, 12 Jun 2022 04:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbiFLIoh (ORCPT ); Sun, 12 Jun 2022 04:44:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D747039179; Sun, 12 Jun 2022 01:44:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 353AA60BA8; Sun, 12 Jun 2022 08:44:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43799C34115; Sun, 12 Jun 2022 08:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655023474; bh=Iuf05oYjNVfmVviJ3nzqABfbmmEH9K1yfExt9eMTwpw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rS3+hLCYfRFUyaB1xTljZaF2xc0BscWD3kt9vZzqOWo6MNCUf6x8aQAd3aGfwpPvz 7d4eexx64qXwik87NVBpnme4dqZcwA843f7r+Py7Z3ilmablhaN6Ec6JRZKUEu0MBf M4FOF3j3QEFydrjOKwDp5lLTbDnRdCiBug+YTq+KKuUJPhYEWckcuvHRzMn3G9yyiy EC9i4m4YpDBEhLRa/kgDjvkjXEIf1KHl8fSnzW2O2gTJi11JyIJF3Wu7ttcf0KKIwh 3nNqunAcNiKZQxrRtZJu83Pva096Rf+4/CIpPDi5q3OiUHePMb0v9EpqFQ1+xKDfTw HHKpTVyeSv0hw== Date: Sun, 12 Jun 2022 09:53:33 +0100 From: Jonathan Cameron To: "Luca Weiss" Cc: "Markuss Broks" , , <~postmarketos/upstreaming@lists.sr.ht>, , "Konrad Dybcio" , "Marijn Suijten" , "AngeloGioacchino Del Regno" , "Song Qiang" , "Lars-Peter Clausen" , "Rob Herring" , "Krzysztof Kozlowski" , "Andy Gross" , "Bjorn Andersson" , "Liam Girdwood" , "Mark Brown" , , , Subject: Re: [PATCH 3/5] proximity: vl53l0x: Handle the VDD regulator Message-ID: <20220612095333.1479464c@jic23-huawei> In-Reply-To: References: <20220523175344.5845-1-markuss.broks@gmail.com> <20220523175344.5845-4-markuss.broks@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 08 Jun 2022 12:18:52 +0200 "Luca Weiss" wrote: > Hi Markuss, > > On Mon May 23, 2022 at 7:53 PM CEST, Markuss Broks wrote: > > Handle the regulator supplying the VDD pin of VL53L0X. > > > > Signed-off-by: Markuss Broks > > --- > > drivers/iio/proximity/vl53l0x-i2c.c | 37 +++++++++++++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > > > diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c > > index 12a3e2eff464..8581a873919f 100644 > > --- a/drivers/iio/proximity/vl53l0x-i2c.c > > +++ b/drivers/iio/proximity/vl53l0x-i2c.c > > @@ -43,6 +43,7 @@ > > struct vl53l0x_data { > > struct i2c_client *client; > > struct completion completion; > > + struct regulator *vdd_supply; > > }; > > > > static irqreturn_t vl53l0x_handle_irq(int irq, void *priv) > > @@ -192,10 +193,31 @@ static const struct iio_info vl53l0x_info = { > > .read_raw = vl53l0x_read_raw, > > }; > > > > +static void vl53l0x_power_off(void *_data) > > +{ > > + struct vl53l0x_data *data = _data; > > + > > + regulator_disable(data->vdd_supply); > > +} > > + > > +static int vl53l0x_power_on(struct vl53l0x_data *data) > > +{ > > + int ret; > > + > > + ret = regulator_enable(data->vdd_supply); > > + if (ret) > > + return ret; > > + > > + usleep_range(3200, 5000); > > + > > + return 0; > > +} > > + > > static int vl53l0x_probe(struct i2c_client *client) > > { > > struct vl53l0x_data *data; > > struct iio_dev *indio_dev; > > + int error; > > > > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); > > if (!indio_dev) > > @@ -210,6 +232,21 @@ static int vl53l0x_probe(struct i2c_client *client) > > I2C_FUNC_SMBUS_BYTE_DATA)) > > return -EOPNOTSUPP; > > > > + data->vdd_supply = devm_regulator_get_optional(&client->dev, "vdd"); > > + if (IS_ERR(data->vdd_supply)) > > + return dev_err_probe(&client->dev, PTR_ERR(data->vdd_supply), > > + "Unable to get VDD regulator\n"); > > It looks like this optional regulator is not actually optional. > > [ 1.919995] vl53l0x-i2c 1-0029: error -ENODEV: Unable to get VDD regulator > > When using devm_regulator_get instead, a dummy regulator gets returned > which I think is what we want here: > > [ 1.905518] vl53l0x-i2c 1-0029: supply vdd not found, using dummy regulator > > Can you fix this up or should I send a patch? Hi Luca, Please send a patch. Jonathan > > Regards > Luca > > > > + > > + error = vl53l0x_power_on(data); > > + if (error) > > + return dev_err_probe(&client->dev, error, > > + "Failed to power on the chip\n"); > > + > > + error = devm_add_action_or_reset(&client->dev, vl53l0x_power_off, data); > > + if (error) > > + return dev_err_probe(&client->dev, error, > > + "Failed to install poweroff action\n"); > > + > > indio_dev->name = "vl53l0x"; > > indio_dev->info = &vl53l0x_info; > > indio_dev->channels = vl53l0x_channels; > > -- > > 2.36.1 >