From: Bo-Chen Chen <rex-bc.chen@mediatek.com>
To: <chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <matthias.bgg@gmail.com>,
<airlied@linux.ie>
Cc: <msp@baylibre.com>, <granquet@baylibre.com>,
<jitao.shi@mediatek.com>, <wenst@chromium.org>,
<angelogioacchino.delregno@collabora.com>, <ck.hu@mediatek.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Bo-Chen Chen <rex-bc.chen@mediatek.com>
Subject: [PATCH v11 04/12] drm/mediatek: dpi: implement a swap_input toggle in SoC config
Date: Mon, 13 Jun 2022 14:48:33 +0800 [thread overview]
Message-ID: <20220613064841.10481-5-rex-bc.chen@mediatek.com> (raw)
In-Reply-To: <20220613064841.10481-1-rex-bc.chen@mediatek.com>
From: Guillaume Ranquet <granquet@baylibre.com>
The hardware design of dp_intf does not support input swap, so we add
a bit of flexibility to support SoCs without swap_input support.
Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
[Bo-Chen: Add modification reason in commit message.]
Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 15218c1e8c11..c1438c744120 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -126,6 +126,7 @@ struct mtk_dpi_conf {
const u32 *output_fmts;
u32 num_output_fmts;
bool is_ck_de_pol;
+ bool swap_input_support;
const struct mtk_dpi_yc_limit *limit;
};
@@ -378,18 +379,21 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
(format == MTK_DPI_COLOR_FORMAT_YCBCR_444_FULL)) {
mtk_dpi_config_yuv422_enable(dpi, false);
mtk_dpi_config_csc_enable(dpi, true);
- mtk_dpi_config_swap_input(dpi, false);
+ if (dpi->conf->swap_input_support)
+ mtk_dpi_config_swap_input(dpi, false);
mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_BGR);
} else if ((format == MTK_DPI_COLOR_FORMAT_YCBCR_422) ||
(format == MTK_DPI_COLOR_FORMAT_YCBCR_422_FULL)) {
mtk_dpi_config_yuv422_enable(dpi, true);
mtk_dpi_config_csc_enable(dpi, true);
- mtk_dpi_config_swap_input(dpi, true);
+ if (dpi->conf->swap_input_support)
+ mtk_dpi_config_swap_input(dpi, true);
mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
} else {
mtk_dpi_config_yuv422_enable(dpi, false);
mtk_dpi_config_csc_enable(dpi, false);
- mtk_dpi_config_swap_input(dpi, false);
+ if (dpi->conf->swap_input_support)
+ mtk_dpi_config_swap_input(dpi, false);
mtk_dpi_config_channel_swap(dpi, MTK_DPI_OUT_CHANNEL_SWAP_RGB);
}
}
@@ -808,6 +812,7 @@ static const struct mtk_dpi_conf mt8173_conf = {
.output_fmts = mt8173_output_fmts,
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
.is_ck_de_pol = true,
+ .swap_input_support = true,
.limit = &mtk_dpi_limit,
};
@@ -819,6 +824,7 @@ static const struct mtk_dpi_conf mt2701_conf = {
.output_fmts = mt8173_output_fmts,
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
.is_ck_de_pol = true,
+ .swap_input_support = true,
.limit = &mtk_dpi_limit,
};
@@ -829,6 +835,7 @@ static const struct mtk_dpi_conf mt8183_conf = {
.output_fmts = mt8183_output_fmts,
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
.is_ck_de_pol = true,
+ .swap_input_support = true,
.limit = &mtk_dpi_limit,
};
@@ -839,6 +846,7 @@ static const struct mtk_dpi_conf mt8192_conf = {
.output_fmts = mt8183_output_fmts,
.num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
.is_ck_de_pol = true,
+ .swap_input_support = true,
.limit = &mtk_dpi_limit,
};
--
2.18.0
next prev parent reply other threads:[~2022-06-13 6:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 6:48 [PATCH v11 00/12] drm/mediatek: Add MT8195 dp_intf driver Bo-Chen Chen
2022-06-13 6:48 ` [PATCH v11 01/12] dt-bindings: mediatek,dpi: Add DP_INTF compatible Bo-Chen Chen
2022-06-13 13:33 ` Rob Herring
2022-06-14 3:05 ` CK Hu
2022-06-16 7:58 ` Rex-BC Chen
2022-06-14 20:24 ` Rob Herring
2022-06-16 7:55 ` Rex-BC Chen
2022-06-13 6:48 ` [PATCH v11 02/12] drm/mediatek: dpi: move dpi limits to SoC config Bo-Chen Chen
2022-06-14 3:21 ` CK Hu
2022-06-16 10:31 ` Rex-BC Chen
2022-06-13 6:48 ` [PATCH v11 03/12] drm/mediatek: dpi: implement a CK/DE pol toggle in " Bo-Chen Chen
2022-06-14 3:36 ` CK Hu
2022-06-13 6:48 ` Bo-Chen Chen [this message]
2022-06-14 5:27 ` [PATCH v11 04/12] drm/mediatek: dpi: implement a swap_input " CK Hu
2022-06-16 10:36 ` Rex-BC Chen
2022-06-13 6:48 ` [PATCH v11 05/12] drm/mediatek: dpi: move dimension mask to " Bo-Chen Chen
2022-06-13 6:48 ` [PATCH v11 06/12] drm/mediatek: dpi: move hvsize_mask " Bo-Chen Chen
2022-06-13 6:48 ` [PATCH v11 07/12] drm/mediatek: dpi: move swap_shift " Bo-Chen Chen
2022-06-14 5:38 ` CK Hu
2022-06-13 6:48 ` [PATCH v11 08/12] drm/mediatek: dpi: move the yuv422_en_bit " Bo-Chen Chen
2022-06-13 6:48 ` [PATCH v11 09/12] drm/mediatek: dpi: move the csc_enable bit " Bo-Chen Chen
2022-06-14 5:45 ` CK Hu
2022-06-13 6:48 ` [PATCH v11 10/12] drm/mediatek: dpi: Add dpintf support Bo-Chen Chen
2022-06-13 10:55 ` AngeloGioacchino Del Regno
2022-06-16 7:57 ` Rex-BC Chen
2022-06-14 6:04 ` CK Hu
2022-06-16 9:09 ` Rex-BC Chen
2022-06-13 6:48 ` [PATCH v11 11/12] drm/mediatek: dpi: Only enable dpi after the bridge is enabled Bo-Chen Chen
2022-06-14 6:24 ` CK Hu
2022-06-16 10:49 ` Rex-BC Chen
2022-06-13 6:48 ` [PATCH v11 12/12] drm/mediatek: dpi: Add matrix_sel helper Bo-Chen Chen
2022-06-14 6:20 ` CK Hu
2022-06-16 10:51 ` Rex-BC Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220613064841.10481-5-rex-bc.chen@mediatek.com \
--to=rex-bc.chen@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).