From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4904FC433EF for ; Tue, 14 Jun 2022 05:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236679AbiFNFk5 (ORCPT ); Tue, 14 Jun 2022 01:40:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233996AbiFNFk4 (ORCPT ); Tue, 14 Jun 2022 01:40:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B1A3818A; Mon, 13 Jun 2022 22:40:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E789761656; Tue, 14 Jun 2022 05:40:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF593C3411D; Tue, 14 Jun 2022 05:40:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655185255; bh=8+SZwi6ZZQOdOLhjzNsGV38OcJEcLt3L/iI4gfDuoy0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vCXSnJ9YgN0pYz/fA6s3HEkpkE0UVedd9pCcfJ7jd5bPmTsvzqBtyD5OD/cjyvhZM wDtzGITCZJG/EHC2S/LmYOvCL1QxkFEzbyLBUzidronfSdUO3kAGMs+VnCGDcE1KIX dtQQjPo8FH9B9F1eUHZ4XnxyRTs+qWBbSKnGISs6DaimaaJzA0juSfJZl+aqEJpqMc PYsSkwRDiahPdlH7rCRJxHu3et+Bnhras5HAcdeeuJkqF8yBIi5j8xEX/Vf42pUTEZ 6aki+hsu0dcoxRcS3SloMRvjrrR9OBGJXZzJ5j+qFNqenOMg+UwWitwyLdmeZZHrwz G4wU3g5np/q6Q== Date: Mon, 13 Jun 2022 22:40:53 -0700 From: Jakub Kicinski To: Rasmus Villemoes Cc: Andrew Lunn , netdev@vger.kernel.org, Heiner Kallweit , Russell King , devicetree@vger.kernel.org, Rob Herring , "David S. Miller" , Dan Murphy , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] dt-bindings: dp83867: add binding for io_impedance_ctrl nvmem cell Message-ID: <20220613224053.078f573c@kernel.org> In-Reply-To: <29ddcecb-18d3-b92e-10fb-d5ea278886d6@rasmusvillemoes.dk> References: <20220606202220.1670714-1-linux@rasmusvillemoes.dk> <20220606202220.1670714-2-linux@rasmusvillemoes.dk> <29ddcecb-18d3-b92e-10fb-d5ea278886d6@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 7 Jun 2022 13:54:30 +0200 Rasmus Villemoes wrote: > On 06/06/2022 23.58, Andrew Lunn wrote: > >> There is no documented mapping from the 32 possible values of the > >> IO_IMPEDANCE_CTRL field to values in the range 35-70 ohms > > > > There have been a few active TI engineers submitting patches to TI PHY > > drivers. Please could you reach out to them and ask if they can > > provide documentation. > > > > Having magic values in DT is not the preferred why to use it. Ideally > > you should store Ohms in the cell and convert to the register value. > > We've already asked TI for more detailed information, but apparently the > data sheet already says all there is to know. I should have worded the > commit message differently. Something like > > There is no fixed mapping from register values to values in the range > 35-70 ohms; it varies from chip to chip, and even that target range is > approximate. The series was waiting for Andrew to come back but it ended up getting marked as Changes Requested in PW. Would you mind reposting with the modification to the commit message?