From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76F23CCA47C for ; Tue, 14 Jun 2022 10:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239083AbiFNKjt (ORCPT ); Tue, 14 Jun 2022 06:39:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbiFNKjs (ORCPT ); Tue, 14 Jun 2022 06:39:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE66235252; Tue, 14 Jun 2022 03:39:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AF974B81856; Tue, 14 Jun 2022 10:39:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7603C3411B; Tue, 14 Jun 2022 10:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655203185; bh=1WpNbruZfpiREjP5nt5HMy2K24XhwdQUFBtL7VlCzIM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EPBud0OBnT4YGtLFkEMrFQLy/bCsgRcqOPkc0XW79lwTBSYcD5svdm+wvid3QGguz tdAElO6q1DIS4kHo4IC9FnIlK1wV8nvfg3fe67VkfgJSzYXz9DN7bFi9/h53Hnsr1+ wuAFP1mWFUPZ3cmM5r3GaLZEFvMJdtH9Vmyw9VogNN7Zkl1eCOnPp3wlIqGVbVO0Pq QvfB3fs1pelbAWDxvIH6WHtJaPEVQN5QgtVO3gn2PS+aCMaRtc8ezKYfy00EJbhm2+ urC7cq9vu5lQCseSz4DsZ47sCiZeCdl6QRCpQX6jvjamqyZTjsdjn5HnwbG44g4+KL wD5lfT8UKEBAg== Date: Tue, 14 Jun 2022 11:48:53 +0100 From: Jonathan Cameron To: Luca Weiss Cc: Luca Weiss , ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Konrad Dybcio , Marijn Suijten , AngeloGioacchino Del Regno , Song Qiang , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 3/5] proximity: vl53l0x: Handle the VDD regulator Message-ID: <20220614114853.340e9c36@jic23-huawei> In-Reply-To: <13033502.uLZWGnKmhe@g550jk> References: <20220523175344.5845-1-markuss.broks@gmail.com> <20220612095333.1479464c@jic23-huawei> <13033502.uLZWGnKmhe@g550jk> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, 12 Jun 2022 11:28:22 +0200 Luca Weiss wrote: > Hi Jonathan, > > On Sonntag, 12. Juni 2022 10:53:33 CEST Jonathan Cameron wrote: > > On Wed, 08 Jun 2022 12:18:52 +0200 > > > > "Luca Weiss" wrote: > > > Hi Markuss, > > > > > > On Mon May 23, 2022 at 7:53 PM CEST, Markuss Broks wrote: > > > > Handle the regulator supplying the VDD pin of VL53L0X. > > > > > > > > Signed-off-by: Markuss Broks > > > > --- > > > > > > > > drivers/iio/proximity/vl53l0x-i2c.c | 37 +++++++++++++++++++++++++++++ > > > > 1 file changed, 37 insertions(+) > > > > > > > > diff --git a/drivers/iio/proximity/vl53l0x-i2c.c > > > > b/drivers/iio/proximity/vl53l0x-i2c.c index 12a3e2eff464..8581a873919f > > > > 100644 > > > > --- a/drivers/iio/proximity/vl53l0x-i2c.c > > > > +++ b/drivers/iio/proximity/vl53l0x-i2c.c > > > > @@ -43,6 +43,7 @@ > > > > > > > > struct vl53l0x_data { > > > > > > > > struct i2c_client *client; > > > > struct completion completion; > > > > > > > > + struct regulator *vdd_supply; > > > > > > > > }; > > > > > > > > static irqreturn_t vl53l0x_handle_irq(int irq, void *priv) > > > > > > > > @@ -192,10 +193,31 @@ static const struct iio_info vl53l0x_info = { > > > > > > > > .read_raw = vl53l0x_read_raw, > > > > > > > > }; > > > > > > > > +static void vl53l0x_power_off(void *_data) > > > > +{ > > > > + struct vl53l0x_data *data = _data; > > > > + > > > > + regulator_disable(data->vdd_supply); > > > > +} > > > > + > > > > +static int vl53l0x_power_on(struct vl53l0x_data *data) > > > > +{ > > > > + int ret; > > > > + > > > > + ret = regulator_enable(data->vdd_supply); > > > > + if (ret) > > > > + return ret; > > > > + > > > > + usleep_range(3200, 5000); > > > > + > > > > + return 0; > > > > +} > > > > + > > > > > > > > static int vl53l0x_probe(struct i2c_client *client) > > > > { > > > > > > > > struct vl53l0x_data *data; > > > > struct iio_dev *indio_dev; > > > > > > > > + int error; > > > > > > > > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); > > > > if (!indio_dev) > > > > > > > > @@ -210,6 +232,21 @@ static int vl53l0x_probe(struct i2c_client *client) > > > > > > > > I2C_FUNC_SMBUS_BYTE_DATA)) > > > > > > > > return -EOPNOTSUPP; > > > > > > > > + data->vdd_supply = devm_regulator_get_optional(&client->dev, > "vdd"); > > > > + if (IS_ERR(data->vdd_supply)) > > > > + return dev_err_probe(&client->dev, PTR_ERR(data- > >vdd_supply), > > > > + "Unable to get VDD > regulator\n"); > > > > > > It looks like this optional regulator is not actually optional. > > > > > > [ 1.919995] vl53l0x-i2c 1-0029: error -ENODEV: Unable to get VDD > > > regulator > > > > > > When using devm_regulator_get instead, a dummy regulator gets returned > > > which I think is what we want here: > > > > > > [ 1.905518] vl53l0x-i2c 1-0029: supply vdd not found, using dummy > > > regulator > > > > > > Can you fix this up or should I send a patch? > > > > Hi Luca, > > > > Please send a patch. > > Which commit sha can I use for Fixes: here? > Based your togreg[0] branch currently shows "Age: 20 hours" I guess it was > rebased recently? It was rebased onto rc1 as you noticed. In theory it is now stable, assuming nothing nasty shows up. Fixes tag doesn't matter strongly given both will go into mainline via the same pull request, so maybe just skip adding one to make my life easier :) Thanks, Jonathan > > Regards > Luca > > [0]https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=togreg > > > > > Jonathan > > > > > Regards > > > Luca > > > > > > > + > > > > + error = vl53l0x_power_on(data); > > > > + if (error) > > > > + return dev_err_probe(&client->dev, error, > > > > + "Failed to power on the > chip\n"); > > > > + > > > > + error = devm_add_action_or_reset(&client->dev, vl53l0x_power_off, > > > > data); > > > > + if (error) > > > > + return dev_err_probe(&client->dev, error, > > > > + "Failed to install poweroff > action\n"); > > > > + > > > > > > > > indio_dev->name = "vl53l0x"; > > > > indio_dev->info = &vl53l0x_info; > > > > indio_dev->channels = vl53l0x_channels; > > > >