From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
Taniya Das <quic_tdas@quicinc.com>,
mka@chromium.org
Subject: Re: [PATCH v5 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280
Date: Wed, 15 Jun 2022 12:59:13 -0700 [thread overview]
Message-ID: <20220615195914.D73B9C3411E@smtp.kernel.org> (raw)
In-Reply-To: <20220614153306.29339-2-quic_tdas@quicinc.com>
Quoting Taniya Das (2022-06-14 08:33:04)
> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
> for SC7280. Update reg property min/max items in YAML schema.
>
> Fixes: 4185b27b3bef ("dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280").
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> .../clock/qcom,sc7280-lpasscorecc.yaml | 19 ++++++++++++++++---
> .../clock/qcom,lpassaudiocc-sc7280.h | 5 +++++
> 2 files changed, 21 insertions(+), 3 deletions(-)
I'm still wondering if the binding is correct, given the overlapping reg
properties. Should we be removing a compatible or two and adding a DT
property like "qcom,adsp-bypass-mode" instead?
next prev parent reply other threads:[~2022-06-15 19:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 15:33 [PATCH v5 0/3] Add support for audio clock gating resets for SC7280 Taniya Das
2022-06-14 15:33 ` [PATCH v5 1/3] dt-bindings: clock: Add resets for LPASS audio clock controller " Taniya Das
2022-06-15 19:59 ` Stephen Boyd [this message]
2022-07-07 6:01 ` Taniya Das
2022-06-14 15:33 ` [PATCH v5 2/3] dt-bindings: clock: Add support for external MCLKs for LPASS on SC7280 Taniya Das
2022-06-15 19:56 ` Stephen Boyd
2022-06-14 15:33 ` [PATCH v5 3/3] clk: qcom: lpass: Add support for resets & external mclk for SC7280 Taniya Das
2022-06-15 19:55 ` Stephen Boyd
2022-07-07 5:57 ` Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220615195914.D73B9C3411E@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).