* [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel @ 2022-06-10 11:15 Bastian Krause 2022-06-10 11:15 ` [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H Bastian Krause 2022-06-16 17:15 ` [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Rob Herring 0 siblings, 2 replies; 5+ messages in thread From: Bastian Krause @ 2022-06-10 11:15 UTC (permalink / raw) To: dri-devel Cc: devicetree, Rob Herring, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Philipp Zabel, Yannick Fertre, kernel, Bastian Krause Add Ampire AM-800600P5TMQW-TB8H 8" TFT LCD panel compatible string. Signed-off-by: Bastian Krause <bst@pengutronix.de> --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 21ba90c9fe338..00a2bffa0ce82 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -35,6 +35,8 @@ properties: - ampire,am-480272h3tmqw-t01h # Ampire AM-800480R3TMQW-A1H 7.0" WVGA TFT LCD panel - ampire,am800480r3tmqwa1h + # Ampire AM-800600P5TMQW-TB8H 8.0" SVGA TFT LCD panel + - ampire,am800600p5tmqw-tb8h # AU Optronics Corporation 10.1" WSVGA TFT LCD panel - auo,b101aw03 # AU Optronics Corporation 10.1" WSVGA TFT LCD panel -- 2.30.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H 2022-06-10 11:15 [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Bastian Krause @ 2022-06-10 11:15 ` Bastian Krause 2022-06-24 19:54 ` Sam Ravnborg 2022-06-16 17:15 ` [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Rob Herring 1 sibling, 1 reply; 5+ messages in thread From: Bastian Krause @ 2022-06-10 11:15 UTC (permalink / raw) To: dri-devel Cc: devicetree, Rob Herring, Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter, Philipp Zabel, Yannick Fertre, kernel, Bastian Krause Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data sheet is currently not publicly available, unfortunately. Signed-off-by: Bastian Krause <bst@pengutronix.de> --- drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4a2e580a2f7b7..3a61873dd887c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -778,6 +778,36 @@ static const struct panel_desc ampire_am800480r3tmqwa1h = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = { + .pixelclock = { 34500000, 39600000, 50400000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 12, 112, 312 }, + .hback_porch = { 87, 87, 48 }, + .hsync_len = { 1, 1, 40 }, + .vactive = { 600, 600, 600 }, + .vfront_porch = { 1, 21, 61 }, + .vback_porch = { 38, 38, 19 }, + .vsync_len = { 1, 1, 20 }, + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | + DISPLAY_FLAGS_SYNC_POSEDGE, +}; + +static const struct panel_desc ampire_am800600p5tmqwtb8h = { + .timings = &ire_am800600p5tmqw_tb8h_timing, + .num_timings = 1, + .bpc = 6, + .size = { + .width = 162, + .height = 122, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct display_timing santek_st0700i5y_rbslw_f_timing = { .pixelclock = { 26400000, 33300000, 46800000 }, .hactive = { 800, 800, 800 }, @@ -3754,6 +3784,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "ampire,am800480r3tmqwa1h", .data = &ire_am800480r3tmqwa1h, + }, { + .compatible = "ampire,am800600p5tmqwtb8h", + .data = &ire_am800600p5tmqwtb8h, }, { .compatible = "arm,rtsm-display", .data = &arm_rtsm, -- 2.30.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H 2022-06-10 11:15 ` [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H Bastian Krause @ 2022-06-24 19:54 ` Sam Ravnborg 2022-06-27 8:12 ` Bastian Krause 0 siblings, 1 reply; 5+ messages in thread From: Sam Ravnborg @ 2022-06-24 19:54 UTC (permalink / raw) To: Bastian Krause Cc: dri-devel, kernel, devicetree, David Airlie, Yannick Fertre, Rob Herring, Thierry Reding Hi Bastian, On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote: > Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data > sheet is currently not publicly available, unfortunately. > > Signed-off-by: Bastian Krause <bst@pengutronix.de> Applied to drm-misc (drm-misc-next). When applying I fixed up the compatible to match the binding. You may need to fix your DT files if they used the old compatible. The one from the binding had a dash like similar panels, so that is the one I picked. See below for the fix-up. Sam > --- > drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4a2e580a2f7b7..3a61873dd887c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -778,6 +778,36 @@ static const struct panel_desc ampire_am800480r3tmqwa1h = { > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > }; > > +static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = { > + .pixelclock = { 34500000, 39600000, 50400000 }, > + .hactive = { 800, 800, 800 }, > + .hfront_porch = { 12, 112, 312 }, > + .hback_porch = { 87, 87, 48 }, > + .hsync_len = { 1, 1, 40 }, > + .vactive = { 600, 600, 600 }, > + .vfront_porch = { 1, 21, 61 }, > + .vback_porch = { 38, 38, 19 }, > + .vsync_len = { 1, 1, 20 }, > + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | > + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | > + DISPLAY_FLAGS_SYNC_POSEDGE, > +}; > + > +static const struct panel_desc ampire_am800600p5tmqwtb8h = { > + .timings = &ire_am800600p5tmqw_tb8h_timing, > + .num_timings = 1, > + .bpc = 6, > + .size = { > + .width = 162, > + .height = 122, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | > + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | > + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, > + .connector_type = DRM_MODE_CONNECTOR_DPI, > +}; > + > static const struct display_timing santek_st0700i5y_rbslw_f_timing = { > .pixelclock = { 26400000, 33300000, 46800000 }, > .hactive = { 800, 800, 800 }, > @@ -3754,6 +3784,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "ampire,am800480r3tmqwa1h", > .data = &ire_am800480r3tmqwa1h, > + }, { > + .compatible = "ampire,am800600p5tmqwtb8h", was changed to > + .compatible = "ampire,am800600p5tmqw-tb8h", > + .data = &ire_am800600p5tmqwtb8h, > }, { > .compatible = "arm,rtsm-display", > .data = &arm_rtsm, > -- > 2.30.2 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H 2022-06-24 19:54 ` Sam Ravnborg @ 2022-06-27 8:12 ` Bastian Krause 0 siblings, 0 replies; 5+ messages in thread From: Bastian Krause @ 2022-06-27 8:12 UTC (permalink / raw) To: Sam Ravnborg Cc: dri-devel, kernel, devicetree, David Airlie, Yannick Fertre, Rob Herring, Thierry Reding Hi Sam, On 6/24/22 21:54, Sam Ravnborg wrote: > On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote: >> Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data >> sheet is currently not publicly available, unfortunately. >> >> Signed-off-by: Bastian Krause <bst@pengutronix.de> > > Applied to drm-misc (drm-misc-next). > When applying I fixed up the compatible to match the binding. > You may need to fix your DT files if they used the old compatible. > The one from the binding had a dash like similar panels, so that is > the one I picked. Thanks! I changed the compatible in the yaml binding to resemble the other Ampire compabibles, but forgot to change that in the actual code, of course.. > See below for the fix-up. > > Sam > >> --- >> drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index 4a2e580a2f7b7..3a61873dd887c 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -778,6 +778,36 @@ static const struct panel_desc ampire_am800480r3tmqwa1h = { >> .bus_format = MEDIA_BUS_FMT_RGB666_1X18, >> }; >> >> +static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = { >> + .pixelclock = { 34500000, 39600000, 50400000 }, >> + .hactive = { 800, 800, 800 }, >> + .hfront_porch = { 12, 112, 312 }, >> + .hback_porch = { 87, 87, 48 }, >> + .hsync_len = { 1, 1, 40 }, >> + .vactive = { 600, 600, 600 }, >> + .vfront_porch = { 1, 21, 61 }, >> + .vback_porch = { 38, 38, 19 }, >> + .vsync_len = { 1, 1, 20 }, >> + .flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW | >> + DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE | >> + DISPLAY_FLAGS_SYNC_POSEDGE, >> +}; >> + >> +static const struct panel_desc ampire_am800600p5tmqwtb8h = { >> + .timings = &ire_am800600p5tmqw_tb8h_timing, >> + .num_timings = 1, >> + .bpc = 6, >> + .size = { >> + .width = 162, >> + .height = 122, >> + }, >> + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, >> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | >> + DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | >> + DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE, >> + .connector_type = DRM_MODE_CONNECTOR_DPI, >> +}; >> + >> static const struct display_timing santek_st0700i5y_rbslw_f_timing = { >> .pixelclock = { 26400000, 33300000, 46800000 }, >> .hactive = { 800, 800, 800 }, >> @@ -3754,6 +3784,9 @@ static const struct of_device_id platform_of_match[] = { >> }, { >> .compatible = "ampire,am800480r3tmqwa1h", >> .data = &ire_am800480r3tmqwa1h, >> + }, { >> + .compatible = "ampire,am800600p5tmqwtb8h", > was changed to >> + .compatible = "ampire,am800600p5tmqw-tb8h", >> + .data = &ire_am800600p5tmqwtb8h, Your fixup is correct. Regards, Bastian >> }, { >> .compatible = "arm,rtsm-display", >> .data = &arm_rtsm, >> -- >> 2.30.2 >> -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel 2022-06-10 11:15 [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Bastian Krause 2022-06-10 11:15 ` [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H Bastian Krause @ 2022-06-16 17:15 ` Rob Herring 1 sibling, 0 replies; 5+ messages in thread From: Rob Herring @ 2022-06-16 17:15 UTC (permalink / raw) To: Bastian Krause Cc: devicetree, Sam Ravnborg, Rob Herring, kernel, David Airlie, Yannick Fertre, dri-devel, Daniel Vetter, Philipp Zabel, Thierry Reding On Fri, 10 Jun 2022 13:15:10 +0200, Bastian Krause wrote: > Add Ampire AM-800600P5TMQW-TB8H 8" TFT LCD panel compatible string. > > Signed-off-by: Bastian Krause <bst@pengutronix.de> > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-27 8:12 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-06-10 11:15 [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Bastian Krause 2022-06-10 11:15 ` [PATCH 2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H Bastian Krause 2022-06-24 19:54 ` Sam Ravnborg 2022-06-27 8:12 ` Bastian Krause 2022-06-16 17:15 ` [PATCH 1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).