From: Jonathan Cameron <jic23@kernel.org>
To: Jakob Hauser <jahau@rocketmail.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant
Date: Sat, 18 Jun 2022 15:15:38 +0100 [thread overview]
Message-ID: <20220618151538.3d142682@jic23-huawei> (raw)
In-Reply-To: <033f64ea-4ba7-eb89-3259-688008e29989@rocketmail.com>
>
> >> + /* Sanity check, is this all zeroes? */
> >> + if (memchr_inv(data, 0x00, 16) == NULL) {
> >
> > if (!memchr_inv(...))
> >
> >> + if (FIELD_GET(GENMASK(5, 0), data[16]) == 0)
> >> + dev_warn(yas5xx->dev, "calibration is blank!\n");
> >> + }
>
> No problem to change for YAS537.
>
> At YAS530/532, there is a similar line that should be changed
> accordingly. However, there is a patch by Linus that was already added
> to "fixes-togreg" branch in iio.git quite a while ago [5]. The patch is
> not included in torvalds/linux v5.19-rc1 or -rc2 and neither in iio.git
> testing branch. So I'm unsure what I should base the patchset on if I
> want to change that line. I will probably choose linux-next, as the
> patch is included there and in Kconfig also patch "iio: magnetometer:
> ak8974: Drop dependency on OF" is included (which on the other hand
> isn't included in "fixes-togreg" branch in iio.git).
>
> [5]
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=bb52d3691db8cf24cea049235223f3599778f264
Busy couple of weeks for me and that fix got caught up in the merge
window timing before that. I should get a pull request out shortly.
Jonathan
next prev parent reply other threads:[~2022-06-18 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1655081082.git.jahau.ref@rocketmail.com>
2022-06-13 1:15 ` [PATCH v2 0/7] Add support for magnetometer Yamaha YAS537 Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 1/7] iio: magnetometer: yas530: Change data type of hard_offsets to signed Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 2/7] iio: magnetometer: yas530: Change range of data in volatile register Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 3/7] iio: magnetometer: yas530: Correct scaling of magnetic axes Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 4/7] iio: magnetometer: yas530: Correct temperature handling Jakob Hauser
2022-06-13 15:01 ` Andy Shevchenko
2022-06-15 21:18 ` Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 5/7] iio: magnetometer: yas530: Change data type of calibration coefficients Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 6/7] iio: magnetometer: yas530: Rename functions and registers Jakob Hauser
2022-06-13 1:17 ` [PATCH v2 7/7] iio: magnetometer: yas530: Add YAS537 variant Jakob Hauser
2022-06-13 15:20 ` Andy Shevchenko
2022-06-13 15:22 ` Andy Shevchenko
2022-06-15 21:51 ` Jakob Hauser
2022-06-15 21:43 ` Jakob Hauser
2022-06-15 22:00 ` Jakob Hauser
2022-06-18 14:15 ` Jonathan Cameron [this message]
2022-06-13 15:23 ` [PATCH v2 0/7] Add support for magnetometer Yamaha YAS537 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220618151538.3d142682@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jahau@rocketmail.com \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).