devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2
@ 2022-06-21 15:23 Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 1/4] usb: host: ohci-platform: add TPL support Fabrice Gasnier
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Fabrice Gasnier @ 2022-06-21 15:23 UTC (permalink / raw)
  To: hminas, gregkh, robh+dt
  Cc: stern, krzysztof.kozlowski+dt, devicetree, linux-usb,
	linux-kernel, linux-arm-kernel, linux-stm32, amelie.delaunay,
	fabrice.gasnier

The Target Peripheral List (TPL) support is used to identify targeted
devices during Embedded Host (EH) compliance testing. Add TPL support
setting from device tree on ehci-platform, ohci-platform and dwc2 drivers.
Also document TPL support in DWC2 dt-bindings.

Changes in v2:
- Document TPL support in DWC2 dt-bindings
- Spell TPL and EH
- Add collected ack

Amelie Delaunay (3):
  usb: host: ohci-platform: add TPL support
  usb: host: ehci-platform: add TPL support
  usb: dwc2: host: add TPL support

Fabrice Gasnier (1):
  dt-bindings: usb: dwc2: document TPL support

 Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
 drivers/usb/dwc2/hcd.c                          | 3 +++
 drivers/usb/host/ehci-platform.c                | 2 ++
 drivers/usb/host/ohci-platform.c                | 3 +++
 4 files changed, 11 insertions(+)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 1/4] usb: host: ohci-platform: add TPL support
  2022-06-21 15:23 [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2 Fabrice Gasnier
@ 2022-06-21 15:23 ` Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 2/4] usb: host: ehci-platform: " Fabrice Gasnier
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Fabrice Gasnier @ 2022-06-21 15:23 UTC (permalink / raw)
  To: hminas, gregkh, robh+dt
  Cc: stern, krzysztof.kozlowski+dt, devicetree, linux-usb,
	linux-kernel, linux-arm-kernel, linux-stm32, amelie.delaunay,
	fabrice.gasnier

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The Target Peripheral List (TPL) is used to identify targeted devices
during Embedded Host compliance testing. The user can add "tpl-support"
in the device tree to enable it.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
Changes in v2:
- update commit message to clarify TPL and EH meaning
- add collected ack
---
 drivers/usb/host/ohci-platform.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/host/ohci-platform.c b/drivers/usb/host/ohci-platform.c
index 47dfbfe9e5190..0adae62651276 100644
--- a/drivers/usb/host/ohci-platform.c
+++ b/drivers/usb/host/ohci-platform.c
@@ -28,6 +28,7 @@
 #include <linux/usb/ohci_pdriver.h>
 #include <linux/usb.h>
 #include <linux/usb/hcd.h>
+#include <linux/usb/of.h>
 
 #include "ohci.h"
 
@@ -210,6 +211,8 @@ static int ohci_platform_probe(struct platform_device *dev)
 	hcd->rsrc_start = res_mem->start;
 	hcd->rsrc_len = resource_size(res_mem);
 
+	hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
+
 	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
 	if (err)
 		goto err_power;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 2/4] usb: host: ehci-platform: add TPL support
  2022-06-21 15:23 [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2 Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 1/4] usb: host: ohci-platform: add TPL support Fabrice Gasnier
@ 2022-06-21 15:23 ` Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 3/4] dt-bindings: usb: dwc2: document " Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 4/4] usb: dwc2: host: add " Fabrice Gasnier
  3 siblings, 0 replies; 6+ messages in thread
From: Fabrice Gasnier @ 2022-06-21 15:23 UTC (permalink / raw)
  To: hminas, gregkh, robh+dt
  Cc: stern, krzysztof.kozlowski+dt, devicetree, linux-usb,
	linux-kernel, linux-arm-kernel, linux-stm32, amelie.delaunay,
	fabrice.gasnier

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The Target Peripheral List (TPL) is used to identify targeted devices
during Embedded Host compliance testing. The user can add "tpl-support"
in the device tree to enable it.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
Changes in v2:
- update commit message to clarify TPL and EH meaning
- add collected ack
---
 drivers/usb/host/ehci-platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
index f343967443e23..6924f0316e9a8 100644
--- a/drivers/usb/host/ehci-platform.c
+++ b/drivers/usb/host/ehci-platform.c
@@ -370,6 +370,8 @@ static int ehci_platform_probe(struct platform_device *dev)
 	hcd->rsrc_start = res_mem->start;
 	hcd->rsrc_len = resource_size(res_mem);
 
+	hcd->tpl_support = of_usb_host_tpl_support(dev->dev.of_node);
+
 	err = usb_add_hcd(hcd, irq, IRQF_SHARED);
 	if (err)
 		goto err_power;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 3/4] dt-bindings: usb: dwc2: document TPL support
  2022-06-21 15:23 [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2 Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 1/4] usb: host: ohci-platform: add TPL support Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 2/4] usb: host: ehci-platform: " Fabrice Gasnier
@ 2022-06-21 15:23 ` Fabrice Gasnier
  2022-06-21 15:23 ` [PATCH v2 4/4] usb: dwc2: host: add " Fabrice Gasnier
  3 siblings, 0 replies; 6+ messages in thread
From: Fabrice Gasnier @ 2022-06-21 15:23 UTC (permalink / raw)
  To: hminas, gregkh, robh+dt
  Cc: stern, krzysztof.kozlowski+dt, devicetree, linux-usb,
	linux-kernel, linux-arm-kernel, linux-stm32, amelie.delaunay,
	fabrice.gasnier

The target peripheral list (TPL) is used to identify targeted devices
during Embedded Host compliance testing. The user can add "tpl-support"
in the device tree to enable it.
Document TPL support as described in usb-hcd.yaml.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 Documentation/devicetree/bindings/usb/dwc2.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 8d22a9843ba58..1bfbc6ef16eb5 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -11,6 +11,7 @@ maintainers:
 
 allOf:
   - $ref: usb-drd.yaml#
+  - $ref: usb-hcd.yaml#
 
 properties:
   compatible:
@@ -161,6 +162,8 @@ properties:
       property is used.
     $ref: /schemas/graph.yaml#/properties/port
 
+  tpl-support: true
+
 dependencies:
   port: [ usb-role-switch ]
   role-switch-default-mode: [ usb-role-switch ]
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2 4/4] usb: dwc2: host: add TPL support
  2022-06-21 15:23 [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2 Fabrice Gasnier
                   ` (2 preceding siblings ...)
  2022-06-21 15:23 ` [PATCH v2 3/4] dt-bindings: usb: dwc2: document " Fabrice Gasnier
@ 2022-06-21 15:23 ` Fabrice Gasnier
  2022-06-22  5:32   ` Minas Harutyunyan
  3 siblings, 1 reply; 6+ messages in thread
From: Fabrice Gasnier @ 2022-06-21 15:23 UTC (permalink / raw)
  To: hminas, gregkh, robh+dt
  Cc: stern, krzysztof.kozlowski+dt, devicetree, linux-usb,
	linux-kernel, linux-arm-kernel, linux-stm32, amelie.delaunay,
	fabrice.gasnier

From: Amelie Delaunay <amelie.delaunay@foss.st.com>

The Target Peripheral List (TPL) is used to identify targeted devices
during Embedded Host compliance testing. The user can add "tpl-support"
in the device tree to enable it.

Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
Changes in v2:
- added dt-bindings precursor patch
- update commit message to clarify TPL and EH meaning
---
 drivers/usb/dwc2/hcd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index f63a27d11fac8..4567f3c24d225 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -52,6 +52,7 @@
 
 #include <linux/usb/hcd.h>
 #include <linux/usb/ch11.h>
+#include <linux/usb/of.h>
 
 #include "core.h"
 #include "hcd.h"
@@ -5339,6 +5340,8 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
 	/* Don't support SG list at this point */
 	hcd->self.sg_tablesize = 0;
 
+	hcd->tpl_support = of_usb_host_tpl_support(hsotg->dev->of_node);
+
 	if (!IS_ERR_OR_NULL(hsotg->uphy))
 		otg_set_host(hsotg->uphy->otg, &hcd->self);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 4/4] usb: dwc2: host: add TPL support
  2022-06-21 15:23 ` [PATCH v2 4/4] usb: dwc2: host: add " Fabrice Gasnier
@ 2022-06-22  5:32   ` Minas Harutyunyan
  0 siblings, 0 replies; 6+ messages in thread
From: Minas Harutyunyan @ 2022-06-22  5:32 UTC (permalink / raw)
  To: Fabrice Gasnier, gregkh@linuxfoundation.org, robh+dt@kernel.org
  Cc: stern@rowland.harvard.edu, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	amelie.delaunay@foss.st.com

On 6/21/2022 7:23 PM, Fabrice Gasnier wrote:
> From: Amelie Delaunay <amelie.delaunay@foss.st.com>
> 
> The Target Peripheral List (TPL) is used to identify targeted devices
> during Embedded Host compliance testing. The user can add "tpl-support"
> in the device tree to enable it.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
> Changes in v2:
> - added dt-bindings precursor patch
> - update commit message to clarify TPL and EH meaning
> ---
>   drivers/usb/dwc2/hcd.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index f63a27d11fac8..4567f3c24d225 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -52,6 +52,7 @@
>   
>   #include <linux/usb/hcd.h>
>   #include <linux/usb/ch11.h>
> +#include <linux/usb/of.h>
>   
>   #include "core.h"
>   #include "hcd.h"
> @@ -5339,6 +5340,8 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
>   	/* Don't support SG list at this point */
>   	hcd->self.sg_tablesize = 0;
>   
> +	hcd->tpl_support = of_usb_host_tpl_support(hsotg->dev->of_node);
> +
>   	if (!IS_ERR_OR_NULL(hsotg->uphy))
>   		otg_set_host(hsotg->uphy->otg, &hcd->self);
>   


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-22  5:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-21 15:23 [PATCH v2 0/4] usb: host: add TPL support to ehci ohci and dwc2 Fabrice Gasnier
2022-06-21 15:23 ` [PATCH v2 1/4] usb: host: ohci-platform: add TPL support Fabrice Gasnier
2022-06-21 15:23 ` [PATCH v2 2/4] usb: host: ehci-platform: " Fabrice Gasnier
2022-06-21 15:23 ` [PATCH v2 3/4] dt-bindings: usb: dwc2: document " Fabrice Gasnier
2022-06-21 15:23 ` [PATCH v2 4/4] usb: dwc2: host: add " Fabrice Gasnier
2022-06-22  5:32   ` Minas Harutyunyan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).