From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85031C433EF for ; Wed, 22 Jun 2022 11:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350021AbiFVLMl (ORCPT ); Wed, 22 Jun 2022 07:12:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231809AbiFVLMj (ORCPT ); Wed, 22 Jun 2022 07:12:39 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9D793BFAF; Wed, 22 Jun 2022 04:12:37 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25MBCTTN031674; Wed, 22 Jun 2022 06:12:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655896349; bh=4cn2KPCkAbJlA+enbARbaubHWo+n0LCFvCvOwchwjzw=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=VDk/eHG6vfnIJ9sj6oWRQYxv0rNrloyhUGtTQVkxvCDTSIVTwnIITASVBJHynvmM8 lNCduqavbF/SxaCskLnAQw2DzeKMFxM5xnWLCj3UWohLsWwejUgurxBiRnDkIgFKIb yL3I3dmUdCWLh5sZIhVM8l4+rPm2la3zrr1gUqb4= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25MBCTtZ089514 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jun 2022 06:12:29 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 22 Jun 2022 06:12:29 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Wed, 22 Jun 2022 06:12:29 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25MBCSrJ109738; Wed, 22 Jun 2022 06:12:28 -0500 Date: Wed, 22 Jun 2022 16:42:27 +0530 From: Rahul T R To: Laurent Pinchart CC: , , , , , , , , , , , , , Subject: Re: [PATCH v2 2/3] phy: cdns-dphy: Add band config for dphy tx Message-ID: <20220622111226.srjx7hddeecwan7y@uda0490373> References: <20220622075340.16915-1-r-ravikumar@ti.com> <20220622075340.16915-3-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11:16-20220622, Laurent Pinchart wrote: > Hi Rahul, > > Thank you for the patch. > > On Wed, Jun 22, 2022 at 01:23:39PM +0530, Rahul T R wrote: > > Add support for band ctrl config for dphy tx. > > > > Signed-off-by: Rahul T R > > --- > > drivers/phy/cadence/cdns-dphy.c | 52 ++++++++++++++++++++++++++++++++- > > 1 file changed, 51 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/phy/cadence/cdns-dphy.c b/drivers/phy/cadence/cdns-dphy.c > > index ba042e39cfaf..ddfa524d8ce7 100644 > > --- a/drivers/phy/cadence/cdns-dphy.c > > +++ b/drivers/phy/cadence/cdns-dphy.c > > @@ -4,6 +4,7 @@ > > */ > > > > #include > > +#include > > Nitpicking, bitfield goes before bitops :-) > > > #include > > #include > > #include > > @@ -45,6 +46,10 @@ > > #define DPHY_CMN_OPDIV_FROM_REG BIT(6) > > #define DPHY_CMN_OPDIV(x) ((x) << 7) > > > > +#define DPHY_BAND_CFG DPHY_PCS(0x0) > > +#define DPHY_BAND_CFG_LEFT_BAND GENMASK(4, 0) > > +#define DPHY_BAND_CFG_RIGHT_BAND GENMASK(9, 5) > > + > > #define DPHY_PSM_CFG DPHY_PCS(0x4) > > #define DPHY_PSM_CFG_FROM_REG BIT(0) > > #define DPHY_PSM_CLK_DIV(x) ((x) << 1) > > @@ -92,6 +97,22 @@ struct cdns_dphy { > > struct phy *phy; > > }; > > > > +struct cdns_dphy_band { > > + unsigned int min_rate; > > + unsigned int max_rate; > > +}; > > + > > +/* Order of bands is important since the index is the band number. */ > > +static struct cdns_dphy_band tx_bands[] = { > > static const > > > + {80, 100}, {100, 120}, {120, 160}, {160, 200}, {200, 240}, > > + {240, 320}, {320, 390}, {390, 450}, {450, 510}, {510, 560}, > > + {560, 640}, {640, 690}, {690, 770}, {770, 870}, {870, 950}, > > + {950, 1000}, {1000, 1200}, {1200, 1400}, {1400, 1600}, {1600, 1800}, > > + {1800, 2000}, {2000, 2200}, {2200, 2500} > > The max_rate value of band N is always equal to the min_rate value of > band N+1. Could we store one only ? > > > +}; > > + > > +static int num_tx_bands = ARRAY_SIZE(tx_bands); > > You can use ARRAY_SIZE(tx_bands) directly below and drop this. > > > + > > static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, > > struct cdns_dphy_cfg *cfg, > > struct phy_configure_opts_mipi_dphy *opts, > > @@ -232,6 +253,26 @@ static int cdns_dphy_config_from_opts(struct phy *phy, > > return 0; > > } > > > > +static int cdns_dphy_tx_get_band_ctrl(unsigned long hs_clk_rate) > > +{ > > + unsigned int rate; > > + int i; > > + > > + rate = hs_clk_rate / 1000000UL; > > + > > + if (rate < tx_bands[0].min_rate || rate >= tx_bands[num_tx_bands - 1].max_rate) > > + return -EOPNOTSUPP; > > + > > + for (i = 0; i < num_tx_bands; i++) { > > + if (rate >= tx_bands[i].min_rate && rate < tx_bands[i].max_rate) > > + return i; > > + } > > + > > + /* Unreachable. */ > > + WARN(1, "Reached unreachable code."); > > I'd drop the WARN() if it's really unreachable. > Hi Laurent, Thanks for the review! I have sent a v3, addressing all the comments Please review Regards Rahul T R > > + return -EINVAL; > > +} > > + > > static int cdns_dphy_validate(struct phy *phy, enum phy_mode mode, int submode, > > union phy_configure_opts *opts) > > { > > @@ -247,7 +288,8 @@ static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > > { > > struct cdns_dphy *dphy = phy_get_drvdata(phy); > > struct cdns_dphy_cfg cfg = { 0 }; > > - int ret; > > + int ret, band_ctrl; > > + unsigned int reg; > > > > ret = cdns_dphy_config_from_opts(phy, &opts->mipi_dphy, &cfg); > > if (ret) > > @@ -276,6 +318,14 @@ static int cdns_dphy_configure(struct phy *phy, union phy_configure_opts *opts) > > */ > > cdns_dphy_set_pll_cfg(dphy, &cfg); > > > > + band_ctrl = cdns_dphy_tx_get_band_ctrl(opts->mipi_dphy.hs_clk_rate); > > + if (band_ctrl < 0) > > + return band_ctrl; > > + > > + reg = FIELD_PREP(DPHY_BAND_CFG_LEFT_BAND, band_ctrl) | > > + FIELD_PREP(DPHY_BAND_CFG_RIGHT_BAND, band_ctrl); > > + writel(reg, dphy->regs + DPHY_BAND_CFG); > > + > > return 0; > > } > > > > -- > Regards, > > Laurent Pinchart