From: "Clément Léger" <clement.leger@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Lizhi Hou" <lizhi.hou@xilinx.com>,
"Allan Nielsen" <allan.nielsen@microchip.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Steen Hegelund" <steen.hegelund@microchip.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Rob Herring" <robh@kernel.org>
Subject: [PATCH v1 1/2] of: base: populate of_root node if not set
Date: Thu, 23 Jun 2022 12:50:43 +0200 [thread overview]
Message-ID: <20220623105044.152832-2-clement.leger@bootlin.com> (raw)
In-Reply-To: <20220623105044.152832-1-clement.leger@bootlin.com>
When enabling CONFIG_OF on a platform where of_root is not populated by
firmware, we end up without a root node. In order to apply overlays and
create subnodes of the root node, we need one. Create this root node
by unflattening an empty builtin dtb with of_fdt_unflatten().
Co-developed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
drivers/of/Makefile | 2 +-
drivers/of/base.c | 18 ++++++++++++++++--
drivers/of/empty_root.dts | 6 ++++++
3 files changed, 23 insertions(+), 3 deletions(-)
create mode 100644 drivers/of/empty_root.dts
diff --git a/drivers/of/Makefile b/drivers/of/Makefile
index e0360a44306e..ce56c8b95c83 100644
--- a/drivers/of/Makefile
+++ b/drivers/of/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-obj-y = base.o device.o platform.o property.o
+obj-y = base.o empty_root.dtb.o device.o platform.o property.o
obj-$(CONFIG_OF_KOBJ) += kobj.o
obj-$(CONFIG_OF_DYNAMIC) += dynamic.o
obj-$(CONFIG_OF_FLATTREE) += fdt.o
diff --git a/drivers/of/base.c b/drivers/of/base.c
index d4f98c8469ed..43e0f027a49c 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -22,6 +22,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_fdt.h>
#include <linux/of_graph.h>
#include <linux/spinlock.h>
#include <linux/slab.h>
@@ -163,6 +164,8 @@ void __of_phandle_cache_inv_entry(phandle handle)
phandle_cache[handle_hash] = NULL;
}
+extern const char __dtb_empty_root_begin[];
+
void __init of_core_init(void)
{
struct device_node *np;
@@ -176,6 +179,18 @@ void __init of_core_init(void)
pr_err("failed to register existing nodes\n");
return;
}
+
+ if (!of_root) {
+ void *dt;
+ const unsigned long *fdt = (const unsigned long *)
+ __dtb_empty_root_begin;
+ dt = of_fdt_unflatten_tree(fdt, NULL, &of_root);
+ if (!dt) {
+ pr_err("Failed to setup empty root dt\n");
+ return;
+ }
+ }
+
for_each_of_allnodes(np) {
__of_attach_node_sysfs(np);
if (np->phandle && !phandle_cache[of_phandle_cache_hash(np->phandle)])
@@ -184,8 +199,7 @@ void __init of_core_init(void)
mutex_unlock(&of_mutex);
/* Symlink in /proc as required by userspace ABI */
- if (of_root)
- proc_symlink("device-tree", NULL, "/sys/firmware/devicetree/base");
+ proc_symlink("device-tree", NULL, "/sys/firmware/devicetree/base");
}
static struct property *__of_find_property(const struct device_node *np,
diff --git a/drivers/of/empty_root.dts b/drivers/of/empty_root.dts
new file mode 100644
index 000000000000..cf9e97a60f48
--- /dev/null
+++ b/drivers/of/empty_root.dts
@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/dts-v1/;
+
+/ {
+
+};
--
2.36.1
next prev parent reply other threads:[~2022-06-23 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 10:50 [PATCH v1 0/2] of: populate of_root node if not set Clément Léger
2022-06-23 10:50 ` Clément Léger [this message]
2022-06-23 23:15 ` [PATCH v1 1/2] of: base: " Frank Rowand
2022-06-24 1:01 ` Frank Rowand
2022-06-24 3:52 ` Frank Rowand
2022-06-24 12:04 ` Clément Léger
2022-06-23 10:50 ` [PATCH v1 2/2] of: unittest: remove check for of_root Clément Léger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623105044.152832-2-clement.leger@bootlin.com \
--to=clement.leger@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).