From: "Clément Léger" <clement.leger@bootlin.com>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"Lizhi Hou" <lizhi.hou@xilinx.com>,
"Allan Nielsen" <allan.nielsen@microchip.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>,
"Steen Hegelund" <steen.hegelund@microchip.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: [PATCH v1 2/2] of: unittest: remove check for of_root
Date: Thu, 23 Jun 2022 12:50:44 +0200 [thread overview]
Message-ID: <20220623105044.152832-3-clement.leger@bootlin.com> (raw)
In-Reply-To: <20220623105044.152832-1-clement.leger@bootlin.com>
Now that of_root node is always populated in of_core_init(), remove
this manual tree creation and assume that the root node always exists.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
---
drivers/of/unittest.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 7f6bba18c515..a787d212c0f6 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1469,16 +1469,6 @@ static int __init unittest_data_add(void)
return -EINVAL;
}
- if (!of_root) {
- of_root = unittest_data_node;
- for_each_of_allnodes(np)
- __of_attach_node_sysfs(np);
- of_aliases = of_find_node_by_path("/aliases");
- of_chosen = of_find_node_by_path("/chosen");
- of_overlay_mutex_unlock();
- return 0;
- }
-
EXPECT_BEGIN(KERN_INFO,
"Duplicate name in testcase-data, renamed to \"duplicate-name#1\"");
--
2.36.1
prev parent reply other threads:[~2022-06-23 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 10:50 [PATCH v1 0/2] of: populate of_root node if not set Clément Léger
2022-06-23 10:50 ` [PATCH v1 1/2] of: base: " Clément Léger
2022-06-23 23:15 ` Frank Rowand
2022-06-24 1:01 ` Frank Rowand
2022-06-24 3:52 ` Frank Rowand
2022-06-24 12:04 ` Clément Léger
2022-06-23 10:50 ` Clément Léger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623105044.152832-3-clement.leger@bootlin.com \
--to=clement.leger@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).