From: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
stanimir.varbanov@linaro.org, laurent.pinchart@ideasonboard.com,
tomi.valkeinen@ideasonboard.com, robh+dt@kernel.org,
nicolas@ndufresne.ca, alexander.stein@ew.tq-group.com
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v6 08/14] vivid: add pixel_array test control
Date: Thu, 23 Jun 2022 16:31:09 +0200 [thread overview]
Message-ID: <20220623143115.3185297-9-xavier.roumegue@oss.nxp.com> (raw)
In-Reply-To: <20220623143115.3185297-1-xavier.roumegue@oss.nxp.com>
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This control will change dimensions according to the source resolution.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---
drivers/media/test-drivers/vivid/vivid-core.h | 1 +
drivers/media/test-drivers/vivid/vivid-ctrls.c | 14 ++++++++++++++
drivers/media/test-drivers/vivid/vivid-vid-cap.c | 4 ++++
3 files changed, 19 insertions(+)
diff --git a/drivers/media/test-drivers/vivid/vivid-core.h b/drivers/media/test-drivers/vivid/vivid-core.h
index 176b72cb143b..e7b23ebc705e 100644
--- a/drivers/media/test-drivers/vivid/vivid-core.h
+++ b/drivers/media/test-drivers/vivid/vivid-core.h
@@ -227,6 +227,7 @@ struct vivid_dev {
struct v4l2_ctrl *bitmask;
struct v4l2_ctrl *int_menu;
struct v4l2_ctrl *ro_int32;
+ struct v4l2_ctrl *pixel_array;
struct v4l2_ctrl *test_pattern;
struct v4l2_ctrl *colorspace;
struct v4l2_ctrl *rgb_range_cap;
diff --git a/drivers/media/test-drivers/vivid/vivid-ctrls.c b/drivers/media/test-drivers/vivid/vivid-ctrls.c
index 7267892dc18a..c46986519bee 100644
--- a/drivers/media/test-drivers/vivid/vivid-ctrls.c
+++ b/drivers/media/test-drivers/vivid/vivid-ctrls.c
@@ -35,6 +35,7 @@
#define VIVID_CID_AREA (VIVID_CID_CUSTOM_BASE + 11)
#define VIVID_CID_RO_INTEGER (VIVID_CID_CUSTOM_BASE + 12)
#define VIVID_CID_U32_DYN_ARRAY (VIVID_CID_CUSTOM_BASE + 13)
+#define VIVID_CID_U8_PIXEL_ARRAY (VIVID_CID_CUSTOM_BASE + 14)
#define VIVID_CID_VIVID_BASE (0x00f00000 | 0xf000)
#define VIVID_CID_VIVID_CLASS (0x00f00000 | 1)
@@ -227,6 +228,18 @@ static const struct v4l2_ctrl_config vivid_ctrl_u8_4d_array = {
.dims = { 2, 3, 4, 5 },
};
+static const struct v4l2_ctrl_config vivid_ctrl_u8_pixel_array = {
+ .ops = &vivid_user_gen_ctrl_ops,
+ .id = VIVID_CID_U8_PIXEL_ARRAY,
+ .name = "U8 Pixel Array",
+ .type = V4L2_CTRL_TYPE_U8,
+ .def = 0x80,
+ .min = 0x00,
+ .max = 0xff,
+ .step = 1,
+ .dims = { 640, 360 },
+};
+
static const char * const vivid_ctrl_menu_strings[] = {
"Menu Item 0 (Skipped)",
"Menu Item 1",
@@ -1629,6 +1642,7 @@ int vivid_create_controls(struct vivid_dev *dev, bool show_ccs_cap,
v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_dyn_array, NULL);
v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u16_matrix, NULL);
v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u8_4d_array, NULL);
+ dev->pixel_array = v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u8_pixel_array, NULL);
if (dev->has_vid_cap) {
/* Image Processing Controls */
diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
index b9caa4b26209..6dc4091fcabb 100644
--- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
@@ -381,6 +381,7 @@ static enum tpg_pixel_aspect vivid_get_pixel_aspect(const struct vivid_dev *dev)
void vivid_update_format_cap(struct vivid_dev *dev, bool keep_controls)
{
struct v4l2_bt_timings *bt = &dev->dv_timings_cap[dev->input].bt;
+ u32 dims[V4L2_CTRL_MAX_DIMS] = {};
unsigned size;
u64 pixelclock;
@@ -459,6 +460,9 @@ void vivid_update_format_cap(struct vivid_dev *dev, bool keep_controls)
tpg_s_video_aspect(&dev->tpg, vivid_get_video_aspect(dev));
tpg_s_pixel_aspect(&dev->tpg, vivid_get_pixel_aspect(dev));
tpg_update_mv_step(&dev->tpg);
+ dims[0] = dev->src_rect.width;
+ dims[1] = dev->src_rect.height;
+ v4l2_ctrl_modify_dimensions(dev->pixel_array, dims);
}
/* Map the field to something that is valid for the current input */
--
2.36.1
next prev parent reply other threads:[~2022-06-23 14:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 14:31 [PATCH v6 00/14] i.MX8MP DW100 dewarper driver Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 01/14] videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY Xavier Roumegue
2022-07-08 9:58 ` Laurent Pinchart
2022-06-23 14:31 ` [PATCH v6 02/14] v4l2-ctrls: add support for dynamically allocated arrays Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 03/14] vivid: add dynamic array test control Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 04/14] v4l2-ctrls: allocate space for arrays Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 05/14] v4l2-ctrls: alloc arrays in ctrl_ref Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 06/14] v4l2-ctrls: add v4l2_ctrl_modify_dimensions Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 07/14] v4l2-ctrls: add event Xavier Roumegue
2022-06-23 14:31 ` Xavier Roumegue [this message]
2022-06-23 14:31 ` [PATCH v6 09/14] media: Documentation: dw100: Add user documentation for the DW100 driver Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 10/14] media: v4l: uapi: Add user control base for DW100 controls Xavier Roumegue
2022-06-23 14:31 ` [PATCH v6 11/14] media: uapi: Add a control for DW100 driver Xavier Roumegue
2022-07-08 10:50 ` Laurent Pinchart
2022-06-23 14:31 ` [PATCH v6 12/14] media: dt-bindings: media: Add i.MX8MP DW100 binding Xavier Roumegue
2022-06-30 21:57 ` Rob Herring
2022-06-23 14:31 ` [PATCH v6 13/14] media: dw100: Add i.MX8MP dw100 dewarper driver Xavier Roumegue
2022-07-08 10:12 ` Hans Verkuil
2022-07-08 12:03 ` Laurent Pinchart
2022-07-08 10:48 ` Ezequiel Garcia
2022-06-23 14:31 ` [PATCH v6 14/14] media: MAINTAINERS: add entry for i.MX8MP DW100 v4l2 mem2mem driver Xavier Roumegue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623143115.3185297-9-xavier.roumegue@oss.nxp.com \
--to=xavier.roumegue@oss.nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).