From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>,
Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 08/10] iio: adc: mcp3911: add support for phase
Date: Thu, 23 Jun 2022 19:08:42 +0200 [thread overview]
Message-ID: <20220623170844.2189814-8-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <20220623170844.2189814-1-marcus.folkesson@gmail.com>
The MCP3911 incorporates a phase delay generator,
which ensures that the two ADCs are converting the
inputs with a fixed delay between them.
Expose it to userspace.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/iio/adc/mcp3911.c | 25 ++++++++++++++++++++++++-
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c
index 9e365947d285..aefc5eac874c 100644
--- a/drivers/iio/adc/mcp3911.c
+++ b/drivers/iio/adc/mcp3911.c
@@ -155,6 +155,17 @@ static int mcp3911_read_raw(struct iio_dev *indio_dev,
ret = IIO_VAL_INT;
break;
+
+ case IIO_CHAN_INFO_PHASE:
+ ret = mcp3911_read(adc,
+ MCP3911_REG_PHASE, val, 2);
+ if (ret)
+ goto out;
+
+ *val = sign_extend32(*val, 12);
+ ret = IIO_VAL_INT;
+ break;
+
case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
ret = mcp3911_read(adc,
MCP3911_REG_CONFIG, val, 2);
@@ -225,6 +236,16 @@ static int mcp3911_write_raw(struct iio_dev *indio_dev,
MCP3911_STATUSCOM_EN_OFFCAL, 2);
break;
+ case IIO_CHAN_INFO_PHASE:
+ if (val2 != 0 || val > 0xfff) {
+ ret = -EINVAL;
+ goto out;
+ }
+
+ /* Write phase */
+ ret = mcp3911_write(adc, MCP3911_REG_PHASE, val,
+ 2);
+ break;
case IIO_CHAN_INFO_OVERSAMPLING_RATIO:
switch (val) {
case 4096:
@@ -273,7 +294,9 @@ static int mcp3911_write_raw(struct iio_dev *indio_dev,
.channel = idx, \
.scan_index = idx, \
.scan_index = idx, \
- .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO), \
+ .info_mask_shared_by_type = \
+ BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO)| \
+ BIT(IIO_CHAN_INFO_PHASE), \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
BIT(IIO_CHAN_INFO_OFFSET) | \
BIT(IIO_CHAN_INFO_SCALE), \
--
2.36.1
next prev parent reply other threads:[~2022-06-23 17:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 17:08 [PATCH 01/10] iio: adc: mcp3911: correct "microchip,device-addr" property Marcus Folkesson
2022-06-23 17:08 ` [PATCH 02/10] iio: adc: mcp3911: use resource-managed version of iio_device_register Marcus Folkesson
2022-06-23 19:01 ` Andy Shevchenko
2022-06-24 6:29 ` Marcus Folkesson
2022-06-25 11:24 ` Jonathan Cameron
2022-06-28 12:01 ` Andy Shevchenko
2022-06-23 17:08 ` [PATCH 03/10] iio: adc: mcp3911: add support for buffers Marcus Folkesson
2022-06-23 17:08 ` [PATCH 04/10] iio: adc: mcp3911: add support for interrupts Marcus Folkesson
2022-06-23 19:04 ` Andy Shevchenko
2022-06-24 12:01 ` Marcus Folkesson
2022-06-23 17:08 ` [PATCH 05/10] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry Marcus Folkesson
2022-06-24 9:54 ` Krzysztof Kozlowski
2022-06-24 12:10 ` Marcus Folkesson
2022-06-24 17:26 ` Rob Herring
2022-06-23 17:08 ` [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio Marcus Folkesson
2022-06-23 19:20 ` Andy Shevchenko
2022-06-24 12:09 ` Marcus Folkesson
2022-06-28 11:56 ` Andy Shevchenko
2022-06-23 17:08 ` [PATCH 07/10] iio: adc: mcp3911: use correct formula for AD conversion Marcus Folkesson
2022-06-23 17:08 ` Marcus Folkesson [this message]
2022-06-23 19:07 ` [PATCH 08/10] iio: adc: mcp3911: add support for phase Andy Shevchenko
2022-06-24 12:02 ` Marcus Folkesson
2022-06-25 11:33 ` Jonathan Cameron
2022-06-23 17:08 ` [PATCH 09/10] iio: adc: mcp3911: make use of the sign bit Marcus Folkesson
2022-06-23 17:08 ` [PATCH 10/10] iio: adc: mcp3911: add support to set PGA Marcus Folkesson
2022-06-23 17:26 ` Marcus Folkesson
2022-06-23 19:15 ` Andy Shevchenko
2022-06-24 12:05 ` Marcus Folkesson
2022-06-23 18:59 ` [PATCH 01/10] iio: adc: mcp3911: correct "microchip,device-addr" property Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623170844.2189814-8-marcus.folkesson@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).