From: "Clément Léger" <clement.leger@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>
Cc: "Clément Léger" <clement.leger@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next v9 01/16] net: dsa: allow port_bridge_join() to override extack message
Date: Fri, 24 Jun 2022 16:39:46 +0200 [thread overview]
Message-ID: <20220624144001.95518-2-clement.leger@bootlin.com> (raw)
In-Reply-To: <20220624144001.95518-1-clement.leger@bootlin.com>
Some drivers might report that they are unable to bridge ports by
returning -EOPNOTSUPP, but still wants to override extack message.
In order to do so, in dsa_slave_changeupper(), if port_bridge_join()
returns -EOPNOTSUPP, check if extack message is set and if so, do not
override it.
Signed-off-by: Clément Léger <clement.leger@bootlin.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
net/dsa/slave.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 2e1ac638d135..509b98dd9954 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -2460,8 +2460,9 @@ static int dsa_slave_changeupper(struct net_device *dev,
if (!err)
dsa_bridge_mtu_normalization(dp);
if (err == -EOPNOTSUPP) {
- NL_SET_ERR_MSG_MOD(extack,
- "Offloading not supported");
+ if (!extack->_msg)
+ NL_SET_ERR_MSG_MOD(extack,
+ "Offloading not supported");
err = 0;
}
err = notifier_from_errno(err);
--
2.36.1
next prev parent reply other threads:[~2022-06-24 14:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 14:39 [PATCH net-next v9 00/16] add support for Renesas RZ/N1 ethernet subsystem devices Clément Léger
2022-06-24 14:39 ` Clément Léger [this message]
2022-06-24 14:39 ` [PATCH net-next v9 02/16] net: dsa: add support for ethtool get_rmon_stats() Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 03/16] net: dsa: add Renesas RZ/N1 switch tag driver Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 04/16] dt-bindings: net: pcs: add bindings for Renesas RZ/N1 MII converter Clément Léger
2022-06-29 14:38 ` Geert Uytterhoeven
2022-06-24 14:39 ` [PATCH net-next v9 05/16] net: pcs: add Renesas MII converter driver Clément Léger
2022-06-25 2:35 ` Florian Fainelli
2022-06-28 16:42 ` Russell King (Oracle)
2022-06-28 16:49 ` Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 06/16] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch Clément Léger
2022-06-28 15:37 ` Geert Uytterhoeven
2022-06-28 16:18 ` Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 07/16] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver Clément Léger
2022-06-25 2:37 ` Florian Fainelli
2022-06-24 14:39 ` [PATCH net-next v9 08/16] net: dsa: rzn1-a5psw: add statistics support Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 09/16] net: dsa: rzn1-a5psw: add FDB support Clément Léger
2022-06-25 2:37 ` Florian Fainelli
2022-06-24 14:39 ` [PATCH net-next v9 10/16] dt-bindings: net: snps,dwmac: add "power-domains" property Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 11/16] dt-bindings: net: snps,dwmac: add "renesas,rzn1" compatible Clément Léger
2022-06-24 14:39 ` [PATCH net-next v9 12/16] ARM: dts: r9a06g032: describe MII converter Clément Léger
2022-06-25 2:38 ` Florian Fainelli
2022-06-28 15:28 ` Geert Uytterhoeven
2022-06-24 14:39 ` [PATCH net-next v9 13/16] ARM: dts: r9a06g032: describe GMAC2 Clément Léger
2022-06-25 2:38 ` Florian Fainelli
2022-06-28 15:30 ` Geert Uytterhoeven
2022-06-24 14:39 ` [PATCH net-next v9 14/16] ARM: dts: r9a06g032: describe switch Clément Léger
2022-06-25 2:39 ` Florian Fainelli
2022-06-28 15:31 ` Geert Uytterhoeven
2022-06-24 14:40 ` [PATCH net-next v9 15/16] ARM: dts: r9a06g032-rzn1d400-db: add switch description Clément Léger
2022-06-25 2:40 ` Florian Fainelli
2022-06-28 15:34 ` Geert Uytterhoeven
2022-06-28 16:20 ` Clément Léger
2022-06-24 14:40 ` [PATCH net-next v9 16/16] MAINTAINERS: add Renesas RZ/N1 switch related driver entry Clément Léger
2022-06-24 21:43 ` [PATCH net-next v9 00/16] add support for Renesas RZ/N1 ethernet subsystem devices Vladimir Oltean
2022-06-27 7:38 ` Clément Léger
2022-06-27 10:50 ` patchwork-bot+netdevbpf
2022-06-27 11:11 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624144001.95518-2-clement.leger@bootlin.com \
--to=clement.leger@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jimmy.lalande@se.com \
--cc=joabreu@synopsys.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).