From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DA9C433EF for ; Sat, 25 Jun 2022 11:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232514AbiFYLVN (ORCPT ); Sat, 25 Jun 2022 07:21:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232077AbiFYLVN (ORCPT ); Sat, 25 Jun 2022 07:21:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5162B25EA1; Sat, 25 Jun 2022 04:21:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D6B32611BD; Sat, 25 Jun 2022 11:21:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DFC6C3411C; Sat, 25 Jun 2022 11:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656156071; bh=jts758vb4qnwO0h43mTFUgp8LuWd6wEdmuDOA8P+7OI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fvpx5nKikCX0t4WACCyRIKMFM81YWwpflTM9Zul2WPnplCP/WLO+3YGyR6jZocxTN B2rWrckQoeTGkehBB2jgk8IOEMQtCTjDCCMtqm1qgOOsZTe+mLVi5ofKdkeg9Kfp5c +r9YRdLl/74Vi+RdYPiWVHXSC4LCC82ShJSEU/wkjigmh1Bp5kPgVYdpCzrmbugnXD beMHjkxlRabdJXD58FMNlfISAQtaqERBYgU8M36G8kWHAnG55V4Mj4HnIAJy/3Vjzt rhG5/TnyLXlxeOG31Nk1TGm3YEjaNyRgiKFWvO4vieR9DtfxYkk8PYMjL49jtyqiAP UvzqUGaTBGOQw== Date: Sat, 25 Jun 2022 12:30:37 +0100 From: Jonathan Cameron To: Marcus Folkesson Cc: Kent Gustavsson , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/10] iio: adc: mcp3911: use resource-managed version of iio_device_register Message-ID: <20220625123037.0d907e4c@jic23-huawei> In-Reply-To: <20220625103853.2470346-2-marcus.folkesson@gmail.com> References: <20220625103853.2470346-1-marcus.folkesson@gmail.com> <20220625103853.2470346-2-marcus.folkesson@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 25 Jun 2022 12:38:45 +0200 Marcus Folkesson wrote: > Keep using managed resources as much as possible. > > Signed-off-by: Marcus Folkesson See explanation on why this is wrong sent to the v1 version of this patch. It's a fiddly and not always well understood area (here be dragons!). Jonathan > --- > > Notes: > v2: > - No changes > > drivers/iio/adc/mcp3911.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c > index c5a0f19d7834..25a235cce56c 100644 > --- a/drivers/iio/adc/mcp3911.c > +++ b/drivers/iio/adc/mcp3911.c > @@ -312,7 +312,7 @@ static int mcp3911_probe(struct spi_device *spi) > > mutex_init(&adc->lock); > > - ret = iio_device_register(indio_dev); > + ret = devm_iio_device_register(&adc->spi->dev, indio_dev); > if (ret) > goto clk_disable; > > @@ -332,8 +332,6 @@ static void mcp3911_remove(struct spi_device *spi) > struct iio_dev *indio_dev = spi_get_drvdata(spi); > struct mcp3911 *adc = iio_priv(indio_dev); > > - iio_device_unregister(indio_dev); > - > clk_disable_unprepare(adc->clki); > if (adc->vref) > regulator_disable(adc->vref);