From: Rob Herring <robh@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] dt-bindings: phy: qcom,hdmi-phy-qmp: add clock-cells and XO clock
Date: Mon, 27 Jun 2022 11:17:56 -0600 [thread overview]
Message-ID: <20220627171756.GA2610798-robh@kernel.org> (raw)
In-Reply-To: <20220620010300.1532713-2-dmitry.baryshkov@linaro.org>
On Mon, Jun 20, 2022 at 04:02:58AM +0300, Dmitry Baryshkov wrote:
> As the QMP HDMI PHY is a clock provider, add constant #clock-cells
> property. For the compatibility with older DTs the property is not
> marked as required. Also add the XO clock to the list of the clocks used
> by the driver.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
Doesn't apply, so no checks ran.
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml
> index eea2e02678ed..41e6492d4a0f 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml
> @@ -28,12 +28,14 @@ properties:
> - const: hdmi_phy
>
> clocks:
> - maxItems: 2
> + minItems: 2
> + maxItems: 3
>
> clock-names:
> items:
> - const: iface
> - const: ref
> + - const: xo
minItems: 2
>
> power-domains:
> maxItems: 1
> @@ -44,6 +46,9 @@ properties:
> vddio-supply:
> description: phandle to VDD I/O supply regulator
>
> + '#clock-cells':
> + const: 0
> +
> '#phy-cells':
> const: 0
>
> @@ -75,9 +80,12 @@ examples:
> "hdmi_phy";
>
> clocks = <&mmcc 116>,
> - <&gcc 214>;
> + <&gcc 214>,
> + <&xo_board>;
> clock-names = "iface",
> - "ref";
> + "ref",
> + "xo";
> + #clock-cells = <0>;
> #phy-cells = <0>;
>
> vddio-supply = <&vreg_l12a_1p8>;
> --
> 2.35.1
>
>
next prev parent reply other threads:[~2022-06-27 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 1:02 [PATCH v2 0/3] drm/msm/hdmi: turn MSM8996 HDMI PHY into OF clock provider Dmitry Baryshkov
2022-06-20 1:02 ` [PATCH v2 1/3] dt-bindings: phy: qcom,hdmi-phy-qmp: add clock-cells and XO clock Dmitry Baryshkov
2022-06-20 8:44 ` Krzysztof Kozlowski
2022-06-27 17:17 ` Rob Herring [this message]
2022-06-27 17:51 ` Dmitry Baryshkov
2022-06-20 1:02 ` [PATCH v2 2/3] drm/msm/hdmi: make hdmi_phy_8996 OF clk provider Dmitry Baryshkov
2022-06-20 1:03 ` [PATCH v2 3/3] arm64: dts: qcom: msm8996: add #clock-cells and XO clock to the HDMI PHY node Dmitry Baryshkov
2022-06-20 8:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627171756.GA2610798-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).