From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4EC7C433EF for ; Mon, 27 Jun 2022 22:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242353AbiF0WBT (ORCPT ); Mon, 27 Jun 2022 18:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242227AbiF0V7j (ORCPT ); Mon, 27 Jun 2022 17:59:39 -0400 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27B411CB2E; Mon, 27 Jun 2022 14:57:23 -0700 (PDT) Received: by mail-io1-f42.google.com with SMTP id k15so11056093iok.5; Mon, 27 Jun 2022 14:57:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GByTRovhreeBVcySF/6td5WnIoeUKJH8EVN0W2QYucY=; b=gKrkD2reMY/KvDMNmxPtPyaMIMGlcP6HoJqXkBmqHnn04hPHz2i/8r1TDiliJO/sbr 0dz7kye4gnFG/XdWBTxshmvciOpz7YwE3JP8Is/CqQ3CyqgGsDjCoRC7/ZwAlLKwv2mc WtOL+AgSnzAgrkOCrJ2iGDj9k+FYRQvt7B/78WKbbVxmWirNvoalQBdYRQ5ZBdJp6nll tksE+q1YLZJHe8Rt9hV2RQOcCGCz0i+6vdWE2GuOvhbvzVAgX/78MZh8mpZj6XOxQSHF b5S+IRvb65Hi0tbtbcjSeOEEKr3Uq2F4IGlEueK3JiXPPvIEvRn7Y21xpF+7eZHzOXRM bkTg== X-Gm-Message-State: AJIora+KgyI+qr/WxduJ+t/AmOf4fJHsIdq42z9VHgIzHWuCEQ+vbTV5 44rac9ISt2UGdSDKbqw5aKQckFNjyQ== X-Google-Smtp-Source: AGRyM1uMna/0ZhSmeNlsBB7VjCYVusraceaPQMcCVlLmwH+8k6NuzZefhWbziP1Ag2HjwKDfsksPdg== X-Received: by 2002:a02:c619:0:b0:339:bc5a:205e with SMTP id i25-20020a02c619000000b00339bc5a205emr9510427jan.184.1656367042314; Mon, 27 Jun 2022 14:57:22 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id h8-20020a92d848000000b002da9f82c703sm956479ilq.5.2022.06.27.14.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jun 2022 14:57:21 -0700 (PDT) Received: (nullmailer pid 3036027 invoked by uid 1000); Mon, 27 Jun 2022 21:57:20 -0000 Date: Mon, 27 Jun 2022 15:57:20 -0600 From: Rob Herring To: Doug Anderson Cc: Stephen Boyd , Benson Leung , LKML , patches@lists.linux.dev, Krzysztof Kozlowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , chrome-platform@lists.linux.dev, Guenter Roeck , Craig Hesling , Tom Hughes , Alexandru M Stan , Tzung-Bi Shih , Matthias Kaehlcke , Lee Jones Subject: Re: [PATCH v6 2/2] dt-bindings: cros-ec: Add ChromeOS fingerprint binding Message-ID: <20220627215720.GA3004792-robh@kernel.org> References: <20220614195144.2794796-1-swboyd@chromium.org> <20220614195144.2794796-3-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 14, 2022 at 03:41:25PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Jun 14, 2022 at 12:51 PM Stephen Boyd wrote: > > > > Add a binding to describe the fingerprint processor found on Chromebooks > > with a fingerprint sensor. Previously we've been describing this with > > the google,cros-ec-spi binding but it lacks gpio and regulator control > > used during firmware flashing. > > > > Cc: Rob Herring > > Cc: Krzysztof Kozlowski > > Cc: > > Cc: > > Cc: Guenter Roeck > > Cc: Douglas Anderson > > Cc: Craig Hesling > > Cc: Tom Hughes > > Cc: Alexandru M Stan > > Cc: Tzung-Bi Shih > > Cc: Matthias Kaehlcke > > Cc: Benson Leung > > Cc: Lee Jones > > Signed-off-by: Stephen Boyd > > --- > > .../bindings/chrome/google,cros-ec-fp.yaml | 97 +++++++++++++++++++ > > .../bindings/mfd/google,cros-ec.yaml | 9 ++ > > 2 files changed, 106 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > > > diff --git a/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > new file mode 100644 > > index 000000000000..48c02bd4585c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/chrome/google,cros-ec-fp.yaml > > @@ -0,0 +1,97 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/chrome/google,cros-ec-fp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ChromeOS Embedded Fingerprint Controller > > + > > +description: > > + Google's ChromeOS embedded fingerprint controller is a device which > > + implements fingerprint functionality such as unlocking a Chromebook > > + without typing a password. > > + > > +maintainers: > > + - Tom Hughes > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + const: google,cros-ec-spi > > + required: > > + - compatible > > + - boot0-gpios > > I've never personally used "select" before and I'm not sure where it's > documented. Documentation/devicetree/bindings/writing-schema.rst > Without knowing anything, it seems weird to me that in > this file we're matching against a compatible that's not > google,cros-ec-fp. Randomly grabbing some other example that's similar > (panel-lvds.yaml) looks more like what I would have expected. AKA in > this file: > > select: > properties: > compatible: > contains: > const: google,cros-ec-fp > required: > - compatible > > ...and then in the other file: > > select: > properties: > compatible: > contains: > const: google,cros-ec-spi What about i2c and rpmsg variants? > not: > properties: > compatible: > contains: > const: google,cros-ec-fp > required: > - compatible That is what is needed assuming the binding stands as-is. Otherwise, boot0-gpios erroneously present or missing will give unexpected results. If we were starting from scratch, I would say you should just drop 'google,cros-ec-spi' from this binding. But I guess you want to preserve compatibility here. In that case, I think all this should be added to the existing doc with an if/then schema for conditional parts. That also avoids defining the common properties twice or moving them to a common, shared schema. Rob