From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Eugen Hristev <eugen.hristev@microchip.com>,
Hugues Fruchet <hugues.fruchet@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
Date: Mon, 27 Jun 2022 16:16:08 -0600 [thread overview]
Message-ID: <20220627221608.GA3060504-robh@kernel.org> (raw)
In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com>
On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
>
> - Go back to PARALLEL
>
> Changes since v1:
>
> - Rename PARALLEL to BT601
> ---
> .../devicetree/bindings/display/bridge/analogix,anx7625.yaml | 1 +
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 3 ++-
> Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml | 3 ++-
> .../devicetree/bindings/media/marvell,mmp2-ccic.yaml | 3 ++-
> Documentation/devicetree/bindings/media/microchip,xisc.yaml | 3 ++-
> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 4 +++-
> 6 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> index 39395ea8c318..edde4201116f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml
> @@ -104,6 +104,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c2 {
> #address-cells = <1>;
> @@ -124,7 +125,7 @@ examples:
> remote-endpoint = <&csi2a_ep>;
> link-frequencies = /bits/ 64 <199200000 210000000
> 499200000>;
> - bus-type = <4>;
> + bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> index 44529425ce3a..161e6d598e1c 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml
> @@ -105,6 +105,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> i2c0 {
> #address-cells = <1>;
> @@ -118,7 +119,7 @@ examples:
>
> port {
> ov772x_0: endpoint {
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> vsync-active = <0>;
> hsync-active = <0>;
> pclk-sample = <0>;
> diff --git a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> index b39b84c5f012..0e3478551e13 100644
> --- a/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> +++ b/Documentation/devicetree/bindings/media/marvell,mmp2-ccic.yaml
> @@ -68,6 +68,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/clock/marvell,mmp2.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/power/marvell,mmp2.h>
>
> camera@d420a000 {
> @@ -83,7 +84,7 @@ examples:
> port {
> camera0_0: endpoint {
> remote-endpoint = <&ov7670_0>;
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> hsync-active = <1>; /* Active high */
> vsync-active = <1>; /* Active high */
> pclk-sample = <0>; /* Falling */
> diff --git a/Documentation/devicetree/bindings/media/microchip,xisc.yaml b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> index 8b37fccab5e2..25f5f79d40ce 100644
> --- a/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> +++ b/Documentation/devicetree/bindings/media/microchip,xisc.yaml
> @@ -106,6 +106,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/at91.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/media/video-interfaces.h>
>
> xisc: xisc@e1408000 {
> compatible = "microchip,sama7g5-isc";
> @@ -118,7 +119,7 @@ examples:
>
> port {
> xisc_in: endpoint {
> - bus-type = <5>; /* Parallel */
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> remote-endpoint = <&csi2dc_out>;
> hsync-active = <1>;
> vsync-active = <1>;
> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> index 9c1262a276b5..285c6075950a 100644
> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml
> @@ -90,7 +90,9 @@ examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/stm32mp1-clks.h>
> + #include <dt-bindings/media/video-interfaces.h>
> #include <dt-bindings/reset/stm32mp1-resets.h>
> + #
?
In any case,
Reviewed-by: Rob Herring <robh@kernel.org>
> dcmi: dcmi@4c006000 {
> compatible = "st,stm32-dcmi";
> reg = <0x4c006000 0x400>;
> @@ -104,7 +106,7 @@ examples:
> port {
> dcmi_0: endpoint {
> remote-endpoint = <&ov5640_0>;
> - bus-type = <5>;
> + bus-type = <MEDIA_BUS_TYPE_PARALLEL>;
> bus-width = <8>;
> hsync-active = <0>;
> vsync-active = <0>;
> --
> Regards,
>
> Laurent Pinchart
>
>
next prev parent reply other threads:[~2022-06-27 22:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 22:14 [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types Laurent Pinchart
2022-06-15 22:14 ` [PATCH v3 1/6] dt-bindings: media: " Laurent Pinchart
2022-06-27 22:14 ` Rob Herring
2022-06-28 10:46 ` Jacopo Mondi
2022-11-17 10:02 ` Paul Elder
2022-06-15 22:14 ` [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples Laurent Pinchart
2022-06-27 22:16 ` Rob Herring [this message]
2022-06-27 23:40 ` Laurent Pinchart
2022-07-16 9:28 ` Sakari Ailus
2022-07-16 15:12 ` Laurent Pinchart
2022-11-21 21:10 ` Sakari Ailus
2022-06-15 22:14 ` [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros Laurent Pinchart
2023-01-14 15:30 ` Laurent Pinchart
2023-01-25 2:16 ` Shawn Guo
2022-06-15 22:14 ` [PATCH v3 4/6] ARM: dts: omap: " Laurent Pinchart
2023-01-14 15:37 ` Laurent Pinchart
2023-01-19 7:59 ` Tony Lindgren
2022-06-15 22:14 ` [PATCH v3 5/6] ARM: dts: renesas: " Laurent Pinchart
2022-11-18 9:27 ` Lad, Prabhakar
2023-01-14 15:26 ` Laurent Pinchart
2023-01-16 10:24 ` Geert Uytterhoeven
2023-01-16 10:38 ` Laurent Pinchart
2023-01-16 10:44 ` Geert Uytterhoeven
2023-01-16 10:49 ` Laurent Pinchart
2023-01-16 11:23 ` Geert Uytterhoeven
2022-06-15 22:14 ` [PATCH v3 6/6] ARM: dts: stm32: " Laurent Pinchart
2023-01-14 15:36 ` Laurent Pinchart
2023-01-17 10:44 ` Alexandre TORGUE
2023-01-17 11:24 ` Alexandre TORGUE
2022-07-17 6:54 ` [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types Sakari Ailus
2022-11-18 9:23 ` Paul Elder
2022-11-19 19:15 ` Laurent Pinchart
2022-11-21 10:54 ` Sakari Ailus
2022-11-21 11:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220627221608.GA3060504-robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eugen.hristev@microchip.com \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@foss.st.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).