From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2B23C43334 for ; Wed, 29 Jun 2022 07:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231994AbiF2Hbf (ORCPT ); Wed, 29 Jun 2022 03:31:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbiF2Hbf (ORCPT ); Wed, 29 Jun 2022 03:31:35 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2035635ABD; Wed, 29 Jun 2022 00:31:30 -0700 (PDT) Received: (Authenticated sender: clement.leger@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 0BB991BF211; Wed, 29 Jun 2022 07:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1656487889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MUAlH3rFjhmrOjOV0b6OevGjDLJyfHSl54JsM43oRMk=; b=p5bFqL6oNfEebvGBqtMtdm1HT21o/xzkez1UFN6wxRpJGJVWOxQcWCQa2jc/i2szAnFZBU sGFhEf45OvZwJWJVGXnUQDPikRmrUDczEus2xt0y9Vg3h9BHZJ4nPVPcM68xTUlHcyKJEe VOGhqI+5JLkp33wLRCRZ3yT9tWdMRld3sf5/lqfkxHxb+DBz3zD4D2uaOyj7UwgqXwZLbc VERzbiasLFtYMgm+kI083AnEdL005NQ3dTe5Y/YG8Yo3k7mrwS2sRxsSAPQL4fuFJmm3kY B02Sn4UxRxbw75XP3KIDBIcZDhxrRQIc1t9U50jZdlcr1+RiriO5QreQJaU4Vg== Date: Wed, 29 Jun 2022 09:30:35 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Christophe Leroy Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , Nathan Lynch , Laurent Dufour , Daniel Henrique Barboza , David Gibson , Andrew Morton , David Hildenbrand , Ohhoon Kwon , "Aneesh Kumar K.V" , YueHaibing , "devicetree@vger.kernel.org" , Steen Hegelund , "linux-kernel@vger.kernel.org" , Lizhi Hou , Allan Nielsen , Thomas Petazzoni , Bjorn Helgaas , "linuxppc-dev@lists.ozlabs.org" , Horatiu Vultur Subject: Re: [PATCH v3 5/5] powerpc/pseries: use of_property_alloc/free() and of_node_alloc() Message-ID: <20220629093035.281c8cd6@fixe.home> In-Reply-To: References: <20220620104123.341054-1-clement.leger@bootlin.com> <20220620104123.341054-6-clement.leger@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le Tue, 28 Jun 2022 17:00:45 +0000, Christophe Leroy a =C3=A9crit : > > -static int pSeries_reconfig_add_node(const char *path, struct property= *proplist) > > +static struct device_node *pSeries_reconfig_add_node(const char *path) > > { > > - struct device_node *np; > > - int err =3D -ENOMEM; > > - > > - np =3D kzalloc(sizeof(*np), GFP_KERNEL); > > - if (!np) > > - goto out_err; > > - > > - np->full_name =3D kstrdup(kbasename(path), GFP_KERNEL); > > - if (!np->full_name) > > - goto out_err; > > - > > - np->properties =3D proplist; > > - of_node_set_flag(np, OF_DYNAMIC); > > - of_node_init(np); > > + struct device_node *np, *parent; > > =20 > > - np->parent =3D pseries_of_derive_parent(path); > > - if (IS_ERR(np->parent)) { > > - err =3D PTR_ERR(np->parent); > > - goto out_err; > > + np =3D of_find_node_by_path(path) =20 >=20 > Missing ; >=20 > Did you test build ? I generally test build for powerpc but it seems like I forgot to rebuild my powerpc kernel build after this modification. It seems like only this error did not pass through the test build. I'll try to be more careful next time. Sorry for that. --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com