From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE73DC433EF for ; Wed, 29 Jun 2022 18:55:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbiF2Szy (ORCPT ); Wed, 29 Jun 2022 14:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229476AbiF2Szx (ORCPT ); Wed, 29 Jun 2022 14:55:53 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B33122AC77; Wed, 29 Jun 2022 11:55:52 -0700 (PDT) Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id DD78D6601924; Wed, 29 Jun 2022 19:55:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656528951; bh=GuaqbcYp+PIdlyYAwEfu+gsN8LZtcE7SN+Ulmy7dl7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W2NDukZrzpjsnwS/7rMZy5ACcuA7lxgFs06F1OfZj2mrxXy0apzTAeAxM5zULbXew MKqaUlDqxmfkfq/Ek+lRhq9uuhe+9ulbhdkiQ29q85Q1B8+E2fB2JBDK0K26PzkM+y CXcXLGRqYrsfbBX4++oAWMAoySib7C53BwlRr+BQm339A9SC9UPmy66fSrRdCF7ivQ 0zcLTBhRIasmZAMMDC+T0IYpIkSnU+JpS/yq1zBH3xijf0xsCOQy92GcuTJwyk5ePr Prm88EgOx1dWFkiIj8301TZ0s503/nBALuw/HnQFtFRz4qzrckE7kPBkRmetHyfLNJ K1UyfaRac3qbw== Date: Wed, 29 Jun 2022 14:55:46 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chunfeng Yun Cc: Greg Kroah-Hartman , Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2 2/4] dt-bindings: usb: mtk-xhci: Make all clocks required Message-ID: <20220629185546.z6rn7xp3ejpmaupi@notapiano> References: <20220623193702.817996-1-nfraprado@collabora.com> <20220623193702.817996-3-nfraprado@collabora.com> <93c6b7201533325cf7758637dd194a372f3c00c6.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <93c6b7201533325cf7758637dd194a372f3c00c6.camel@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jun 28, 2022 at 08:57:45AM +0800, Chunfeng Yun wrote: > Hi Nícolas, > > On Thu, 2022-06-23 at 15:37 -0400, Nícolas F. R. A. Prado wrote: > > All of the clocks listed in the binding are always wired to the XHCI > > controller hardware blocks on all SoCs. The reason some clocks were > > made > > optional in the binding was to account for the fact that depending on > > the SoC, some of the clocks might be fixed (ie not controlled by > > software). > > > > Given that the devicetree should represent the hardware, make all > > clocks > > required in the binding. Subsequent patches will make the DTS changes > > to > > specify fixed-clocks for the clocks that aren't controllable. > > > > Signed-off-by: Nícolas F. R. A. Prado > > > > --- > > > > Changes in v2: > > - Undid clock list changes that allowed middle clocks to be missing > > from > > v1 and made all clocks required instead > > - Rewrote commit message and title > > > > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 4 + > > --- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk- > > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk- > > xhci.yaml > > index 63cbc2b62d18..1444d18ef9bc 100644 > > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml > > @@ -67,7 +67,6 @@ properties: > > maxItems: 1 > > > > clocks: > > - minItems: 1 > > items: > > - description: Controller clock used by normal mode > > - description: Reference clock used by low power mode etc > > @@ -76,9 +75,8 @@ properties: > > - description: controller clock > > > > clock-names: > > - minItems: 1 > > items: > > - - const: sys_ck # required, the following ones are optional > > + - const: sys_ck > > - const: ref_ck > > - const: mcu_ck > > - const: dma_ck > > This patch causes more check warning, I prefer to leave dt-bindings > unchanged, but just fix mt8195's dts warning instead, thanks a lot Hi Chunfeng, the warnings reported by Rob's bot only happen if patches 3 and 4 aren't applied to adapt the devicetrees. They are ABI breaking changes, but I understood this as the desired solution from the discussion we had with Krzysztof on v1 [1]. I was expecting some feedback from Krzysztof or Matthias if this was an issue, but it looks like Greg already merged the patch. I'll wait a bit for some feedback and if this really was a misunderstanding I can send a revert patch. Thanks, Nícolas [1] https://lore.kernel.org/all/20220622132219.36rvznhip2egujec@notapiano/