* [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
@ 2022-07-04 13:58 Kavyasree Kotagiri
2022-07-04 14:06 ` Nicolas Ferre
2022-07-05 7:41 ` Claudiu.Beznea
0 siblings, 2 replies; 3+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-04 13:58 UTC (permalink / raw)
To: arnd, alexandre.belloni, krzysztof.kozlowski+dt, Nicolas.Ferre,
claudiu.beznea
Cc: soc, robh+dt, linux-arm-kernel, devicetree, linux-kernel,
UNGLinuxDriver
On pcb8291, Flexcom3 usart has only tx and rx pins.
Cleaningup usart3 pinctrl settings.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
v1 -> v2:
- Keep both tx and rx pins into one node.
arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
index 3c7e3a7d6f14..d56d2054c38d 100644
--- a/arch/arm/boot/dts/lan966x-pcb8291.dts
+++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
@@ -19,19 +19,9 @@ aliases {
};
&gpio {
- fc_shrd7_pins: fc_shrd7-pins {
- pins = "GPIO_49";
- function = "fc_shrd7";
- };
-
- fc_shrd8_pins: fc_shrd8-pins {
- pins = "GPIO_54";
- function = "fc_shrd8";
- };
-
- fc3_b_pins: fcb3-spi-pins {
- /* SCK, RXD, TXD */
- pins = "GPIO_51", "GPIO_52", "GPIO_53";
+ fc3_b_pins: fc3-b-pins {
+ /* RX, TX */
+ pins = "GPIO_52", "GPIO_53";
function = "fc3_b";
};
@@ -53,7 +43,7 @@ &flx3 {
status = "okay";
usart3: serial@200 {
- pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
+ pinctrl-0 = <&fc3_b_pins>;
pinctrl-names = "default";
status = "okay";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
2022-07-04 13:58 [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
@ 2022-07-04 14:06 ` Nicolas Ferre
2022-07-05 7:41 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2022-07-04 14:06 UTC (permalink / raw)
To: Kavyasree Kotagiri, arnd, alexandre.belloni,
krzysztof.kozlowski+dt, claudiu.beznea
Cc: soc, robh+dt, linux-arm-kernel, devicetree, linux-kernel,
UNGLinuxDriver
On 04/07/2022 at 15:58, Kavyasree Kotagiri wrote:
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Fine with me as well:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> v1 -> v2:
> - Keep both tx and rx pins into one node.
>
> arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..d56d2054c38d 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,9 @@ aliases {
> };
>
> &gpio {
> - fc_shrd7_pins: fc_shrd7-pins {
> - pins = "GPIO_49";
> - function = "fc_shrd7";
> - };
> -
> - fc_shrd8_pins: fc_shrd8-pins {
> - pins = "GPIO_54";
> - function = "fc_shrd8";
> - };
> -
> - fc3_b_pins: fcb3-spi-pins {
> - /* SCK, RXD, TXD */
> - pins = "GPIO_51", "GPIO_52", "GPIO_53";
> + fc3_b_pins: fc3-b-pins {
> + /* RX, TX */
> + pins = "GPIO_52", "GPIO_53";
> function = "fc3_b";
> };
>
> @@ -53,7 +43,7 @@ &flx3 {
> status = "okay";
>
> usart3: serial@200 {
> - pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> + pinctrl-0 = <&fc3_b_pins>;
> pinctrl-names = "default";
> status = "okay";
> };
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings.
2022-07-04 13:58 [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
2022-07-04 14:06 ` Nicolas Ferre
@ 2022-07-05 7:41 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2022-07-05 7:41 UTC (permalink / raw)
To: Kavyasree.Kotagiri, arnd, alexandre.belloni,
krzysztof.kozlowski+dt, Nicolas.Ferre
Cc: soc, robh+dt, linux-arm-kernel, devicetree, linux-kernel,
UNGLinuxDriver
On 04.07.2022 16:58, Kavyasree Kotagiri wrote:
> On pcb8291, Flexcom3 usart has only tx and rx pins.
> Cleaningup usart3 pinctrl settings.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Applied to at91-dt, thanks!
> ---
> v1 -> v2:
> - Keep both tx and rx pins into one node.
>
> arch/arm/boot/dts/lan966x-pcb8291.dts | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x-pcb8291.dts b/arch/arm/boot/dts/lan966x-pcb8291.dts
> index 3c7e3a7d6f14..d56d2054c38d 100644
> --- a/arch/arm/boot/dts/lan966x-pcb8291.dts
> +++ b/arch/arm/boot/dts/lan966x-pcb8291.dts
> @@ -19,19 +19,9 @@ aliases {
> };
>
> &gpio {
> - fc_shrd7_pins: fc_shrd7-pins {
> - pins = "GPIO_49";
> - function = "fc_shrd7";
> - };
> -
> - fc_shrd8_pins: fc_shrd8-pins {
> - pins = "GPIO_54";
> - function = "fc_shrd8";
> - };
> -
> - fc3_b_pins: fcb3-spi-pins {
> - /* SCK, RXD, TXD */
> - pins = "GPIO_51", "GPIO_52", "GPIO_53";
> + fc3_b_pins: fc3-b-pins {
> + /* RX, TX */
> + pins = "GPIO_52", "GPIO_53";
> function = "fc3_b";
> };
>
> @@ -53,7 +43,7 @@ &flx3 {
> status = "okay";
>
> usart3: serial@200 {
> - pinctrl-0 = <&fc3_b_pins>, <&fc_shrd7_pins>, <&fc_shrd8_pins>;
> + pinctrl-0 = <&fc3_b_pins>;
> pinctrl-names = "default";
> status = "okay";
> };
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-05 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 13:58 [PATCH v2] ARM: dts: lan966x: Cleanup flexcom3 usart pinctrl settings Kavyasree Kotagiri
2022-07-04 14:06 ` Nicolas Ferre
2022-07-05 7:41 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).