[PATCH 1/2] ARM: dts: lan966x: add clock gating register

[PATCH 1/2] ARM: dts: lan966x: add clock gating register

[Michael Walle]

The clock controller supports an optional clock gating register. This is
necessary to expose the USB device clock, for example. Add it.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm/boot/dts/lan966x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index a5d456fa4e04..ab70b7ad1c5d 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -65,7 +65,7 @@ clks: clock-controller@e00c00a8 {
 		#clock-cells = <1>;
 		clocks = <&cpu_clk>, <&ddr_clk>, <&sys_clk>;
 		clock-names = "cpu", "ddr", "sys";
-		reg = <0xe00c00a8 0x38>;
+		reg = <0xe00c00a8 0x38>, <0xe00c02cc 0x4>;
 	};
 
 	timer {
-- 
2.30.2

[PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

[Michael Walle]

Now that there is driver support for the USB device, enable it.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
index 5a6c5f7c371a..d0d26e136c38 100644
--- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
+++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
@@ -200,6 +200,11 @@ &switch {
 	status = "okay";
 };
 
+&udc {
+	atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
+	status = "okay";
+};
+
 &watchdog {
 	status = "okay";
 };
-- 
2.30.2

Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

[Claudiu.Beznea]

Hi, Michael,

On 05.07.2022 16:06, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Now that there is driver support for the USB device, enable it.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 5a6c5f7c371a..d0d26e136c38 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -200,6 +200,11 @@ &switch {
>         status = "okay";
>  };
> 
> +&udc {
> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;

Can you also add pinctrl to avoid issues described in:

commit 5ba6291086d2ae8006be9e0f19bf2001a85c9dc1
Author: Cristian Birsan <cristian.birsan@microchip.com>
Date:   Wed Nov 18 14:00:17 2020 +0200

    ARM: dts: at91: sam9x60: add pincontrol for USB Host

    The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without
    it the driver probes but VBus is not powered because of wrong pincontrol
    configuration.

    Fixes: 1e5f532c2737 ("ARM: dts: at91: sam9x60: add device tree for soc
and board")
    Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
    Link:
https://lore.kernel.org/r/20201118120019.1257580-2-cristian.birsan@microchip.com

Thank you,
Claudiu Beznea

> +       status = "okay";
> +};
> +
>  &watchdog {
>         status = "okay";
>  };
> --
> 2.30.2
> 

Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

[Michael Walle]

Hi Claudiu,

Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com:
> On 05.07.2022 16:06, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the content is safe
>> 
>> Now that there is driver support for the USB device, enable it.
>> 
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi 
>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> index 5a6c5f7c371a..d0d26e136c38 100644
>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> @@ -200,6 +200,11 @@ &switch {
>>         status = "okay";
>>  };
>> 
>> +&udc {
>> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
> 
> Can you also add pinctrl to avoid issues described in:

Do I need a pinctrl node even if I just use it as a gpio?
Isn't that handled automatically by the
.gpio_request_enable op?

-michael

Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

[Claudiu.Beznea]

On 06.07.2022 11:57, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Hi Claudiu,
> 
> Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com:
>> On 05.07.2022 16:06, Michael Walle wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know
>>> the content is safe
>>>
>>> Now that there is driver support for the USB device, enable it.
>>>
>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>> ---
>>>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> index 5a6c5f7c371a..d0d26e136c38 100644
>>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>> @@ -200,6 +200,11 @@ &switch {
>>>         status = "okay";
>>>  };
>>>
>>> +&udc {
>>> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>>
>> Can you also add pinctrl to avoid issues described in:
> 
> Do I need a pinctrl node even if I just use it as a gpio?
> Isn't that handled automatically by the
> .gpio_request_enable op?

I cannot say for sure.

Looking a bit though it I think the issue described in commit I pointed may
come from the fact that struct gpio_chip::request may be
gpiochip_generic_request() which may return 0 in case
list_empty(&gc->gpiodev->pin_ranges) is true. The commit that I pointed was
introduced after commit 2ab73c6d8323 ("gpio: Support GPIO controllers
without pin-ranges") but I don't have more knowledge on it.

> 
> -michael

Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

[Michael Walle]

Am 2022-07-07 11:18, schrieb Claudiu.Beznea@microchip.com:
> On 06.07.2022 11:57, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the
>> content is safe
>> 
>> Hi Claudiu,
>> 
>> Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com:
>>> On 05.07.2022 16:06, Michael Walle wrote:
>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you 
>>>> know
>>>> the content is safe
>>>> 
>>>> Now that there is driver support for the USB device, enable it.
>>>> 
>>>> Signed-off-by: Michael Walle <michael@walle.cc>
>>>> ---
>>>>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>> 
>>>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> index 5a6c5f7c371a..d0d26e136c38 100644
>>>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>>>> @@ -200,6 +200,11 @@ &switch {
>>>>         status = "okay";
>>>>  };
>>>> 
>>>> +&udc {
>>>> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
>>> 
>>> Can you also add pinctrl to avoid issues described in:
>> 
>> Do I need a pinctrl node even if I just use it as a gpio?
>> Isn't that handled automatically by the
>> .gpio_request_enable op?
> 
> I cannot say for sure.
> 
> Looking a bit though it I think the issue described in commit I pointed 
> may
> come from the fact that struct gpio_chip::request may be
> gpiochip_generic_request() which may return 0 in case
> list_empty(&gc->gpiodev->pin_ranges) is true. The commit that I pointed 
> was
> introduced after commit 2ab73c6d8323 ("gpio: Support GPIO controllers
> without pin-ranges") but I don't have more knowledge on it.
> 

I'll just add it :) Thanks!

-michael