From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE58DCCA47B for ; Tue, 5 Jul 2022 18:47:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiGESrD (ORCPT ); Tue, 5 Jul 2022 14:47:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229520AbiGESrD (ORCPT ); Tue, 5 Jul 2022 14:47:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C89913F01; Tue, 5 Jul 2022 11:47:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEB3A61A14; Tue, 5 Jul 2022 18:47:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20DE2C341C7; Tue, 5 Jul 2022 18:47:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657046821; bh=OMCkKQ2ErnACEC3cqw+eGqkRWkRpQ5UJB1VdSBShfJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xi9htHFMumyIPi759zbbwp1LPIqzzaj8O4agd6tP7p7YRz9ZRQ4/E6WV0SFmdxTLP eJSYCEwe3eLJZyLdYmXeqEZPFktBSi80F4BKkk8wCT+PtsYA0TrtSImMAZJXErbJyz fFNeNKpz56wq1/XPE7l7Y/b2pDqgFhqf4r/8UE/2ahgImA7zNZADXAPvSB72W0+hoq l1e3xldm4ELPfXH9b+vGSn+cl6L8jgiPJtatK/nLMu95/+7DWbEqSQEAVyHKQGaig+ OThzCyxKC1tEWH9tHDPi+fCIb94GYtMgTZnygjj8sh7QBWE+amCuKLBAp49vebNAME EVmdfg2aoYn/g== Received: by pali.im (Postfix) id 05B38CBF; Tue, 5 Jul 2022 20:46:57 +0200 (CEST) Date: Tue, 5 Jul 2022 20:46:57 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andy Shevchenko Cc: Pavel Machek , Rob Herring , Krzysztof Kozlowski , Marek =?utf-8?B?QmVow7pu?= , Linux LED Subsystem , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/2] leds: Add support for Turris 1.x LEDs Message-ID: <20220705184657.us53ciamy2oygakt@pali> References: <20220705000448.14337-1-pali@kernel.org> <20220705155929.25565-1-pali@kernel.org> <20220705155929.25565-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tuesday 05 July 2022 20:40:26 Andy Shevchenko wrote: > On Tue, Jul 5, 2022 at 6:11 PM Pali Rohár wrote: > > > > This adds support for the RGB LEDs found on the front panel of the > > Turris 1.x routers. There are 8 RGB LEDs that are controlled by > > CZ.NIC CPLD firmware running on Lattice FPGA. > > > > CPLD firmware provides HW triggering mode for all LEDs except WiFi LED > > which is automatically enabled after power on reset. LAN LEDs share HW > > registers for RGB colors settings, so it is not possible to set different > > colors for individual LAN LEDs. > > > > CZ.NIC CPLD firmware is open source and available at: > > https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v > > > > This driver uses the multicolor LED framework and HW led triggers. > > Pardon me, but this driver seems like 3 years old by the APIs it's > using... I have to say this, because I was surprised a lot to see some > calls. I wrote it just recently according to other omnia multicolor driver.