From: Rob Herring <robh@kernel.org>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Chen-Yu Tsai <wens@csie.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Maxime Ripard <mripard@kernel.org>,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo
Date: Tue, 5 Jul 2022 14:28:31 -0600 [thread overview]
Message-ID: <20220705202831.GA2566864-robh@kernel.org> (raw)
In-Reply-To: <22696538.6Emhk5qWAg@jernej-laptop>
On Sat, Jul 02, 2022 at 09:34:41PM +0200, Jernej Škrabec wrote:
> Dne sobota, 02. julij 2022 ob 05:19:02 CEST je Samuel Holland napisal(a):
> > The conditional block for variants with a second clock should have set
> > minItems, not maxItems, which was already 2. Since clock-names requires
> > two items, this typo should not have caused any problems.
> >
> > Fixes: edd14218bd66 ("dt-bindings: dmaengine: Convert Allwinner A31 and A64
> > DMA to a schema") Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> >
> > .../devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml index
> > ff0a5c58d78c..e712444abff1 100644
> > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml
> > @@ -67,7 +67,7 @@ if:
> > then:
> > properties:
> > clocks:
> > - maxItems: 2
> > + minItems: 2
>
> These specific variants have exactly 2 clocks. Having both limits seems right.
You do. The main section has 2 for the max.
Rob
next prev parent reply other threads:[~2022-07-05 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-02 3:19 [PATCH] dt-bindings: dma: allwinner,sun50i-a64-dma: Fix min/max typo Samuel Holland
2022-07-02 19:34 ` Jernej Škrabec
2022-07-05 20:28 ` Rob Herring [this message]
2022-07-05 20:28 ` Rob Herring
2022-07-06 16:27 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705202831.GA2566864-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).