devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe@baylibre.com>
To: heiko@sntech.de, herbert@gondor.apana.org.au,
	krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
	p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org
Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	john@metanate.com, didi.debian@cknow.org,
	Corentin Labbe <clabbe@baylibre.com>
Subject: [PATCH v8 17/33] crypto: rockchip: use read_poll_timeout
Date: Wed,  6 Jul 2022 09:03:56 +0000	[thread overview]
Message-ID: <20220706090412.806101-18-clabbe@baylibre.com> (raw)
In-Reply-To: <20220706090412.806101-1-clabbe@baylibre.com>

Use read_poll_timeout instead of open coding it.
In the same time, fix indentation of related comment.

Reviewed-by: John Keeping <john@metanate.com>
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 drivers/crypto/rockchip/rk3288_crypto_ahash.c | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/crypto/rockchip/rk3288_crypto_ahash.c b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
index 137013bd4410..1fbab86c9238 100644
--- a/drivers/crypto/rockchip/rk3288_crypto_ahash.c
+++ b/drivers/crypto/rockchip/rk3288_crypto_ahash.c
@@ -10,6 +10,7 @@
  */
 #include <linux/device.h>
 #include <asm/unaligned.h>
+#include <linux/iopoll.h>
 #include "rk3288_crypto.h"
 
 /*
@@ -295,18 +296,17 @@ static int rk_hash_run(struct crypto_engine *engine, void *breq)
 		sg = sg_next(sg);
 	}
 
-		/*
-		 * it will take some time to process date after last dma
-		 * transmission.
-		 *
-		 * waiting time is relative with the last date len,
-		 * so cannot set a fixed time here.
-		 * 10us makes system not call here frequently wasting
-		 * efficiency, and make it response quickly when dma
-		 * complete.
-		 */
-	while (!CRYPTO_READ(tctx->dev, RK_CRYPTO_HASH_STS))
-		udelay(10);
+	/*
+	 * it will take some time to process date after last dma
+	 * transmission.
+	 *
+	 * waiting time is relative with the last date len,
+	 * so cannot set a fixed time here.
+	 * 10us makes system not call here frequently wasting
+	 * efficiency, and make it response quickly when dma
+	 * complete.
+	 */
+	readl_poll_timeout(tctx->dev->reg + RK_CRYPTO_HASH_STS, v, v == 0, 10, 1000);
 
 	for (i = 0; i < crypto_ahash_digestsize(tfm) / 4; i++) {
 		v = readl(tctx->dev->reg + RK_CRYPTO_HASH_DOUT_0 + i * 4);
-- 
2.35.1


  parent reply	other threads:[~2022-07-06  9:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  9:03 [PATCH v8 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 11/33] crypto: rockchip: rewrite type Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-07-06  9:03 ` Corentin Labbe [this message]
2022-07-06  9:03 ` [PATCH v8 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-07-06  9:03 ` [PATCH v8 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings Corentin Labbe
2022-07-06 13:29   ` Rob Herring
2022-07-06 14:28     ` LABBE Corentin
2022-07-06 15:25       ` Krzysztof Kozlowski
2022-07-07  8:37         ` LABBE Corentin
2022-07-10 15:12           ` Krzysztof Kozlowski
2022-07-12 21:54       ` Rob Herring
2022-07-06  9:04 ` [PATCH v8 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-07-06  9:04 ` [PATCH v8 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706090412.806101-18-clabbe@baylibre.com \
    --to=clabbe@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=john@metanate.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).