From: Conor Dooley <conor.dooley@microchip.com>
To: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
"Conor Dooley" <conor.dooley@microchip.com>
Subject: [net-next PATCH v3 0/5] PolarFire SoC macb reset support
Date: Wed, 6 Jul 2022 10:51:24 +0100 [thread overview]
Message-ID: <20220706095129.828253-1-conor.dooley@microchip.com> (raw)
Hey all,
Jakub requested that these patches be split off from the series
adding the reset controller itself that I sent ~yesterday~ last
week [0].
The Cadence MACBs on PolarFire SoC (MPFS) have reset capability and are
compatible with the zynqmp's init function. I have removed the zynqmp
specific comments from that function & renamed it to reflect what it
does, since it is no longer zynqmp only.
MPFS's MACB had previously used the generic binding, so I also added
the required specific binding.
For v2, I noticed some low hanging cleanup fruit so there are extra
patches added for that:
moving the init function out of the config structs, aligning the
alignment of the zynqmp & default config structs with the other dozen
or so structs & simplifing the error paths to use dev_err_probe().
Feel free to apply as many or as few of those as you like.
Thanks,
Conor.
Changes since v2:
- Fix a commit message typo
Changes since v1:
- added the 3 aforementioned cleanup patches
- fixed two stylistic complaints from Claudiu
Conor Dooley (5):
dt-bindings: net: cdns,macb: document polarfire soc's macb
net: macb: add polarfire soc reset support
net: macb: unify macb_config alignment style
net: macb: simplify error paths in init_reset_optional()
net: macb: sort init_reset_optional() with other init()s
.../devicetree/bindings/net/cdns,macb.yaml | 1 +
drivers/net/ethernet/cadence/macb_main.c | 106 +++++++++---------
2 files changed, 56 insertions(+), 51 deletions(-)
--
2.36.1
next reply other threads:[~2022-07-06 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 9:51 Conor Dooley [this message]
2022-07-06 9:51 ` [net-next PATCH v3 1/5] dt-bindings: net: cdns,macb: document polarfire soc's macb Conor Dooley
2022-07-06 9:51 ` [net-next PATCH v3 2/5] net: macb: add polarfire soc reset support Conor Dooley
2022-07-06 9:51 ` [net-next PATCH v3 3/5] net: macb: unify macb_config alignment style Conor Dooley
2022-07-06 9:51 ` [net-next PATCH v3 4/5] net: macb: simplify error paths in init_reset_optional() Conor Dooley
2022-07-06 9:51 ` [net-next PATCH v3 5/5] net: macb: sort init_reset_optional() with other init()s Conor Dooley
2022-07-08 3:10 ` [net-next PATCH v3 0/5] PolarFire SoC macb reset support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706095129.828253-1-conor.dooley@microchip.com \
--to=conor.dooley@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).