From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0358DC43334 for ; Wed, 6 Jul 2022 14:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232716AbiGFO6Q (ORCPT ); Wed, 6 Jul 2022 10:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232213AbiGFO6P (ORCPT ); Wed, 6 Jul 2022 10:58:15 -0400 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6341101F0; Wed, 6 Jul 2022 07:58:12 -0700 (PDT) Received: by mail-io1-f43.google.com with SMTP id y2so14194957ior.12; Wed, 06 Jul 2022 07:58:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Vx9EKWNYpcHBOsFbrprMQU719uQis38dKdcJXfbwAb4=; b=4UKRxWm1rKksnEIpVp06DQ7h6yJm/hzBjy1fzGA8o9NatkMYrBOn3NRg3aR9mYWUhd v2VGp4tFWLv0DzxpGcpzxAKRQrn4KPh2/iMnvZI08xeZ2wrwA5xk+Ad/ydkcWDey6GAO CQj5R4HounBhM+GKbaZTs3BoIBsZRdalq0BCeFWEyySLEoxJC850xkkBfyUhlXG4HWhI SBp5zOONfxmSrcFsQnRM5TeCRy4NpNKruuezauAXpkdWRslq9IlT54m3onT8v0jtXibJ 1jPevSeILUyEVGZgy8aaQCMp3gKR28pCnVSNz/wKtFCE/Nh3Ip1waCaL5ba1nERi7plh YLkw== X-Gm-Message-State: AJIora+70PFLalY+MtHLry5ljqdz5N+/qTgDHl7EokvYHkO5Emr2xp31 kCTkMfW5OjVkifErBnlgzA== X-Google-Smtp-Source: AGRyM1udQ5XczJ1KHQSlRVuFA63BJs50eNEvdvNtfvmCm02Cs9+9gEXCy7woVdpj6J2kIFqyxJ2AXw== X-Received: by 2002:a6b:f206:0:b0:675:544d:45ec with SMTP id q6-20020a6bf206000000b00675544d45ecmr21193391ioh.96.1657119492022; Wed, 06 Jul 2022 07:58:12 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id q15-20020a02a98f000000b0033ee1e67c6esm2876600jam.79.2022.07.06.07.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 07:58:11 -0700 (PDT) Received: (nullmailer pid 35182 invoked by uid 1000); Wed, 06 Jul 2022 14:58:07 -0000 Date: Wed, 6 Jul 2022 08:58:07 -0600 From: Rob Herring To: Rahul T R Cc: dri-devel@lists.freedesktop.org, krzysztof.kozlowski+dt@linaro.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, p.zabel@pengutronix.de, tomi.valkeinen@ideasonboard.com, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, jpawar@cadence.com, sjakhade@cadence.com, mparab@cadence.com, a-bhatia1@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lee.jones@linaro.org Subject: Re: [PATCH v5 1/5] dt-bindings: display: bridge: Convert cdns,dsi.txt to yaml Message-ID: <20220706145807.GA22662-robh@kernel.org> References: <20220706114053.3454-1-r-ravikumar@ti.com> <20220706114053.3454-2-r-ravikumar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706114053.3454-2-r-ravikumar@ti.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 06, 2022 at 05:10:49PM +0530, Rahul T R wrote: > Convert cdns,dsi.txt binding to yaml format > > Signed-off-by: Rahul T R > --- > .../bindings/display/bridge/cdns,dsi.txt | 112 ---------- > .../bindings/display/bridge/cdns,dsi.yaml | 195 ++++++++++++++++++ > 2 files changed, 195 insertions(+), 112 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > deleted file mode 100644 > index 525a4bfd8634..000000000000 > --- a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt > +++ /dev/null > @@ -1,112 +0,0 @@ > -Cadence DSI bridge > -================== > - > -The Cadence DSI bridge is a DPI to DSI bridge supporting up to 4 DSI lanes. > - > -Required properties: > -- compatible: should be set to "cdns,dsi". > -- reg: physical base address and length of the controller's registers. > -- interrupts: interrupt line connected to the DSI bridge. > -- clocks: DSI bridge clocks. > -- clock-names: must contain "dsi_p_clk" and "dsi_sys_clk". > -- phys: phandle link to the MIPI D-PHY controller. > -- phy-names: must contain "dphy". > -- #address-cells: must be set to 1. > -- #size-cells: must be set to 0. > - > -Optional properties: > -- resets: DSI reset lines. > -- reset-names: can contain "dsi_p_rst". > - > -Required subnodes: > -- ports: Ports as described in Documentation/devicetree/bindings/graph.txt. > - 2 ports are available: > - * port 0: this port is only needed if some of your DSI devices are > - controlled through an external bus like I2C or SPI. Can have at > - most 4 endpoints. The endpoint number is directly encoding the > - DSI virtual channel used by this device. > - * port 1: represents the DPI input. > - Other ports will be added later to support the new kind of inputs. > - > -- one subnode per DSI device connected on the DSI bus. Each DSI device should > - contain a reg property encoding its virtual channel. > - > -Example: > - dsi0: dsi@fd0c0000 { > - compatible = "cdns,dsi"; > - reg = <0x0 0xfd0c0000 0x0 0x1000>; > - clocks = <&pclk>, <&sysclk>; > - clock-names = "dsi_p_clk", "dsi_sys_clk"; > - interrupts = <1>; > - phys = <&dphy0>; > - phy-names = "dphy"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@1 { > - reg = <1>; > - dsi0_dpi_input: endpoint { > - remote-endpoint = <&xxx_dpi_output>; > - }; > - }; > - }; > - > - panel: dsi-dev@0 { > - compatible = ""; > - reg = <0>; > - }; > - }; > - > -or > - > - dsi0: dsi@fd0c0000 { > - compatible = "cdns,dsi"; > - reg = <0x0 0xfd0c0000 0x0 0x1000>; > - clocks = <&pclk>, <&sysclk>; > - clock-names = "dsi_p_clk", "dsi_sys_clk"; > - interrupts = <1>; > - phys = <&dphy1>; > - phy-names = "dphy"; > - #address-cells = <1>; > - #size-cells = <0>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - dsi0_output: endpoint@0 { > - reg = <0>; > - remote-endpoint = <&dsi_panel_input>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - dsi0_dpi_input: endpoint { > - remote-endpoint = <&xxx_dpi_output>; > - }; > - }; > - }; > - }; > - > - i2c@xxx { > - panel: panel@59 { > - compatible = ""; > - reg = <0x59>; > - > - port { > - dsi_panel_input: endpoint { > - remote-endpoint = <&dsi0_output>; > - }; > - }; > - }; > - }; > diff --git a/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > new file mode 100644 > index 000000000000..865b3005c091 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/cdns,dsi.yaml > @@ -0,0 +1,195 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/cdns,dsi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cadence DSI bridge > + > +maintainers: > + - Boris Brezillon > + > +description: | > + CDNS DSI is a bridge device which converts DPI to DSI > + > +properties: > + compatible: > + enum: > + - cdns,dsi > + > + reg: > + items: > + - description: > + Register block for controller's registers. No need for generic descriptions. Just 'maxItems: 1' when there's only 1 entry. > + > + clocks: > + items: > + - description: PSM clock, used by the IP > + - description: sys clock, used by the IP > + > + clock-names: > + items: > + - const: dsi_p_clk > + - const: dsi_sys_clk > + > + phys: > + maxItems: 1 > + description: phandle link to the MIPI D-PHY controller. Drop > + > + phy-names: > + const: dphy > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + description: PHY reset. Drop > + > + reset-names: > + const: dsi_p_rst > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port representing the DSI output. It can have > + most 4 endpoints. The endpoint number is directly encoding at most > + the DSI virtual channel used by this device. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port representing the DP bridge input. DP? s/DP bridge/parallel/ > + > + required: > + - port@1 > + > +allOf: > + - $ref: ../dsi-controller.yaml# > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - phys > + - phy-names > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dsi@fd0c0000 { > + compatible = "cdns,dsi"; > + reg = <0x0 0xfd0c0000 0x0 0x1000>; > + clocks = <&pclk>, <&sysclk>; > + clock-names = "dsi_p_clk", "dsi_sys_clk"; > + interrupts = <1>; > + phys = <&dphy0>; > + phy-names = "dphy"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&xxx_dpi_output>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "panasonic,vvx10f034n00"; > + reg = <0>; > + power-supply = <&vcc_lcd_reg>; > + }; > + }; > + }; > + > + - | > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + dsi@fd0c0000 { > + compatible = "cdns,dsi"; > + reg = <0x0 0xfd0c0000 0x0 0x1000>; > + clocks = <&pclk>, <&sysclk>; > + clock-names = "dsi_p_clk", "dsi_sys_clk"; > + interrupts = <1>; > + phys = <&dphy1>; > + phy-names = "dphy"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + dsi0_output: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&dsi_panel_input>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&xxx_dpi_output>; > + }; > + }; > + }; > + }; > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + bridge@2d { > + compatible = "ti,sn65dsi86"; > + reg = <0x2d>; This device isn't relevant to the example. Drop. > + > + vpll-supply = <&src_pp1800_s4a>; > + vccio-supply = <&src_pp1800_s4a>; > + vcca-supply = <&src_pp1200_l2a>; > + vcc-supply = <&src_pp1200_l2a>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + dsi_panel_input: endpoint { > + remote-endpoint = <&dsi0_output>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&panel_in_edp>; > + }; > + }; > + }; > + }; > + }; > + }; > -- > 2.36.1 > >