From: Nishanth Menon <nm@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node
Date: Wed, 6 Jul 2022 13:35:26 -0500 [thread overview]
Message-ID: <20220706183526.i6ysrsjgevz3w3ei@masculine> (raw)
In-Reply-To: <16319b56-4b14-6f51-23c6-6b78b87119d7@ti.com>
On 13:10-20220706, Andrew Davis wrote:
> > > + mcu_crypto: crypto@40900000 {
> > > + compatible = "ti,j721e-sa2ul";
> > > + reg = <0x00 0x40900000 0x00 0x1200>;
> > > + power-domains = <&k3_pds 265 TI_SCI_PD_SHARED>;
> > > + #address-cells = <2>;
> > > + #size-cells = <2>;
> > > + ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> > > + dmas = <&mcu_udmap 0xf501>, <&mcu_udmap 0x7502>,
> > > + <&mcu_udmap 0x7503>;
> > > + dma-names = "tx", "rx1", "rx2";
> > > + dma-coherent;
> > > +
> > > + rng: rng@40910000 {
> > > + compatible = "inside-secure,safexcel-eip76";
> > > + reg = <0x00 0x40910000 0x00 0x7d>;
> > > + interrupts = <GIC_SPI 945 IRQ_TYPE_LEVEL_HIGH>;
> >
> > Please document why disabled.
> >
>
> Sure thing, will add background info to the commit message.
I'd suggest to document in dts as well. See thread [1]
[1] https://lore.kernel.org/linux-arm-kernel/YiizsYnKB0X9bDY2@atomide.com/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2022-07-06 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 17:03 [PATCH 1/6] crypto: sa2ul - Set the supported_algos bits individually Andrew Davis
2022-07-05 17:03 ` [PATCH 2/6] crypto: sa2ul - Check engine status before enabling Andrew Davis
2022-07-05 17:03 ` [PATCH 3/6] arm64: dts: ti: k3-am65-main: Disable RNG node Andrew Davis
2022-07-05 17:03 ` [PATCH 4/6] arm64: dts: ti: k3-am65-main: Move SA2UL to unused PSI-L thread ID Andrew Davis
2022-07-05 17:03 ` [PATCH 5/6] arm64: dts: ti: k3-am65-main: Do not exclusively claim SA2UL Andrew Davis
2022-07-05 17:03 ` [PATCH 6/6] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node Andrew Davis
2022-07-06 18:04 ` Nishanth Menon
2022-07-06 18:10 ` Andrew Davis
2022-07-06 18:35 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706183526.i6ysrsjgevz3w3ei@masculine \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox