* [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'
@ 2022-07-06 21:19 Rob Herring
2022-07-12 20:56 ` Krzysztof Kozlowski
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Rob Herring @ 2022-07-06 21:19 UTC (permalink / raw)
To: Fabrice Gasnier, Lee Jones, Krzysztof Kozlowski, Maxime Coquelin,
Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
Fixed string node names should be under 'properties' rather than
'patternProperties'. Additionally, without beginning and end of line
anchors, any prefix or suffix is allowed on the specified node name.
Move the stm32 timers 'counter' and 'timer' nodes to the 'properties'
section.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../bindings/mfd/st,stm32-lptimer.yaml | 28 +++++++++----------
.../bindings/mfd/st,stm32-timers.yaml | 20 ++++++-------
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
index ec7f0190f46e..a58f08aa430d 100644
--- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
@@ -58,43 +58,43 @@ properties:
- "#pwm-cells"
- compatible
-patternProperties:
- "^trigger@[0-9]+$":
+ counter:
type: object
properties:
compatible:
- const: st,stm32-lptimer-trigger
-
- reg:
- description: Identify trigger hardware block.
- items:
- minimum: 0
- maximum: 2
+ const: st,stm32-lptimer-counter
required:
- compatible
- - reg
- counter:
+ timer:
type: object
properties:
compatible:
- const: st,stm32-lptimer-counter
+ const: st,stm32-lptimer-timer
required:
- compatible
- timer:
+patternProperties:
+ "^trigger@[0-9]+$":
type: object
properties:
compatible:
- const: st,stm32-lptimer-timer
+ const: st,stm32-lptimer-trigger
+
+ reg:
+ description: Identify trigger hardware block.
+ items:
+ minimum: 0
+ maximum: 2
required:
- compatible
+ - reg
required:
- "#address-cells"
diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
index 10b330d42901..1bd663f886dc 100644
--- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
+++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
@@ -87,6 +87,16 @@ properties:
- "#pwm-cells"
- compatible
+ counter:
+ type: object
+
+ properties:
+ compatible:
+ const: st,stm32-timer-counter
+
+ required:
+ - compatible
+
patternProperties:
"^timer@[0-9]+$":
type: object
@@ -107,16 +117,6 @@ patternProperties:
- compatible
- reg
- counter:
- type: object
-
- properties:
- compatible:
- const: st,stm32-timer-counter
-
- required:
- - compatible
-
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'
2022-07-06 21:19 [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties' Rob Herring
@ 2022-07-12 20:56 ` Krzysztof Kozlowski
2022-07-13 12:25 ` Fabrice Gasnier
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-12 20:56 UTC (permalink / raw)
To: Rob Herring, Fabrice Gasnier, Lee Jones, Krzysztof Kozlowski,
Maxime Coquelin, Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
On 06/07/2022 23:19, Rob Herring wrote:
> Fixed string node names should be under 'properties' rather than
> 'patternProperties'. Additionally, without beginning and end of line
> anchors, any prefix or suffix is allowed on the specified node name.
>
> Move the stm32 timers 'counter' and 'timer' nodes to the 'properties'
> section.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'
2022-07-06 21:19 [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties' Rob Herring
2022-07-12 20:56 ` Krzysztof Kozlowski
@ 2022-07-13 12:25 ` Fabrice Gasnier
2022-07-21 19:09 ` Rob Herring
2022-07-22 8:02 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Fabrice Gasnier @ 2022-07-13 12:25 UTC (permalink / raw)
To: Rob Herring, Lee Jones, Krzysztof Kozlowski, Maxime Coquelin,
Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
On 7/6/22 23:19, Rob Herring wrote:
> Fixed string node names should be under 'properties' rather than
> 'patternProperties'. Additionally, without beginning and end of line
> anchors, any prefix or suffix is allowed on the specified node name.
>
> Move the stm32 timers 'counter' and 'timer' nodes to the 'properties'
> section.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Hi Rob,
You can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Thanks and Best Regards,
Fabrice
> ---
> .../bindings/mfd/st,stm32-lptimer.yaml | 28 +++++++++----------
> .../bindings/mfd/st,stm32-timers.yaml | 20 ++++++-------
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> index ec7f0190f46e..a58f08aa430d 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml
> @@ -58,43 +58,43 @@ properties:
> - "#pwm-cells"
> - compatible
>
> -patternProperties:
> - "^trigger@[0-9]+$":
> + counter:
> type: object
>
> properties:
> compatible:
> - const: st,stm32-lptimer-trigger
> -
> - reg:
> - description: Identify trigger hardware block.
> - items:
> - minimum: 0
> - maximum: 2
> + const: st,stm32-lptimer-counter
>
> required:
> - compatible
> - - reg
>
> - counter:
> + timer:
> type: object
>
> properties:
> compatible:
> - const: st,stm32-lptimer-counter
> + const: st,stm32-lptimer-timer
>
> required:
> - compatible
>
> - timer:
> +patternProperties:
> + "^trigger@[0-9]+$":
> type: object
>
> properties:
> compatible:
> - const: st,stm32-lptimer-timer
> + const: st,stm32-lptimer-trigger
> +
> + reg:
> + description: Identify trigger hardware block.
> + items:
> + minimum: 0
> + maximum: 2
>
> required:
> - compatible
> + - reg
>
> required:
> - "#address-cells"
> diff --git a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> index 10b330d42901..1bd663f886dc 100644
> --- a/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> +++ b/Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml
> @@ -87,6 +87,16 @@ properties:
> - "#pwm-cells"
> - compatible
>
> + counter:
> + type: object
> +
> + properties:
> + compatible:
> + const: st,stm32-timer-counter
> +
> + required:
> + - compatible
> +
> patternProperties:
> "^timer@[0-9]+$":
> type: object
> @@ -107,16 +117,6 @@ patternProperties:
> - compatible
> - reg
>
> - counter:
> - type: object
> -
> - properties:
> - compatible:
> - const: st,stm32-timer-counter
> -
> - required:
> - - compatible
> -
> required:
> - compatible
> - reg
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'
2022-07-06 21:19 [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties' Rob Herring
2022-07-12 20:56 ` Krzysztof Kozlowski
2022-07-13 12:25 ` Fabrice Gasnier
@ 2022-07-21 19:09 ` Rob Herring
2022-07-22 8:02 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-07-21 19:09 UTC (permalink / raw)
To: Fabrice Gasnier, Lee Jones, Krzysztof Kozlowski, Maxime Coquelin,
Alexandre Torgue
Cc: devicetree, linux-stm32, linux-arm-kernel, linux-kernel
On Wed, Jul 06, 2022 at 03:19:33PM -0600, Rob Herring wrote:
> Fixed string node names should be under 'properties' rather than
> 'patternProperties'. Additionally, without beginning and end of line
> anchors, any prefix or suffix is allowed on the specified node name.
>
> Move the stm32 timers 'counter' and 'timer' nodes to the 'properties'
> section.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/mfd/st,stm32-lptimer.yaml | 28 +++++++++----------
> .../bindings/mfd/st,stm32-timers.yaml | 20 ++++++-------
> 2 files changed, 24 insertions(+), 24 deletions(-)
Lee, going to pick this one up?
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties'
2022-07-06 21:19 [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties' Rob Herring
` (2 preceding siblings ...)
2022-07-21 19:09 ` Rob Herring
@ 2022-07-22 8:02 ` Lee Jones
3 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2022-07-22 8:02 UTC (permalink / raw)
To: Rob Herring
Cc: Fabrice Gasnier, Krzysztof Kozlowski, Maxime Coquelin,
Alexandre Torgue, devicetree, linux-stm32, linux-arm-kernel,
linux-kernel
On Wed, 06 Jul 2022, Rob Herring wrote:
> Fixed string node names should be under 'properties' rather than
> 'patternProperties'. Additionally, without beginning and end of line
> anchors, any prefix or suffix is allowed on the specified node name.
>
> Move the stm32 timers 'counter' and 'timer' nodes to the 'properties'
> section.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/mfd/st,stm32-lptimer.yaml | 28 +++++++++----------
> .../bindings/mfd/st,stm32-timers.yaml | 20 ++++++-------
> 2 files changed, 24 insertions(+), 24 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-22 8:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-06 21:19 [PATCH] dt-bindings: mfd: stm32-timers: Move fixed string node names under 'properties' Rob Herring
2022-07-12 20:56 ` Krzysztof Kozlowski
2022-07-13 12:25 ` Fabrice Gasnier
2022-07-21 19:09 ` Rob Herring
2022-07-22 8:02 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).