devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Subject: [PATCH 6/9] dt-bindings: msm/dp: handle DP vs eDP difference
Date: Fri,  8 Jul 2022 00:32:01 +0300	[thread overview]
Message-ID: <20220707213204.2605816-7-dmitry.baryshkov@linaro.org> (raw)
In-Reply-To: <20220707213204.2605816-1-dmitry.baryshkov@linaro.org>

The #sound-dai-cells property should be used only for DP controllers. It
doesn't make sense for eDP, there is no support for audio output. Also
aux-bus should not be used for DP controllers. Take care of these
differences.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../bindings/display/msm/dp-controller.yaml   | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 1ef845005b14..491f4aefe0db 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -107,7 +107,6 @@ required:
   - clock-names
   - phys
   - phy-names
-  - "#sound-dai-cells"
   - power-domains
   - ports
 
@@ -155,6 +154,24 @@ allOf:
             - const: ctrl_link_iface
             - const: stream_pixel
 
+  # AUX BUS does not exist on DP controllers
+  # Audio output also is present only on DP output
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sc7280-edp
+              - qcom,sc8180x-edp
+    then:
+      properties:
+        "#sound-dai-cells": false
+    else:
+      properties:
+        aux-bus: false
+      required:
+        - "#sound-dai-cells"
+
 additionalProperties: false
 
 examples:
-- 
2.35.1


  parent reply	other threads:[~2022-07-07 21:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 21:31 [PATCH 0/9] dt-bindings: msm/dp: cleanup Qualcomm DP and eDP bidndings Dmitry Baryshkov
2022-07-07 21:31 ` [PATCH 1/9] dt-bindings: msm/dp: drop extra p1 region Dmitry Baryshkov
2022-07-08  1:28   ` Stephen Boyd
2022-07-08  3:46     ` Dmitry Baryshkov
2022-07-08 19:27       ` Stephen Boyd
2022-07-08 19:38         ` Abhinav Kumar
2022-07-08 19:47           ` Kuogee Hsieh
2022-07-11  8:40             ` Dmitry Baryshkov
2022-07-08 19:51           ` Stephen Boyd
2022-07-08 19:58             ` Abhinav Kumar
2022-07-08 21:32   ` Rob Herring
2022-07-07 21:31 ` [PATCH 2/9] dt-bindings: msm/dp: bring back support for legacy DP reg property Dmitry Baryshkov
2022-07-08  1:29   ` Stephen Boyd
2022-07-08  3:56     ` Dmitry Baryshkov
2022-07-07 21:31 ` [PATCH 3/9] dt-bindings: msm/dp: mark vdda supplies as deprecated Dmitry Baryshkov
2022-07-07 21:31 ` [PATCH 4/9] dt-bindings: msm/dp: add missing properties Dmitry Baryshkov
2022-07-08  1:30   ` Stephen Boyd
2022-07-07 21:32 ` [PATCH 5/9] dt-bindings: msm/dp: account for clocks specific for qcom,sc7280-edp Dmitry Baryshkov
2022-07-08  1:32   ` Stephen Boyd
2022-07-08  3:59     ` Dmitry Baryshkov
2022-07-08 19:24       ` Stephen Boyd
2022-07-07 21:32 ` Dmitry Baryshkov [this message]
2022-07-08  1:33   ` [PATCH 6/9] dt-bindings: msm/dp: handle DP vs eDP difference Stephen Boyd
2022-07-07 21:32 ` [PATCH 7/9] arm64: dts: qcom: sc7180: drop #clock-cells from displayport-controller Dmitry Baryshkov
2022-07-08  1:34   ` Stephen Boyd
2022-07-07 21:32 ` [PATCH 8/9] arm64: dts: qcom: sc7280: " Dmitry Baryshkov
2022-07-08  1:34   ` Stephen Boyd
2022-07-07 21:32 ` [PATCH 9/9] arm64: dts: qcom: sc7280: drop address/size-cells from eDP node Dmitry Baryshkov
2022-07-08  1:34   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707213204.2605816-7-dmitry.baryshkov@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).