From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A33C43334 for ; Fri, 8 Jul 2022 06:33:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237322AbiGHGdW (ORCPT ); Fri, 8 Jul 2022 02:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237324AbiGHGdR (ORCPT ); Fri, 8 Jul 2022 02:33:17 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA28F27166 for ; Thu, 7 Jul 2022 23:33:16 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id a15so10519411pjs.0 for ; Thu, 07 Jul 2022 23:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=H1rFqef4sJqptg9wHlXMkGLnOhStTJVvsg+RpqiXZhk=; b=jL0OXwDeT+1BLLHSd6unR57Dv5PwlNfa7iNaZQD2rw94eOeYM08Qqo1iWM+WwQynIT ccvZC1ZZe0k97NHcgxamAatBF+1h5zfI/O3AkZ6VRHfwdU4tdq4TSz2sFYHVcnmTUC8Q Q5kGajtSsJhMh1eycHPlDVZ1HKN0VErfulPmLtwxDqJq+dR0z0+nX7NSK2nFCG8hrXAW o4S7wtCQpJ1NnYmwlUFiTLxnvedE2uDefGtz2IUI3cTimcANvENK2X4UdmBLRIhxAfy7 JKPR51kqUFwWhmGMVGhWgP2Eq9xCmYm5hHmrqhTwihyVAUDC6sjqgG7t2/8V3gOQAIvn g+UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H1rFqef4sJqptg9wHlXMkGLnOhStTJVvsg+RpqiXZhk=; b=YkJOl2ao0VpYePTvyKekfsrVpMpXa9B3RV+DKgHuD4P3PBBu7CqXiAnt5+YpLiztZi dlgAc6uBYstPvJRSNEgOMiqFEWVMSiikw94x78e0664dSsUwALH1kWc4DN32YW2uYS+3 nwJ+Om9RNyy3zDawFlrvH0P8F2TNLHC8wzwUbOpSAeiOoYbWG258h/9MwZ+B5Iw1ZYrp AQSGfBmJQoFbKWSLGN9pgcHmkttiEDU/8Hla74eBA9DwehHjbD+qjfZUcNdktKLE/tTM T/yI7rVdyOfzVspzQgfq/lZZ6bvchkFlnjZRXAPqi1As0LJ+T8xCA2AR8BYcsDBK0VYE Yg3w== X-Gm-Message-State: AJIora/V2jgW8+FwsFHyQodCgraxSwUp7h7D1A7ozzcohecPgxVmyFuB NbOffzwsaj9AYUeDFzsF5ZVp/Q== X-Google-Smtp-Source: AGRyM1vIiK1fNxbF/3rIjWdLVtB8pM6aA+cUUB9WXd9cJtjH5huqkn6sucKxoGt6HsKsrO5RetOsmQ== X-Received: by 2002:a17:903:32c4:b0:16a:4227:cd68 with SMTP id i4-20020a17090332c400b0016a4227cd68mr1996000plr.173.1657261991495; Thu, 07 Jul 2022 23:33:11 -0700 (PDT) Received: from leoy-ThinkPad-X240s (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id i11-20020a1709026acb00b001640aad2f71sm28936148plt.180.2022.07.07.23.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 23:33:11 -0700 (PDT) Date: Fri, 8 Jul 2022 14:33:07 +0800 From: Leo Yan To: Georgi Djakov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Message-ID: <20220708063307.GB195591@leoy-ThinkPad-X240s> References: <20220705072336.742703-1-leo.yan@linaro.org> <20220705072336.742703-6-leo.yan@linaro.org> <28bf991f-7b4c-0af1-2780-842500b01a0f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28bf991f-7b4c-0af1-2780-842500b01a0f@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 07, 2022 at 05:33:58PM +0300, Georgi Djakov wrote: [...] > > @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > > provider = src->provider; > > qp = to_qcom_provider(provider); > > - list_for_each_entry(n, &provider->nodes, node_list) > > - provider->aggregate(n, 0, n->avg_bw, n->peak_bw, > > - &agg_avg, &agg_peak); > > + qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg, > > + &max_agg_peak); > > - sum_bw = icc_units_to_bps(agg_avg); > > - max_peak_bw = icc_units_to_bps(agg_peak); > > + sum_bw = icc_units_to_bps(max_agg_avg); > > + max_peak_bw = icc_units_to_bps(max_agg_peak); > > ret = __qcom_icc_set(src, src_qn, sum_bw); > > if (ret) > > @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > > return ret; > > } > > - rate = max(sum_bw, max_peak_bw); > > Looks like max_peak_bw is unused now? Yes, will drop it in next spin. Thanks for review. Leo