* [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
@ 2022-07-07 7:00 ` William Zhang
2022-07-08 20:58 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: William Zhang @ 2022-07-07 7:00 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, William Zhang, Krzysztof Kozlowski,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
Add BCM63138 SoC device tree description to bcmbca binding document.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
(no changes since v1)
.../devicetree/bindings/arm/bcm/brcm,bcmbca.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
index b817051c491d..d9dc4f22f4a5 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml
@@ -35,6 +35,14 @@ properties:
- const: brcm,bcm4912
- const: brcm,bcmbca
+ - description: BCM63138 based boards
+ items:
+ - enum:
+ - brcm,bcm963138
+ - brcm,BCM963138DVT
+ - const: brcm,bcm63138
+ - const: brcm,bcmbca
+
- description: BCM63146 based boards
items:
- enum:
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
@ 2022-07-08 20:58 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2022-07-08 20:58 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: joel.peshkin, dan.beygelman, kursad.oney, anand.gore,
Krzysztof Kozlowski, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-kernel
On Thu, 7 Jul 2022 00:00:31 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add BCM63138 SoC device tree description to bcmbca binding document.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
@ 2022-07-07 7:00 ` William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-13 15:26 ` Rafał Miłecki
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
3 siblings, 2 replies; 11+ messages in thread
From: William Zhang @ 2022-07-07 7:00 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, William Zhang, Arnd Bergmann,
Krzysztof Kozlowski, Olof Johansson, Rob Herring, devicetree,
linux-kernel, soc
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
CONFIG_ARCH_BCM_63XX from the makefile
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
(no changes since v1)
arch/arm/boot/dts/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 38d9c60aece7..1bf8e2f8ee68 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
bcm47189-luxul-xap-810.dtb \
bcm47189-tenda-ac9.dtb \
bcm947189acdbmr.dtb
-dtb-$(CONFIG_ARCH_BCM_63XX) += \
- bcm963138dvt.dtb
dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
bcm911360_entphn.dtb \
bcm911360k.dtb \
@@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
bcm7445-bcm97445svmb.dtb
dtb-$(CONFIG_ARCH_BCMBCA) += \
bcm947622.dtb \
+ bcm963138dvt.dtb \
bcm963148.dtb \
bcm963178.dtb \
bcm96756.dtb \
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
@ 2022-07-08 20:59 ` Florian Fainelli
2022-07-13 15:26 ` Rafał Miłecki
1 sibling, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2022-07-08 20:59 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: joel.peshkin, dan.beygelman, kursad.oney, anand.gore,
Arnd Bergmann, Krzysztof Kozlowski, Olof Johansson, Rob Herring,
devicetree, linux-kernel, soc
On Thu, 7 Jul 2022 00:00:32 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
> CONFIG_ARCH_BCM_63XX from the makefile
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
2022-07-08 20:59 ` Florian Fainelli
@ 2022-07-13 15:26 ` Rafał Miłecki
2022-07-13 16:35 ` Florian Fainelli
1 sibling, 1 reply; 11+ messages in thread
From: Rafał Miłecki @ 2022-07-13 15:26 UTC (permalink / raw)
To: William Zhang, Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, Arnd Bergmann, Krzysztof Kozlowski,
Olof Johansson, Rob Herring, devicetree, linux-kernel, soc
On 7.07.2022 09:00, William Zhang wrote:
> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
> CONFIG_ARCH_BCM_63XX from the makefile
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
>
> (no changes since v1)
>
> arch/arm/boot/dts/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 38d9c60aece7..1bf8e2f8ee68 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
> bcm47189-luxul-xap-810.dtb \
> bcm47189-tenda-ac9.dtb \
> bcm947189acdbmr.dtb
> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
> - bcm963138dvt.dtb
> dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
> bcm911360_entphn.dtb \
> bcm911360k.dtb \
> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
> bcm7445-bcm97445svmb.dtb
> dtb-$(CONFIG_ARCH_BCMBCA) += \
> bcm947622.dtb \
> + bcm963138dvt.dtb \
> bcm963148.dtb \
> bcm963178.dtb \
> bcm96756.dtb \
Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
interested in compiling all of them?
For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
/ ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
only.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA
2022-07-13 15:26 ` Rafał Miłecki
@ 2022-07-13 16:35 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2022-07-13 16:35 UTC (permalink / raw)
To: Rafał Miłecki, William Zhang, Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, Arnd Bergmann, Krzysztof Kozlowski,
Olof Johansson, Rob Herring, devicetree, linux-kernel, soc
On 7/13/22 08:26, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
>> CONFIG_ARCH_BCM_63XX from the makefile
>>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>> ---
>>
>> (no changes since v1)
>>
>> arch/arm/boot/dts/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 38d9c60aece7..1bf8e2f8ee68 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
>> bcm47189-luxul-xap-810.dtb \
>> bcm47189-tenda-ac9.dtb \
>> bcm947189acdbmr.dtb
>> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
>> - bcm963138dvt.dtb
>> dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
>> bcm911360_entphn.dtb \
>> bcm911360k.dtb \
>> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>> bcm7445-bcm97445svmb.dtb
>> dtb-$(CONFIG_ARCH_BCMBCA) += \
>> bcm947622.dtb \
>> + bcm963138dvt.dtb \
>> bcm963148.dtb \
>> bcm963178.dtb \
>> bcm96756.dtb \
>
> Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
> interested in compiling all of them?
>
> For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
> / ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
> only.
I am fine with that and build systems (buildroot and OpenWrt at least)
typically offer a way to produce a device specific image that will
contain a single DTB fit for the target device.
What we would be optimizing for would be build time vs. coverage, as a
maintainer I favor coverage as it allows me to build everyone in one
sweep. We could make the building of the 63138 conditional upon
BCMBCA_CORTEXA9 if that bothers you.
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
@ 2022-07-07 7:00 ` William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
3 siblings, 1 reply; 11+ messages in thread
From: William Zhang @ 2022-07-07 7:00 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, William Zhang, Krzysztof Kozlowski,
Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]
Update BCM63138 board compatible string based on binding document.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Changes in v2:
- Remove the unrelated node and and uart clock name changes
arch/arm/boot/dts/bcm63138.dtsi | 4 ++--
arch/arm/boot/dts/bcm963138dvt.dts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/bcm63138.dtsi b/arch/arm/boot/dts/bcm63138.dtsi
index cca49a2e2d62..b774a8d63813 100644
--- a/arch/arm/boot/dts/bcm63138.dtsi
+++ b/arch/arm/boot/dts/bcm63138.dtsi
@@ -9,8 +9,8 @@
/ {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "brcm,bcm63138";
- model = "Broadcom BCM63138 DSL SoC";
+ compatible = "brcm,bcm63138", "brcm,bcmbca";
+ model = "Broadcom BCM963138 Reference Board";
interrupt-parent = <&gic>;
aliases {
diff --git a/arch/arm/boot/dts/bcm963138dvt.dts b/arch/arm/boot/dts/bcm963138dvt.dts
index df5c8ab90627..15bec75be74c 100644
--- a/arch/arm/boot/dts/bcm963138dvt.dts
+++ b/arch/arm/boot/dts/bcm963138dvt.dts
@@ -8,7 +8,7 @@
#include "bcm63138.dtsi"
/ {
- compatible = "brcm,BCM963138DVT", "brcm,bcm63138";
+ compatible = "brcm,BCM963138DVT", "brcm,bcm63138", "brcm,bcmbca";
model = "Broadcom BCM963138DVT";
chosen {
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
@ 2022-07-08 20:59 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2022-07-08 20:59 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: joel.peshkin, dan.beygelman, kursad.oney, anand.gore,
Krzysztof Kozlowski, Krzysztof Kozlowski, Rob Herring, devicetree,
linux-kernel
On Thu, 7 Jul 2022 00:00:33 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Update BCM63138 board compatible string based on binding document.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
` (2 preceding siblings ...)
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
@ 2022-07-07 7:00 ` William Zhang
2022-07-08 21:00 ` Florian Fainelli
3 siblings, 1 reply; 11+ messages in thread
From: William Zhang @ 2022-07-07 7:00 UTC (permalink / raw)
To: Linux ARM List
Cc: Broadcom Kernel List, joel.peshkin, dan.beygelman, kursad.oney,
f.fainelli, anand.gore, William Zhang, Arnd Bergmann,
Krzysztof Kozlowski, Olof Johansson, Rob Herring, devicetree,
linux-kernel, soc
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
Add generic bcm963138.dts file.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
(no changes since v1)
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/bcm963138.dts | 27 +++++++++++++++++++++++++++
2 files changed, 28 insertions(+)
create mode 100644 arch/arm/boot/dts/bcm963138.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 1bf8e2f8ee68..d2b64aaf2874 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -182,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
bcm7445-bcm97445svmb.dtb
dtb-$(CONFIG_ARCH_BCMBCA) += \
bcm947622.dtb \
+ bcm963138.dtb \
bcm963138dvt.dtb \
bcm963148.dtb \
bcm963178.dtb \
diff --git a/arch/arm/boot/dts/bcm963138.dts b/arch/arm/boot/dts/bcm963138.dts
new file mode 100644
index 000000000000..d28c4f130ca2
--- /dev/null
+++ b/arch/arm/boot/dts/bcm963138.dts
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright 2022 Broadcom Ltd.
+ */
+
+/dts-v1/;
+
+#include "bcm63138.dtsi"
+
+/ {
+ model = "Broadcom BCM963138 Reference Board";
+ compatible = "brcm,bcm963138", "brcm,bcm63138", "brcm,bcmbca";
+
+ chosen {
+ bootargs = "console=ttyS0,115200";
+ stdout-path = &serial0;
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x08000000>;
+ };
+};
+
+&serial0 {
+ status = "okay";
+};
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
@ 2022-07-08 21:00 ` Florian Fainelli
0 siblings, 0 replies; 11+ messages in thread
From: Florian Fainelli @ 2022-07-08 21:00 UTC (permalink / raw)
To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
Cc: joel.peshkin, dan.beygelman, kursad.oney, anand.gore,
Arnd Bergmann, Krzysztof Kozlowski, Olof Johansson, Rob Herring,
devicetree, linux-kernel, soc
On Thu, 7 Jul 2022 00:00:34 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add generic bcm963138.dts file.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 11+ messages in thread